The MTP is a one of the boards that comes with the Eliza SoC.
So add dedicated board dts for it.
The initial support enables:
- UART debug console
- Ob-board UFS storage
- Qualcomm RPMh regulators (PMIC) and VPH_PWR
- board specific clocks & reserved GPIO ranges
Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/eliza-mtp.dts | 407 +++++++++++++++++++++++++++++++++
2 files changed, 408 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 02921a495b2c..e4dc0aab3bf6 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -14,6 +14,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb
dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
dtb-$(CONFIG_ARCH_QCOM) += apq8096sg-db820c.dtb
dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
+dtb-$(CONFIG_ARCH_QCOM) += eliza-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += glymur-crd.dtb
dtb-$(CONFIG_ARCH_QCOM) += hamoa-iot-evk.dtb
diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
new file mode 100644
index 000000000000..e7b564281739
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
@@ -0,0 +1,407 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include "eliza.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. Eliza MTP";
+ compatible = "qcom,eliza-mtp", "qcom,eliza";
+ chassis-type = "handset";
+
+ aliases {
+ serial0 = &uart14;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ clocks {
+ xo_board: xo-board {
+ compatible = "fixed-clock";
+ clock-frequency = <76800000>;
+ #clock-cells = <0>;
+ };
+
+ sleep_clk: sleep-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <32764>;
+ #clock-cells = <0>;
+ };
+
+ bi_tcxo_div2: bi-tcxo-div2-clk {
+ compatible = "fixed-factor-clock";
+ #clock-cells = <0>;
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ };
+
+ bi_tcxo_ao_div2: bi-tcxo-ao-div2-clk {
+ compatible = "fixed-factor-clock";
+ #clock-cells = <0>;
+
+ clocks = <&rpmhcc RPMH_CXO_CLK_A>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ };
+ };
+
+ vph_pwr: regulator-vph-pwr {
+ compatible = "regulator-fixed";
+
+ regulator-name = "vph_pwr";
+ regulator-min-microvolt = <3700000>;
+ regulator-max-microvolt = <3700000>;
+
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&apps_rsc {
+ regulators-0 {
+ compatible = "qcom,pm7550-rpmh-regulators";
+
+ vdd-l1-supply = <&vreg_s3b>;
+ vdd-l2-l3-supply = <&vreg_s3b>;
+ vdd-l4-l5-supply = <&vreg_s2b>;
+ vdd-l6-supply = <&vreg_s2b>;
+ vdd-l7-supply = <&vreg_s1b>;
+ vdd-l8-supply = <&vreg_s1b>;
+ vdd-l9-l10-supply = <&vreg_s1b>;
+ vdd-l11-supply = <&vreg_s1b>;
+ vdd-l12-l14-supply = <&vreg_bob>;
+ vdd-l13-l16-supply = <&vreg_bob>;
+ vdd-l15-l17-l18-l19-l20-l21-l22-l23-supply = <&vreg_bob>;
+ vdd-s1-supply = <&vph_pwr>;
+ vdd-s2-supply = <&vph_pwr>;
+ vdd-s3-supply = <&vph_pwr>;
+ vdd-s4-supply = <&vph_pwr>;
+ vdd-s5-supply = <&vph_pwr>;
+ vdd-s6-supply = <&vph_pwr>;
+
+ vdd-bob-supply = <&vph_pwr>;
+
+ qcom,pmic-id = "b";
+
+ vreg_s1b: smps1 {
+ regulator-name = "vreg_s1b";
+ regulator-min-microvolt = <1850000>;
+ regulator-max-microvolt = <2040000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_s2b: smps2 {
+ regulator-name = "vreg_s2b";
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <2744000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_s3b: smps3 {
+ regulator-name = "vreg_s3b";
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <2744000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_s4b: smps4 {
+ regulator-name = "vreg_s4b";
+ regulator-min-microvolt = <2156000>;
+ regulator-max-microvolt = <2400000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l2b: ldo2 {
+ regulator-name = "vreg_l2b";
+ regulator-min-microvolt = <720000>;
+ regulator-max-microvolt = <950000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l3b: ldo3 {
+ regulator-name = "vreg_l3b";
+ regulator-min-microvolt = <880000>;
+ regulator-max-microvolt = <912000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l4b: ldo4 {
+ regulator-name = "vreg_l4b";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l6b: ldo6 {
+ regulator-name = "vreg_l6b";
+ regulator-min-microvolt = <866000>;
+ regulator-max-microvolt = <958000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l7b: ldo7 {
+ regulator-name = "vreg_l7b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l8b: ldo8 {
+ regulator-name = "vreg_l8b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l9b: ldo9 {
+ regulator-name = "vreg_l9b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l10b: ldo10 {
+ regulator-name = "vreg_l10b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l11b: ldo11 {
+ regulator-name = "vreg_l11b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l12b: ldo12 {
+ regulator-name = "vreg_l12b";
+ /*
+ * Skip voltage voting for UFS VCC.
+ */
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l13b: ldo13 {
+ regulator-name = "vreg_l13b";
+ regulator-min-microvolt = <2700000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l14b: ldo14 {
+ regulator-name = "vreg_l14b";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3304000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l15b: ldo15 {
+ regulator-name = "vreg_l15b";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3304000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l16b: ldo16 {
+ regulator-name = "vreg_l16b";
+ regulator-min-microvolt = <3008000>;
+ regulator-max-microvolt = <3008000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l17b: ldo17 {
+ regulator-name = "vreg_l17b";
+ regulator-min-microvolt = <3104000>;
+ regulator-max-microvolt = <3104000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l18b: ldo18 {
+ regulator-name = "vreg_l18b";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l19b: ldo19 {
+ regulator-name = "vreg_l19b";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l20b: ldo20 {
+ regulator-name = "vreg_l20b";
+ regulator-min-microvolt = <1620000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l21b: ldo21 {
+ regulator-name = "vreg_l21b";
+ regulator-min-microvolt = <1620000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l22b: ldo22 {
+ regulator-name = "vreg_l22b";
+ regulator-min-microvolt = <3200000>;
+ regulator-max-microvolt = <3200000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l23b: ldo23 {
+ regulator-name = "vreg_l23b";
+ regulator-min-microvolt = <1650000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_bob: bob {
+ regulator-name = "vreg_bob";
+ regulator-min-microvolt = <3008000>;
+ regulator-max-microvolt = <3960000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+
+ regulators-1 {
+ compatible = "qcom,pm8550vs-rpmh-regulators";
+
+ vdd-l1-supply = <&vreg_s2b>;
+
+ qcom,pmic-id = "d";
+
+ vreg_l1d: ldo1 {
+ regulator-name = "vreg_l1d";
+ regulator-min-microvolt = <1140000>;
+ regulator-max-microvolt = <1260000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+
+ regulators-2 {
+ compatible = "qcom,pm8550vs-rpmh-regulators";
+
+ vdd-l1-supply = <&vreg_s2b>;
+ vdd-l3-supply = <&vreg_s2b>;
+
+ qcom,pmic-id = "g";
+
+ vreg_l1g: ldo1 {
+ regulator-name = "vreg_l1g";
+ regulator-min-microvolt = <1150000>;
+ regulator-max-microvolt = <1260000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l3g: ldo3 {
+ regulator-name = "vreg_l3g";
+ regulator-min-microvolt = <1150000>;
+ regulator-max-microvolt = <1260000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ };
+
+ regulators-3 {
+ compatible = "qcom,pmr735d-rpmh-regulators";
+
+ vdd-l1-l2-l5-supply = <&vreg_s3b>;
+ vdd-l3-l4-supply = <&vreg_s2b>;
+ vdd-l6-supply = <&vreg_s1b>;
+ vdd-l7-supply = <&vreg_s3b>;
+
+ qcom,pmic-id = "k";
+
+ vreg_l1k: ldo1 {
+ regulator-name = "vreg_l1k";
+ regulator-min-microvolt = <488000>;
+ regulator-max-microvolt = <912000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l2k: ldo2 {
+ regulator-name = "vreg_l2k";
+ regulator-min-microvolt = <920000>;
+ regulator-max-microvolt = <969000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l3k: ldo3 {
+ regulator-name = "vreg_l3k";
+ regulator-min-microvolt = <1080000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l4k: ldo4 {
+ regulator-name = "vreg_l4k";
+ regulator-min-microvolt = <960000>;
+ regulator-max-microvolt = <1980000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l5k: ldo5 {
+ regulator-name = "vreg_l5k";
+ regulator-min-microvolt = <866000>;
+ regulator-max-microvolt = <931000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l6k: ldo6 {
+ regulator-name = "vreg_l6k";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l7k: ldo7 {
+ regulator-name = "vreg_l7k";
+ regulator-min-microvolt = <720000>;
+ regulator-max-microvolt = <958000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+};
+
+&tlmm {
+ gpio-reserved-ranges = <20 4>, /* NFC SPI */
+ <111 2>, /* WCN UART1 */
+ <118 1>; /* NFC Secure I/O */
+};
+
+&uart14 {
+ compatible = "qcom,geni-debug-uart";
+
+ status = "okay";
+};
+
+&ufs_mem_hc {
+ reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>;
+
+ vcc-supply = <&vreg_l12b>;
+ vcc-max-microamp = <1300000>;
+ vccq-supply = <&vreg_l1d>;
+ vccq-max-microamp = <1200000>;
+
+ status = "okay";
+};
+
+&ufs_mem_phy {
+ vdda-phy-supply = <&vreg_l6b>;
+ vdda-pll-supply = <&vreg_l4b>;
+
+ status = "okay";
+};
--
2.48.1On Fri, Mar 13, 2026 at 03:23:52PM +0200, Abel Vesa wrote:
> The MTP is a one of the boards that comes with the Eliza SoC.
> So add dedicated board dts for it.
>
> The initial support enables:
> - UART debug console
> - Ob-board UFS storage
> - Qualcomm RPMh regulators (PMIC) and VPH_PWR
> - board specific clocks & reserved GPIO ranges
>
> Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/eliza-mtp.dts | 407 +++++++++++++++++++++++++++++++++
> 2 files changed, 408 insertions(+)
>
> +
> + vreg_l12b: ldo12 {
> + regulator-name = "vreg_l12b";
> + /*
> + * Skip voltage voting for UFS VCC.
Please continue with 'why?'
> + */
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> +
--
With best wishes
Dmitry
On 26-03-13 17:51:37, Dmitry Baryshkov wrote:
> On Fri, Mar 13, 2026 at 03:23:52PM +0200, Abel Vesa wrote:
> > The MTP is a one of the boards that comes with the Eliza SoC.
> > So add dedicated board dts for it.
> >
> > The initial support enables:
> > - UART debug console
> > - Ob-board UFS storage
> > - Qualcomm RPMh regulators (PMIC) and VPH_PWR
> > - board specific clocks & reserved GPIO ranges
> >
> > Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/Makefile | 1 +
> > arch/arm64/boot/dts/qcom/eliza-mtp.dts | 407 +++++++++++++++++++++++++++++++++
> > 2 files changed, 408 insertions(+)
> >
> > +
> > + vreg_l12b: ldo12 {
> > + regulator-name = "vreg_l12b";
> > + /*
> > + * Skip voltage voting for UFS VCC.
>
> Please continue with 'why?'
Actually, I think I'm going to drop the comment and add the voltages range
in here.
For some reason, when I added these, I considered that if other platforms
are skipping the voltage voting, Eliza should do that too. But now that I
took another look, I really don't think the voltage voting should be
skipped at all.
Downstream does the voting as well.
So I'm going to add the following in the next version:
regulator-min-microvolt = <2400000>;
regulator-max-microvolt = <3300000>;
Thanks for pointing this out.
On Tue, Mar 17, 2026 at 10:47:18AM +0200, Abel Vesa wrote:
> On 26-03-13 17:51:37, Dmitry Baryshkov wrote:
> > On Fri, Mar 13, 2026 at 03:23:52PM +0200, Abel Vesa wrote:
> > > The MTP is a one of the boards that comes with the Eliza SoC.
> > > So add dedicated board dts for it.
> > >
> > > The initial support enables:
> > > - UART debug console
> > > - Ob-board UFS storage
> > > - Qualcomm RPMh regulators (PMIC) and VPH_PWR
> > > - board specific clocks & reserved GPIO ranges
> > >
> > > Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > > ---
> > > arch/arm64/boot/dts/qcom/Makefile | 1 +
> > > arch/arm64/boot/dts/qcom/eliza-mtp.dts | 407 +++++++++++++++++++++++++++++++++
> > > 2 files changed, 408 insertions(+)
> > >
> > > +
> > > + vreg_l12b: ldo12 {
> > > + regulator-name = "vreg_l12b";
> > > + /*
> > > + * Skip voltage voting for UFS VCC.
> >
> > Please continue with 'why?'
>
> Actually, I think I'm going to drop the comment and add the voltages range
> in here.
>
> For some reason, when I added these, I considered that if other platforms
> are skipping the voltage voting, Eliza should do that too. But now that I
> took another look, I really don't think the voltage voting should be
> skipped at all.
>
> Downstream does the voting as well.
>
> So I'm going to add the following in the next version:
>
> regulator-min-microvolt = <2400000>;
> regulator-max-microvolt = <3300000>;
>
> Thanks for pointing this out.
FWIW I consider boards with different UFS PHYs to be different boards
and so there should be an overlay changing the supplies for the
non-standard version.
--
With best wishes
Dmitry
On 26-03-17 17:10:17, Dmitry Baryshkov wrote:
> On Tue, Mar 17, 2026 at 10:47:18AM +0200, Abel Vesa wrote:
> > On 26-03-13 17:51:37, Dmitry Baryshkov wrote:
> > > On Fri, Mar 13, 2026 at 03:23:52PM +0200, Abel Vesa wrote:
> > > > The MTP is a one of the boards that comes with the Eliza SoC.
> > > > So add dedicated board dts for it.
> > > >
> > > > The initial support enables:
> > > > - UART debug console
> > > > - Ob-board UFS storage
> > > > - Qualcomm RPMh regulators (PMIC) and VPH_PWR
> > > > - board specific clocks & reserved GPIO ranges
> > > >
> > > > Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > > > ---
> > > > arch/arm64/boot/dts/qcom/Makefile | 1 +
> > > > arch/arm64/boot/dts/qcom/eliza-mtp.dts | 407 +++++++++++++++++++++++++++++++++
> > > > 2 files changed, 408 insertions(+)
> > > >
> > > > +
> > > > + vreg_l12b: ldo12 {
> > > > + regulator-name = "vreg_l12b";
> > > > + /*
> > > > + * Skip voltage voting for UFS VCC.
> > >
> > > Please continue with 'why?'
> >
> > Actually, I think I'm going to drop the comment and add the voltages range
> > in here.
> >
> > For some reason, when I added these, I considered that if other platforms
> > are skipping the voltage voting, Eliza should do that too. But now that I
> > took another look, I really don't think the voltage voting should be
> > skipped at all.
> >
> > Downstream does the voting as well.
> >
> > So I'm going to add the following in the next version:
> >
> > regulator-min-microvolt = <2400000>;
> > regulator-max-microvolt = <3300000>;
> >
> > Thanks for pointing this out.
>
> FWIW I consider boards with different UFS PHYs to be different boards
> and so there should be an overlay changing the supplies for the
> non-standard version.
Yep, me too.
I'll send the next version tomorrow with the range mentioned above in.
On 26-03-17 21:13:22, Abel Vesa wrote:
> On 26-03-17 17:10:17, Dmitry Baryshkov wrote:
> > On Tue, Mar 17, 2026 at 10:47:18AM +0200, Abel Vesa wrote:
> > > On 26-03-13 17:51:37, Dmitry Baryshkov wrote:
> > > > On Fri, Mar 13, 2026 at 03:23:52PM +0200, Abel Vesa wrote:
> > > > > The MTP is a one of the boards that comes with the Eliza SoC.
> > > > > So add dedicated board dts for it.
> > > > >
> > > > > The initial support enables:
> > > > > - UART debug console
> > > > > - Ob-board UFS storage
> > > > > - Qualcomm RPMh regulators (PMIC) and VPH_PWR
> > > > > - board specific clocks & reserved GPIO ranges
> > > > >
> > > > > Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > > > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > > > > ---
> > > > > arch/arm64/boot/dts/qcom/Makefile | 1 +
> > > > > arch/arm64/boot/dts/qcom/eliza-mtp.dts | 407 +++++++++++++++++++++++++++++++++
> > > > > 2 files changed, 408 insertions(+)
> > > > >
> > > > > +
> > > > > + vreg_l12b: ldo12 {
> > > > > + regulator-name = "vreg_l12b";
> > > > > + /*
> > > > > + * Skip voltage voting for UFS VCC.
> > > >
> > > > Please continue with 'why?'
> > >
> > > Actually, I think I'm going to drop the comment and add the voltages range
> > > in here.
> > >
> > > For some reason, when I added these, I considered that if other platforms
> > > are skipping the voltage voting, Eliza should do that too. But now that I
> > > took another look, I really don't think the voltage voting should be
> > > skipped at all.
> > >
> > > Downstream does the voting as well.
> > >
> > > So I'm going to add the following in the next version:
> > >
> > > regulator-min-microvolt = <2400000>;
> > > regulator-max-microvolt = <3300000>;
> > >
> > > Thanks for pointing this out.
> >
> > FWIW I consider boards with different UFS PHYs to be different boards
> > and so there should be an overlay changing the supplies for the
> > non-standard version.
>
> Yep, me too.
>
> I'll send the next version tomorrow with the range mentioned above in.
Sorry for the back and forth on this.
Just had this bit explained to me by the UFS folks.
So the MTP can have different UFS devices which support different
versions. The UFS devices, depending on the UFS version supported,
need different voltages. Bootloader will pick the right voltage
and we should rely on that. That is the reason for not describing the
voltage range.
Now, with this in mind, I think the overlay for each different UFS device
is a bit of an overkill. But maybe I'm wrong.
So if you are okay with this explanation, I'll fix the comment to
explain why and respin ...
© 2016 - 2026 Red Hat, Inc.