iio: accel: adxl313: add missing error check in predisable

[PATCH] iio: accel: adxl313: add missing error check in predisable

Posted by Antoniu Miclaus 3 weeks, 5 days ago

Check the return value of the FIFO bypass regmap_write() before
proceeding to disable interrupts.

Fixes: ff8093fa6ba4 ("iio: accel: adxl313: add buffered FIFO watermark with interrupt handling")
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/accel/adxl313_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/accel/adxl313_core.c b/drivers/iio/accel/adxl313_core.c
index 9f5d4d2cb325..83dcac17a042 100644
--- a/drivers/iio/accel/adxl313_core.c
+++ b/drivers/iio/accel/adxl313_core.c
@@ -998,6 +998,8 @@ static int adxl313_buffer_predisable(struct iio_dev *indio_dev)
 
 	ret = regmap_write(data->regmap, ADXL313_REG_FIFO_CTL,
 			   FIELD_PREP(ADXL313_REG_FIFO_CTL_MODE_MSK, ADXL313_FIFO_BYPASS));
+	if (ret)
+		return ret;
 
 	ret = regmap_write(data->regmap, ADXL313_REG_INT_ENABLE, 0);
 	if (ret)
-- 
2.43.0

Re: [PATCH] iio: accel: adxl313: add missing error check in predisable

Posted by Andy Shevchenko 3 weeks, 4 days ago

On Thu, Mar 12, 2026 at 01:20:23PM +0200, Antoniu Miclaus wrote:
> Check the return value of the FIFO bypass regmap_write() before
> proceeding to disable interrupts.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: accel: adxl313: add missing error check in predisable

Posted by Jonathan Cameron 2 weeks, 2 days ago

On Fri, 13 Mar 2026 11:41:48 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Mar 12, 2026 at 01:20:23PM +0200, Antoniu Miclaus wrote:
> > Check the return value of the FIFO bypass regmap_write() before
> > proceeding to disable interrupts.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
Applied and marked for stable.

Thanks,

Jonathan