1. Patchew
  2. linux
  3. [PATCH v2 0/3] iio: light: vcnl4000: add regulator support
  4. View patch

[PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators

Erikas Bitovtas posted 3 patches 3 weeks, 5 days ago
There is a newer version of this series
[PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators
Posted by Erikas Bitovtas 3 weeks, 5 days ago 
This commit adds regulator properties for vcnl4000 ambient light and
proximity sensors.

Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
 Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
index 2ba4d5de4ec4..a1b4c02db246 100644
--- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
+++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
@@ -33,6 +33,10 @@ properties:
   interrupts:
     maxItems: 1
 
+  vdd-supply: true
+  vddio-supply: true
+  vled-supply: true
+
   reg:
     maxItems: 1
 
@@ -54,6 +58,9 @@ examples:
             compatible = "vishay,vcnl4200";
             reg = <0x51>;
             proximity-near-level = <220>;
+            vdd-supply = <&reg_vdd>;
+            vddio-supply = <&reg_vddio>;
+            vled-supply = <&reg_vled>;
         };
     };
 ...

-- 
2.53.0
Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators
Posted by Conor Dooley 3 weeks, 4 days ago 
On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote:
> This commit adds regulator properties for vcnl4000 ambient light and
> proximity sensors.

This we can see. Your commit message should say why.

Do all devices in the binding have all of these supplies?

> 
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 2ba4d5de4ec4..a1b4c02db246 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -33,6 +33,10 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  vdd-supply: true
> +  vddio-supply: true
> +  vled-supply: true
> +
>    reg:
>      maxItems: 1
>  
> @@ -54,6 +58,9 @@ examples:
>              compatible = "vishay,vcnl4200";
>              reg = <0x51>;
>              proximity-near-level = <220>;
> +            vdd-supply = <&reg_vdd>;
> +            vddio-supply = <&reg_vddio>;
> +            vled-supply = <&reg_vled>;
>          };
>      };
>  ...
> 
> -- 
> 2.53.0
>
Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators
Posted by Erikas Bitovtas 3 weeks, 3 days ago 

On 3/12/26 7:39 PM, Conor Dooley wrote:
> On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote:
>> This commit adds regulator properties for vcnl4000 ambient light and
>> proximity sensors.
> 
> This we can see. Your commit message should say why.
> 
> Do all devices in the binding have all of these supplies?
> 

If we look at the datasheet for vcnl4040,
https://www.vishay.com/docs/84274/vcnl4040.pdf, in figure 11 we can see
that there can be 3 supplies: sensor supply Vdd (vdd), I2C supply for
the bus Vpull_up (vddio) and IR LED anode Vdd_led (vled).
The other datasheets refer to three supplies as well - one for the
sensor, one for anode and one for the bus:
https://www.vishay.com/docs/83372/vcnl4000.pdf
https://www.vishay.com/docs/84138/designingvcnl4010.pdf
https://www.vishay.com/docs/84327/designingvcnl4200.pdf

>>
>> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> index 2ba4d5de4ec4..a1b4c02db246 100644
>> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> @@ -33,6 +33,10 @@ properties:
>>    interrupts:
>>      maxItems: 1
>>  
>> +  vdd-supply: true
>> +  vddio-supply: true
>> +  vled-supply: true
>> +
>>    reg:
>>      maxItems: 1
>>  
>> @@ -54,6 +58,9 @@ examples:
>>              compatible = "vishay,vcnl4200";
>>              reg = <0x51>;
>>              proximity-near-level = <220>;
>> +            vdd-supply = <&reg_vdd>;
>> +            vddio-supply = <&reg_vddio>;
>> +            vled-supply = <&reg_vled>;
>>          };
>>      };
>>  ...
>>
>> -- 
>> 2.53.0
>>
Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators
Posted by Conor Dooley 3 weeks, 3 days ago 
On Fri, Mar 13, 2026 at 06:39:25PM +0200, Erikas Bitovtas wrote:
> 
> 
> On 3/12/26 7:39 PM, Conor Dooley wrote:
> > On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote:
> >> This commit adds regulator properties for vcnl4000 ambient light and
> >> proximity sensors.
> > 
> > This we can see. Your commit message should say why.
> > 
> > Do all devices in the binding have all of these supplies?
> > 
> 
> If we look at the datasheet for vcnl4040,
> https://www.vishay.com/docs/84274/vcnl4040.pdf, in figure 11 we can see
> that there can be 3 supplies: sensor supply Vdd (vdd), I2C supply for
> the bus Vpull_up (vddio) and IR LED anode Vdd_led (vled).
> The other datasheets refer to three supplies as well - one for the
> sensor, one for anode and one for the bus:
> https://www.vishay.com/docs/83372/vcnl4000.pdf
> https://www.vishay.com/docs/84138/designingvcnl4010.pdf
> https://www.vishay.com/docs/84327/designingvcnl4200.pdf

Please provide this information in the commit message in v2.

Thanks,
Conor.
pw-bot: changes-requested

> 
> >>
> >> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> >> ---
> >>  Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> index 2ba4d5de4ec4..a1b4c02db246 100644
> >> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> @@ -33,6 +33,10 @@ properties:
> >>    interrupts:
> >>      maxItems: 1
> >>  
> >> +  vdd-supply: true
> >> +  vddio-supply: true
> >> +  vled-supply: true
> >> +
> >>    reg:
> >>      maxItems: 1
> >>  
> >> @@ -54,6 +58,9 @@ examples:
> >>              compatible = "vishay,vcnl4200";
> >>              reg = <0x51>;
> >>              proximity-near-level = <220>;
> >> +            vdd-supply = <&reg_vdd>;
> >> +            vddio-supply = <&reg_vddio>;
> >> +            vled-supply = <&reg_vled>;
> >>          };
> >>      };
> >>  ...
> >>
> >> -- 
> >> 2.53.0
> >>
>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.