[v2] iio: light: vcnl4000: add regulator support

[PATCH v2 0/3] iio: light: vcnl4000: add regulator support

Posted by Erikas Bitovtas 3 weeks, 5 days ago

This patch series introduces support for voltage supply, I2C and cathode
regulators. This fixes an issue where if a regulator is shared between
the proximity sensor and some other device, and the other device is
powered off, the proximity sensor would be powered off as well.

One of the commits includes a Reported-by: tag without a Closes: tag -
the report was done outside of LKML.

Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
Changes in v2:
- Removed double quotes in includes.
- Reordered includes alphabetically.
- Enabled regulators before the mutex is initialized.
- Replaced direct usage of &client->dev with a variable.
- Link to v1: https://lore.kernel.org/r/20260311-vcnl4000-regulators-v1-0-66b6038ce563@gmail.com

---
Erikas Bitovtas (3):
      dt-bindings: iio: light: vcnl4000: add regulators
      iio: light: vcnl4000: add support for regulators
      iio: light: vcnl4000: move client->dev in probe into a variable

 .../bindings/iio/light/vishay,vcnl4000.yaml        |  7 ++++
 drivers/iio/light/vcnl4000.c                       | 41 +++++++++++++---------
 2 files changed, 32 insertions(+), 16 deletions(-)
---
base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
change-id: 20260310-vcnl4000-regulators-bcf1b8a01ce6

Best regards,
-- 
Erikas Bitovtas <xerikasxx@gmail.com>

Re: [PATCH v2 0/3] iio: light: vcnl4000: add regulator support

Posted by Andy Shevchenko 3 weeks, 5 days ago

On Thu, Mar 12, 2026 at 01:53:11PM +0200, Erikas Bitovtas wrote:
> This patch series introduces support for voltage supply, I2C and cathode
> regulators. This fixes an issue where if a regulator is shared between
> the proximity sensor and some other device, and the other device is
> powered off, the proximity sensor would be powered off as well.
> 
> One of the commits includes a Reported-by: tag without a Closes: tag -
> the report was done outside of LKML.

...

> - Removed double quotes in includes.

> - Reordered includes alphabetically.

Yes, but should be done in a separate change.


> - Enabled regulators before the mutex is initialized.

Why?

> - Replaced direct usage of &client->dev with a variable.

...

TL;DR: this has to be series out of 6 patches.

-- 
With Best Regards,
Andy Shevchenko