[PATCH v3 1/3] dt-bindings: display: panel: Add Samsung S6E8FCO-M1906F9

Yedaya Katsman posted 3 patches 3 weeks, 5 days ago
There is a newer version of this series
[PATCH v3 1/3] dt-bindings: display: panel: Add Samsung S6E8FCO-M1906F9
Posted by Yedaya Katsman 3 weeks, 5 days ago
Document Samsung S6E8FCO DTS binding used with the M1906F9 6.09" 720x1560
panel found in the Xiaomi Mi A3 smartphone.

Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com>
Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com>
Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com>
---
 .../display/panel/samsung,s6e8fco-m1906f9.yaml     | 63 ++++++++++++++++++++++
 MAINTAINERS                                        |  5 ++
 2 files changed, 68 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..927d170793dcd49c19ebe353268980710ad4b5b2
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/samsung,s6e8fco-m1906f9.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung S6E8FCO DSI for the Samsung M1906F9 AMOLED Panel
+
+maintainers:
+  - Yedaya Katsman <yedaya.ka@gmail.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: samsung,s6e8fco-m1906f9
+
+  reg:
+    maxItems: 1
+
+  vddi-supply:
+    description: VDDI regulator
+  vci-supply:
+    description: VCI regulator
+  reset-gpios: true
+  port: true
+
+required:
+  - compatible
+  - reg
+  - vddi-supply
+  - vci-supply
+  - port
+  - reset-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "samsung,s6e8fco-m1906f9";
+            reg = <0>;
+
+            vddi-supply = <&panel_vddi_1p8>;
+            vci-supply = <&panel_vci_3p0>;
+
+            reset-gpios = <&tlmm 90 GPIO_ACTIVE_LOW>;
+
+            port {
+                panel_in: endpoint {
+                    remote-endpoint = <&mdss_dsi0_out>;
+                };
+            };
+        };
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index e087673237636268346979ddc270f8cf0905c722..d7aee8dab903cd42c245fea3cf8971dcd99b2196 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8183,6 +8183,11 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
 F:	drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
 
+DRM DRIVER FOR SAMSUNG S6E8FCO PANELS
+M:	Yedaya Katsman <yedaya.ka@gmail.com>
+S:	Maintained
+F:	Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
+
 DRM DRIVER FOR SAMSUNG SOFEF00 DDIC
 M:	David Heidelberg <david@ixit.cz>
 M:	Casey Connolly <casey.connolly@linaro.org>

-- 
2.53.0

Re: [PATCH v3 1/3] dt-bindings: display: panel: Add Samsung S6E8FCO-M1906F9
Posted by Krzysztof Kozlowski 3 weeks, 4 days ago
On Thu, Mar 12, 2026 at 01:55:08PM +0200, Yedaya Katsman wrote:
> Document Samsung S6E8FCO DTS binding used with the M1906F9 6.09" 720x1560
> panel found in the Xiaomi Mi A3 smartphone.
> 
> Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com>
> Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com>
> Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com>
> ---
>  .../display/panel/samsung,s6e8fco-m1906f9.yaml     | 63 ++++++++++++++++++++++
>  MAINTAINERS                                        |  5 ++
>  2 files changed, 68 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..927d170793dcd49c19ebe353268980710ad4b5b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/samsung,s6e8fco-m1906f9.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S6E8FCO DSI for the Samsung M1906F9 AMOLED Panel
> +
> +maintainers:
> +  - Yedaya Katsman <yedaya.ka@gmail.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: samsung,s6e8fco-m1906f9
> +
> +  reg:
> +    maxItems: 1
> +
> +  vddi-supply:
> +    description: VDDI regulator
> +  vci-supply:
> +    description: VCI regulator

I pointed out last time to other schemas and after changes you should
notice that it is the same as other bindings. Or almost the same. See:
samsung,s6e88a0-ams452ef01
samsung,s6e88a0-ams427ap24
samsung,s6e8aa5x01-ams561ra01

so should be added there - to the last one - instead of having one more
file. On mentioned schematics I did not see the panel, thus the pin
supply does not need to be named VDDI, just because output of the PMIC
is called like that.

Best regards,
Krzysztof