gpio/pinctrl: spacemit: Add GPIO pin configuration support for K1

[PATCH 2/2] gpio: spacemit-k1: Add set_config callback support

Posted by Junhui Liu 3 weeks, 5 days ago

Assign gpiochip_generic_config() to the set_config() callback to support
pin configuration through the GPIO subsystem. This allows users to
configure GPIO pin attributes like pull-up/down when specifying a GPIO
line in the Device Tree.

Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
---
 drivers/gpio/gpio-spacemit-k1.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-spacemit-k1.c b/drivers/gpio/gpio-spacemit-k1.c
index dbd2e81094b9..5fe813b7f9bb 100644
--- a/drivers/gpio/gpio-spacemit-k1.c
+++ b/drivers/gpio/gpio-spacemit-k1.c
@@ -228,6 +228,7 @@ static int spacemit_gpio_add_bank(struct spacemit_gpio *sg,
 	gc->label		= dev_name(dev);
 	gc->request		= gpiochip_generic_request;
 	gc->free		= gpiochip_generic_free;
+	gc->set_config		= gpiochip_generic_config;
 	gc->ngpio		= SPACEMIT_NR_GPIOS_PER_BANK;
 	gc->base		= -1;
 	gc->of_gpio_n_cells	= 3;

-- 
2.53.0

Re: [PATCH 2/2] gpio: spacemit-k1: Add set_config callback support

Posted by Anand Moon 3 weeks, 3 days ago

Hi Junhui,

On Thu, 12 Mar 2026 at 14:14, Junhui Liu <junhui.liu@pigmoral.tech> wrote:
>
> Assign gpiochip_generic_config() to the set_config() callback to support
> pin configuration through the GPIO subsystem. This allows users to
> configure GPIO pin attributes like pull-up/down when specifying a GPIO
> line in the Device Tree.
>
> Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
> ---

Reviewed-by: Anand Moon <linux.amoon@gmail.com>

Thanks
-Anand

Re: [PATCH 2/2] gpio: spacemit-k1: Add set_config callback support

Posted by Bartosz Golaszewski 3 weeks, 4 days ago

On Thu, Mar 12, 2026 at 9:43 AM Junhui Liu <junhui.liu@pigmoral.tech> wrote:
>
> Assign gpiochip_generic_config() to the set_config() callback to support
> pin configuration through the GPIO subsystem. This allows users to
> configure GPIO pin attributes like pull-up/down when specifying a GPIO
> line in the Device Tree.
>
> Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
> ---
>  drivers/gpio/gpio-spacemit-k1.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-spacemit-k1.c b/drivers/gpio/gpio-spacemit-k1.c
> index dbd2e81094b9..5fe813b7f9bb 100644
> --- a/drivers/gpio/gpio-spacemit-k1.c
> +++ b/drivers/gpio/gpio-spacemit-k1.c
> @@ -228,6 +228,7 @@ static int spacemit_gpio_add_bank(struct spacemit_gpio *sg,
>         gc->label               = dev_name(dev);
>         gc->request             = gpiochip_generic_request;
>         gc->free                = gpiochip_generic_free;
> +       gc->set_config          = gpiochip_generic_config;
>         gc->ngpio               = SPACEMIT_NR_GPIOS_PER_BANK;
>         gc->base                = -1;
>         gc->of_gpio_n_cells     = 3;
>
> --
> 2.53.0
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Linus, please take it through the pinctrl tree.

Bart

Re: [PATCH 2/2] gpio: spacemit-k1: Add set_config callback support

Posted by Linus Walleij 2 weeks, 5 days ago

On Fri, Mar 13, 2026 at 3:05 PM Bartosz Golaszewski <brgl@kernel.org> wrote:
> On Thu, Mar 12, 2026 at 9:43 AM Junhui Liu <junhui.liu@pigmoral.tech> wrote:
> >
> > Assign gpiochip_generic_config() to the set_config() callback to support
> > pin configuration through the GPIO subsystem. This allows users to
> > configure GPIO pin attributes like pull-up/down when specifying a GPIO
> > line in the Device Tree.
> >
> > Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>

> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>
> Linus, please take it through the pinctrl tree.

OK done.

Yours,
Linus Walleij