ARM: dts: omap: dm816x: Correct pinctrl register

[PATCH] ARM: dts: omap: dm816x: Correct pinctrl register

Posted by Andrew Goodbody 3 weeks, 5 days ago

The delcaration in the pinmux device for the pinctrl registers is not
correct. These registers are actually 32 bits wide, not 16. Also the
mask for functional bits is also wrong. Functional bits are 0-4, not
0-3. So the mask needs to changed to 0x1f.

This information is taken from the TMS320DM816x DaVinci
Digital Media Processors Technical Reference Manual.
SPRUGX8C March 2015

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---
 arch/arm/boot/dts/ti/omap/dm816x.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
index 407d7bc5b13a364548087dd5fb2659286bbd8537..a1e0e904e0f05cd725e71da70bffbde2dd2b2e38 100644
--- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
@@ -94,8 +94,8 @@ dm816x_pinmux: pinmux@800 {
 				#address-cells = <1>;
 				#size-cells = <0>;
 				#pinctrl-cells = <1>;
-				pinctrl-single,register-width = <16>;
-				pinctrl-single,function-mask = <0xf>;
+				pinctrl-single,register-width = <32>;
+				pinctrl-single,function-mask = <0x1f>;
 			};
 
 			/* Device Configuration Registers */

---
base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
change-id: 20260312-dm816x_dt-abe888f372e3

Best regards,
-- 
Andrew Goodbody <andrew.goodbody@linaro.org>

Re: [PATCH] ARM: dts: omap: dm816x: Correct pinctrl register

Posted by Kevin Hilman 3 weeks, 4 days ago

On Thu, 12 Mar 2026 14:16:57 +0000, Andrew Goodbody wrote:
> The delcaration in the pinmux device for the pinctrl registers is not
> correct. These registers are actually 32 bits wide, not 16. Also the
> mask for functional bits is also wrong. Functional bits are 0-4, not
> 0-3. So the mask needs to changed to 0x1f.
> 
> This information is taken from the TMS320DM816x DaVinci
> Digital Media Processors Technical Reference Manual.
> SPRUGX8C March 2015
> 
> [...]

Applied, thanks!

[1/1] ARM: dts: omap: dm816x: Correct pinctrl register
      (no commit info)

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>

Re: [PATCH] ARM: dts: omap: dm816x: Correct pinctrl register

Posted by Kevin Hilman 3 weeks, 4 days ago

Andrew Goodbody <andrew.goodbody@linaro.org> writes:

> The delcaration in the pinmux device for the pinctrl registers is not

minor nit: s/delcaration/declaration/, but no need to respin.  I'll fix
up when applying.

> correct. These registers are actually 32 bits wide, not 16. Also the
> mask for functional bits is also wrong. Functional bits are 0-4, not
> 0-3. So the mask needs to changed to 0x1f.
>
> This information is taken from the TMS320DM816x DaVinci
> Digital Media Processors Technical Reference Manual.
> SPRUGX8C March 2015
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

good catch!  Thank you for the fix.

Kevin

> ---
>  arch/arm/boot/dts/ti/omap/dm816x.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> index 407d7bc5b13a364548087dd5fb2659286bbd8537..a1e0e904e0f05cd725e71da70bffbde2dd2b2e38 100644
> --- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> @@ -94,8 +94,8 @@ dm816x_pinmux: pinmux@800 {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  				#pinctrl-cells = <1>;
> -				pinctrl-single,register-width = <16>;
> -				pinctrl-single,function-mask = <0xf>;
> +				pinctrl-single,register-width = <32>;
> +				pinctrl-single,function-mask = <0x1f>;
>  			};
>  
>  			/* Device Configuration Registers */
>
> ---
> base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
> change-id: 20260312-dm816x_dt-abe888f372e3
>
> Best regards,
> -- 
> Andrew Goodbody <andrew.goodbody@linaro.org>

Re: [PATCH] ARM: dts: omap: dm816x: Correct pinctrl register

Posted by Christopher Obbard 3 weeks, 5 days ago

Hi Andrew,

On Thu, 12 Mar 2026 at 14:17, Andrew Goodbody
<andrew.goodbody@linaro.org> wrote:
>
> The delcaration in the pinmux device for the pinctrl registers is not
> correct. These registers are actually 32 bits wide, not 16. Also the
> mask for functional bits is also wrong. Functional bits are 0-4, not
> 0-3. So the mask needs to changed to 0x1f.
>
> This information is taken from the TMS320DM816x DaVinci
> Digital Media Processors Technical Reference Manual.
> SPRUGX8C March 2015
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
Tested-by: Christopher Obbard <christopher.obbard@linaro.org>


Cheers!

Chris