From: David Heidelberg <david@ixit.cz>

This regulator provides for the display subsystem, thus must be on.

Fixes: 77809cf74a8c ("arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 01b570d0880d6..1298485c42142 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -148,6 +148,7 @@ vreg_l1a_0p875: ldo1 {
 			regulator-min-microvolt = <880000>;
 			regulator-max-microvolt = <880000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-boot-on;
 		};
 
 		vreg_l5a_0p8: ldo5 {

---
base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
change-id: 20260312-beryllium-booton-adb218ec7e28

Best regards,
-- 
David Heidelberg <david@ixit.cz>

On 3/12/26 12:49 AM, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> This regulator provides for the display subsystem, thus must be on.
> 
> Fixes: 77809cf74a8c ("arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

  regulator-boot-on:
    description: bootloader/firmware enabled regulator.
      It's expected that this regulator was left on by the bootloader.
      If the bootloader didn't leave it on then OS should turn it on
      at boot but shouldn't prevent it from being turned off later.
      This property is intended to only be used for regulators where
      software cannot read the state of the regulator.

While I believe what you're doing is okay, the commit message could
be interpreted in two ways:

1. The regulator must be on, since it provides the display subsystem
   [and therefore the bootloader had turned it on before Linux booted]

2. The display subsystem requires that this regulator is on, so for that
   subsystem to function, we must ensure that it's enabled [by Linux]

I'm almost certain you meant 1., but please make that explicit

Konrad

On 13/03/2026 13:06, Konrad Dybcio wrote:
> On 3/12/26 12:49 AM, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> This regulator provides for the display subsystem, thus must be on.
>>
>> Fixes: 77809cf74a8c ("arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)")
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
> 
>    regulator-boot-on:
>      description: bootloader/firmware enabled regulator.
>        It's expected that this regulator was left on by the bootloader.
>        If the bootloader didn't leave it on then OS should turn it on
>        at boot but shouldn't prevent it from being turned off later.
>        This property is intended to only be used for regulators where
>        software cannot read the state of the regulator.
> 
> While I believe what you're doing is okay, the commit message could
> be interpreted in two ways:
> 
> 1. The regulator must be on, since it provides the display subsystem
>     [and therefore the bootloader had turned it on before Linux booted]
> 
> 2. The display subsystem requires that this regulator is on, so for that
>     subsystem to function, we must ensure that it's enabled [by Linux]
> 
> I'm almost certain you meant 1., but please make that explicit

Yes, I meant 1. (I'm aware of the documentation here).

David

> 
> Konrad

-- 
David Heidelberg