staging: greybus: gpio: add comment to mutex definition

[PATCH] staging: greybus: gpio: add comment to mutex definition

Posted by Rahul Joshi 3 weeks, 6 days ago

The irq_lock mutex is missing a comment describing what it protects,
which is required by kernel coding style. Add a comment clarifying
that it serializes IRQ bus lock/unlock operations used to defer and
sync pending IRQ type and mask changes to hardware.

Signed-off-by: Rahul Joshi <rj5547884@gmail.com>
---
 drivers/staging/greybus/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 12185f7a982c..89c15b804b2a 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -39,7 +39,7 @@ struct gb_gpio_controller {
 
 	struct gpio_chip	chip;
 	struct irq_chip		irqc;
-	struct mutex		irq_lock;
+	struct mutex		irq_lock;	/* protects irq bus operations */
 };
 
 static struct gpio_chip *irq_data_to_gpio_chip(struct irq_data *d)
-- 
2.34.1

Re: [PATCH] staging: greybus: gpio: add comment to mutex definition

Posted by Greg KH 2 weeks, 6 days ago

On Wed, Mar 11, 2026 at 11:23:34PM +0530, Rahul Joshi wrote:
> The irq_lock mutex is missing a comment describing what it protects,
> which is required by kernel coding style. Add a comment clarifying
> that it serializes IRQ bus lock/unlock operations used to defer and
> sync pending IRQ type and mask changes to hardware.
> 
> Signed-off-by: Rahul Joshi <rj5547884@gmail.com>
> ---
>  drivers/staging/greybus/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
> index 12185f7a982c..89c15b804b2a 100644
> --- a/drivers/staging/greybus/gpio.c
> +++ b/drivers/staging/greybus/gpio.c
> @@ -39,7 +39,7 @@ struct gb_gpio_controller {
>  
>  	struct gpio_chip	chip;
>  	struct irq_chip		irqc;
> -	struct mutex		irq_lock;
> +	struct mutex		irq_lock;	/* protects irq bus operations */

What is a "irq bus"?  This comment feels odd to me :(

thanks,

greg k-h