drivers/thermal/thermal_sysfs.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Replace hard-coded strings with the str_enabled_disabled() helper. This
unifies the output and helps the linker with deduplication, which can
result in a smaller binary.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/thermal/thermal_sysfs.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
index 46b3b2df935c..5eecae13f07d 100644
--- a/drivers/thermal/thermal_sysfs.c
+++ b/drivers/thermal/thermal_sysfs.c
@@ -18,6 +18,7 @@
#include <linux/err.h>
#include <linux/slab.h>
#include <linux/string.h>
+#include <linux/string_choices.h>
#include <linux/jiffies.h>
#include "thermal_core.h"
@@ -56,10 +57,8 @@ mode_show(struct device *dev, struct device_attribute *attr, char *buf)
guard(thermal_zone)(tz);
- if (tz->mode == THERMAL_DEVICE_ENABLED)
- return sysfs_emit(buf, "enabled\n");
-
- return sysfs_emit(buf, "disabled\n");
+ return sysfs_emit(buf, "%s\n",
+ str_enabled_disabled(tz->mode == THERMAL_DEVICE_ENABLED));
}
static ssize_t
On Wed, Mar 11, 2026 at 5:43 PM Thorsten Blum <thorsten.blum@linux.dev> wrote: > > Replace hard-coded strings with the str_enabled_disabled() helper. This > unifies the output and helps the linker with deduplication, which can > result in a smaller binary. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> > --- > drivers/thermal/thermal_sysfs.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c > index 46b3b2df935c..5eecae13f07d 100644 > --- a/drivers/thermal/thermal_sysfs.c > +++ b/drivers/thermal/thermal_sysfs.c > @@ -18,6 +18,7 @@ > #include <linux/err.h> > #include <linux/slab.h> > #include <linux/string.h> > +#include <linux/string_choices.h> > #include <linux/jiffies.h> > > #include "thermal_core.h" > @@ -56,10 +57,8 @@ mode_show(struct device *dev, struct device_attribute *attr, char *buf) > > guard(thermal_zone)(tz); > > - if (tz->mode == THERMAL_DEVICE_ENABLED) > - return sysfs_emit(buf, "enabled\n"); > - > - return sysfs_emit(buf, "disabled\n"); > + return sysfs_emit(buf, "%s\n", > + str_enabled_disabled(tz->mode == THERMAL_DEVICE_ENABLED)); > } > > static ssize_t Applied as 7.1 material, thanks!
© 2016 - 2026 Red Hat, Inc.