[PATCH 0/4] gpio: kempld: Support get/set multiple and interrupts

Alban Bedel posted 4 patches 3 weeks, 6 days ago
drivers/gpio/Kconfig       |   1 +
drivers/gpio/gpio-kempld.c | 289 +++++++++++++++++++++++++++++++++++--
include/linux/mfd/kempld.h |   1 +
3 files changed, 278 insertions(+), 13 deletions(-)
[PATCH 0/4] gpio: kempld: Support get/set multiple and interrupts
Posted by Alban Bedel 3 weeks, 6 days ago
This series update the kempld driver to support current versions of the PLD,
add the get/set multiple ops and implement the interrupt controller.

Alban Bedel (4):
  gpio: kempld: Simplify the bit level register accesses
  gpio: kempld: Add support for PLD version >= 2.8
  gpio: kempld: Add support for get/set multiple
  gpio: kempld: Implement the interrupt controller

 drivers/gpio/Kconfig       |   1 +
 drivers/gpio/gpio-kempld.c | 289 +++++++++++++++++++++++++++++++++++--
 include/linux/mfd/kempld.h |   1 +
 3 files changed, 278 insertions(+), 13 deletions(-)

-- 
2.39.5
Re: [PATCH 0/4] gpio: kempld: Support get/set multiple and interrupts
Posted by Linus Walleij 3 weeks, 1 day ago
On Wed, Mar 11, 2026 at 3:31 PM Alban Bedel <alban.bedel@lht.dlh.de> wrote:

> This series update the kempld driver to support current versions of the PLD,
> add the get/set multiple ops and implement the interrupt controller.

The series is fine, I think it is worth noticing the following however:

The kempld MFD device is just providing kempld_read8()
kempld_write8() etc. These in turn are not very magical.

If the MFD device was refactored to just use regmap for
read/write of these registers, the whole GPIO driver could
be cut down a lot by using GPIO_REGMAP.

I think this is a common problem with a bunch of
"necessarily different" MFD driver APIs that should be using
regmap but weren't caught during review.

Yours,
Linus Walleij
Re: [PATCH 0/4] gpio: kempld: Support get/set multiple and interrupts
Posted by Bartosz Golaszewski 3 weeks, 1 day ago
On Wed, 11 Mar 2026 15:31:16 +0100, Alban Bedel wrote:
> This series update the kempld driver to support current versions of the PLD,
> add the get/set multiple ops and implement the interrupt controller.
> 
> Alban Bedel (4):
>   gpio: kempld: Simplify the bit level register accesses
>   gpio: kempld: Add support for PLD version >= 2.8
>   gpio: kempld: Add support for get/set multiple
>   gpio: kempld: Implement the interrupt controller
> 
> [...]

Applied, thanks!

[1/4] gpio: kempld: Simplify the bit level register accesses
      https://git.kernel.org/brgl/c/4071437cd2aac6b9d48f160d46cfb35ecbb11136
[2/4] gpio: kempld: Add support for PLD version >= 2.8
      https://git.kernel.org/brgl/c/84cb463d2f6597c7951da6fb795f12119af8130d
[3/4] gpio: kempld: Add support for get/set multiple
      https://git.kernel.org/brgl/c/2443c2e1223bda4dcef5563d0154df6a72969922
[4/4] gpio: kempld: Implement the interrupt controller
      https://git.kernel.org/brgl/c/a25f48fd920b557e6ad02f692f690520c82f5914

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>