ACPI: OSL: fix __iomem type on return acpi_os_map_generic_address()

[PATCH] ACPI: OSL: fix __iomem type on return acpi_os_map_generic_address()

Posted by Ben Dooks 3 weeks, 6 days ago

The pointer returned from acpi_os_map_generic_address() is
tagged with __iomem, so make the rv it is returned to also
of void __iomem * type.

Fixes the following sparse warning:

drivers/acpi/osl.c:1686:20: warning: incorrect type in assignment (different address spaces)
drivers/acpi/osl.c:1686:20:    expected void *rv
drivers/acpi/osl.c:1686:20:    got void [noderef] __iomem *

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/acpi/osl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 5b777316b9ac..62b9c83d4f20 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1681,7 +1681,7 @@ acpi_status __init acpi_os_initialize(void)
 		 * Use acpi_os_map_generic_address to pre-map the reset
 		 * register if it's in system memory.
 		 */
-		void *rv;
+		void __iomem *rv;
 
 		rv = acpi_os_map_generic_address(&acpi_gbl_FADT.reset_register);
 		pr_debug("%s: Reset register mapping %s\n", __func__,
-- 
2.37.2.352.g3c44437643

Re: [PATCH] ACPI: OSL: fix __iomem type on return acpi_os_map_generic_address()

Posted by Rafael J. Wysocki 3 weeks, 6 days ago

On Wed, Mar 11, 2026 at 11:58 AM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> The pointer returned from acpi_os_map_generic_address() is
> tagged with __iomem, so make the rv it is returned to also
> of void __iomem * type.
>
> Fixes the following sparse warning:
>
> drivers/acpi/osl.c:1686:20: warning: incorrect type in assignment (different address spaces)
> drivers/acpi/osl.c:1686:20:    expected void *rv
> drivers/acpi/osl.c:1686:20:    got void [noderef] __iomem *
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  drivers/acpi/osl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 5b777316b9ac..62b9c83d4f20 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1681,7 +1681,7 @@ acpi_status __init acpi_os_initialize(void)
>                  * Use acpi_os_map_generic_address to pre-map the reset
>                  * register if it's in system memory.
>                  */
> -               void *rv;
> +               void __iomem *rv;
>
>                 rv = acpi_os_map_generic_address(&acpi_gbl_FADT.reset_register);
>                 pr_debug("%s: Reset register mapping %s\n", __func__,
> --

Applied as 7.0-rc material, thanks!