[PATCH v4 0/6] iio: fix spelling mistakes in comments

Shi Hao posted 6 patches 3 weeks, 6 days ago
There is a newer version of this series
drivers/iio/accel/adis16201.c                          | 2 +-
drivers/iio/accel/adis16209.c                          | 2 +-
drivers/iio/adc/ad4030.c                               | 2 +-
drivers/iio/adc/ad4170-4.c                             | 6 +++---
drivers/iio/adc/ad7380.c                               | 2 +-
drivers/iio/adc/ad7887.c                               | 2 +-
drivers/iio/adc/ad7923.c                               | 4 ++--
drivers/iio/adc/at91_adc.c                             | 4 ++--
drivers/iio/adc/max1363.c                              | 2 +-
drivers/iio/adc/mcp3564.c                              | 2 +-
drivers/iio/adc/men_z188_adc.c                         | 2 +-
drivers/iio/adc/npcm_adc.c                             | 2 +-
drivers/iio/adc/palmas_gpadc.c                         | 2 +-
drivers/iio/adc/rohm-bd79124.c                         | 4 ++--
drivers/iio/adc/spear_adc.c                            | 2 +-
drivers/iio/adc/stm32-adc-core.c                       | 2 +-
drivers/iio/adc/stm32-adc.c                            | 2 +-
drivers/iio/adc/sun20i-gpadc-iio.c                     | 2 +-
drivers/iio/adc/ti_am335x_adc.c                        | 2 +-
drivers/iio/adc/twl4030-madc.c                         | 2 +-
drivers/iio/adc/twl6030-gpadc.c                        | 4 ++--
drivers/iio/amplifiers/ada4250.c                       | 2 +-
drivers/iio/cdc/ad7150.c                               | 2 +-
drivers/iio/cdc/ad7746.c                               | 2 +-
drivers/iio/chemical/bme680_core.c                     | 2 +-
drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c   | 2 +-
drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 2 +-
drivers/iio/common/inv_sensors/inv_sensors_timestamp.c | 2 +-
drivers/iio/common/ms_sensors/ms_sensors_i2c.c         | 2 +-
29 files changed, 35 insertions(+), 35 deletions(-)
[PATCH v4 0/6] iio: fix spelling mistakes in comments
Posted by Shi Hao 3 weeks, 6 days ago
This series fixes spelling mistakes in comments across several IIO
subsystems to improve readability and code consistency.

v4:

- Fix commit message grammar and punctuation across patches
- Keep 'whilst' instead of 'while'
- Rephrase sentence in chemical driver comment
- Capitalize IIO in comments

v3:

- Change commit subjects as per changes
- Capitalize proper acronyms (IRQ) and Celsius
- Fix short wrap in commit body

v2:

- Split original patch into 6 commits
- Fixed commit message formatting and typos
- Added necessary tags in commits
- Added more fixes then previous

Shi Hao (6):
  iio: accel: fix typo celcius to Celsius
  iio: adc: fix spelling mistakes in comments
  iio: amplifiers: fix typo Curren to Current
  iio: cdc: fix spelling mistakes in comments
  iio: chemical: rephrase sentence and fix typo in comment
  iio: common: fix spelling mistakes in comments

 drivers/iio/accel/adis16201.c                          | 2 +-
 drivers/iio/accel/adis16209.c                          | 2 +-
 drivers/iio/adc/ad4030.c                               | 2 +-
 drivers/iio/adc/ad4170-4.c                             | 6 +++---
 drivers/iio/adc/ad7380.c                               | 2 +-
 drivers/iio/adc/ad7887.c                               | 2 +-
 drivers/iio/adc/ad7923.c                               | 4 ++--
 drivers/iio/adc/at91_adc.c                             | 4 ++--
 drivers/iio/adc/max1363.c                              | 2 +-
 drivers/iio/adc/mcp3564.c                              | 2 +-
 drivers/iio/adc/men_z188_adc.c                         | 2 +-
 drivers/iio/adc/npcm_adc.c                             | 2 +-
 drivers/iio/adc/palmas_gpadc.c                         | 2 +-
 drivers/iio/adc/rohm-bd79124.c                         | 4 ++--
 drivers/iio/adc/spear_adc.c                            | 2 +-
 drivers/iio/adc/stm32-adc-core.c                       | 2 +-
 drivers/iio/adc/stm32-adc.c                            | 2 +-
 drivers/iio/adc/sun20i-gpadc-iio.c                     | 2 +-
 drivers/iio/adc/ti_am335x_adc.c                        | 2 +-
 drivers/iio/adc/twl4030-madc.c                         | 2 +-
 drivers/iio/adc/twl6030-gpadc.c                        | 4 ++--
 drivers/iio/amplifiers/ada4250.c                       | 2 +-
 drivers/iio/cdc/ad7150.c                               | 2 +-
 drivers/iio/cdc/ad7746.c                               | 2 +-
 drivers/iio/chemical/bme680_core.c                     | 2 +-
 drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c   | 2 +-
 drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 2 +-
 drivers/iio/common/inv_sensors/inv_sensors_timestamp.c | 2 +-
 drivers/iio/common/ms_sensors/ms_sensors_i2c.c         | 2 +-
 29 files changed, 35 insertions(+), 35 deletions(-)

--
2.53.0
Re: [PATCH v4 0/6] iio: fix spelling mistakes in comments
Posted by Dhruva Gole 3 weeks, 6 days ago
On Mar 11, 2026 at 15:09:27 +0530, Shi Hao wrote:
> This series fixes spelling mistakes in comments across several IIO
> subsystems to improve readability and code consistency.

I just tried applying this series locally, on top of linux-next tag: next-20260310

Could you please make sure to use git format-patch with the option --base HEAD~N
where N is the number of your patches?
This will help identify what you used as the base commit for all your
changes. Make sure it's usually on top of the latest linux-next.

I also ran checkpatch on them, and saw a bunch of errors and warnings,
not sure if you've run it on your end and ensured it's clean?

> 
> v4:
> 
> - Fix commit message grammar and punctuation across patches
> - Keep 'whilst' instead of 'while'
> - Rephrase sentence in chemical driver comment
> - Capitalize IIO in comments

Also, in the changelog, please add links to your previous revisions.
This make reviewing things and getting context much easier.

> 
> v3:
> 
> - Change commit subjects as per changes
> - Capitalize proper acronyms (IRQ) and Celsius
> - Fix short wrap in commit body
> 
> v2:
> 
> - Split original patch into 6 commits
> - Fixed commit message formatting and typos
> - Added necessary tags in commits
> - Added more fixes then previous
> 
> Shi Hao (6):
>   iio: accel: fix typo celcius to Celsius
>   iio: adc: fix spelling mistakes in comments
>   iio: amplifiers: fix typo Curren to Current
>   iio: cdc: fix spelling mistakes in comments
>   iio: chemical: rephrase sentence and fix typo in comment
>   iio: common: fix spelling mistakes in comments
> 
>  drivers/iio/accel/adis16201.c                          | 2 +-
>  drivers/iio/accel/adis16209.c                          | 2 +-
>  drivers/iio/adc/ad4030.c                               | 2 +-
>  drivers/iio/adc/ad4170-4.c                             | 6 +++---
>  drivers/iio/adc/ad7380.c                               | 2 +-
>  drivers/iio/adc/ad7887.c                               | 2 +-
>  drivers/iio/adc/ad7923.c                               | 4 ++--
>  drivers/iio/adc/at91_adc.c                             | 4 ++--
>  drivers/iio/adc/max1363.c                              | 2 +-
>  drivers/iio/adc/mcp3564.c                              | 2 +-
>  drivers/iio/adc/men_z188_adc.c                         | 2 +-
>  drivers/iio/adc/npcm_adc.c                             | 2 +-
>  drivers/iio/adc/palmas_gpadc.c                         | 2 +-
>  drivers/iio/adc/rohm-bd79124.c                         | 4 ++--
>  drivers/iio/adc/spear_adc.c                            | 2 +-
>  drivers/iio/adc/stm32-adc-core.c                       | 2 +-
>  drivers/iio/adc/stm32-adc.c                            | 2 +-
>  drivers/iio/adc/sun20i-gpadc-iio.c                     | 2 +-
>  drivers/iio/adc/ti_am335x_adc.c                        | 2 +-
>  drivers/iio/adc/twl4030-madc.c                         | 2 +-
>  drivers/iio/adc/twl6030-gpadc.c                        | 4 ++--
>  drivers/iio/amplifiers/ada4250.c                       | 2 +-
>  drivers/iio/cdc/ad7150.c                               | 2 +-
>  drivers/iio/cdc/ad7746.c                               | 2 +-
>  drivers/iio/chemical/bme680_core.c                     | 2 +-
>  drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c   | 2 +-
>  drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 2 +-
>  drivers/iio/common/inv_sensors/inv_sensors_timestamp.c | 2 +-
>  drivers/iio/common/ms_sensors/ms_sensors_i2c.c         | 2 +-
>  29 files changed, 35 insertions(+), 35 deletions(-)
> 
> --
> 2.53.0

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated
Re: [PATCH v4 0/6] iio: fix spelling mistakes in comments
Posted by Jonathan Cameron 3 weeks, 2 days ago
On Wed, 11 Mar 2026 15:40:07 +0530
Dhruva Gole <d-gole@ti.com> wrote:

> On Mar 11, 2026 at 15:09:27 +0530, Shi Hao wrote:
> > This series fixes spelling mistakes in comments across several IIO
> > subsystems to improve readability and code consistency.  
> 
> I just tried applying this series locally, on top of linux-next tag: next-20260310

Agreed. The series seems to have some corruption issues.

Linux-next is very unlikely target for pretty much anything!
Maybe it'll have the right patches at a given moment, maybe not.

> 
> Could you please make sure to use git format-patch with the option --base HEAD~N
> where N is the number of your patches?
> This will help identify what you used as the base commit for all your
> changes. Make sure it's usually on top of the latest linux-next.
> 
> I also ran checkpatch on them, and saw a bunch of errors and warnings,
> not sure if you've run it on your end and ensured it's clean?

I would very much take those warnings lightly. By all means check
them but I ran it on the first patch and it generated completely
incorrect changes because it was interpreting comment blocks
as code.

> 
> > 
> > v4:
> > 
> > - Fix commit message grammar and punctuation across patches
> > - Keep 'whilst' instead of 'while'
> > - Rephrase sentence in chemical driver comment
> > - Capitalize IIO in comments  
> 
> Also, in the changelog, please add links to your previous revisions.
> This make reviewing things and getting context much easier.
> 
> > 
> > v3:
> > 
> > - Change commit subjects as per changes
> > - Capitalize proper acronyms (IRQ) and Celsius
> > - Fix short wrap in commit body
> > 
> > v2:
> > 
> > - Split original patch into 6 commits
> > - Fixed commit message formatting and typos
> > - Added necessary tags in commits
> > - Added more fixes then previous
> > 
> > Shi Hao (6):
> >   iio: accel: fix typo celcius to Celsius
> >   iio: adc: fix spelling mistakes in comments
> >   iio: amplifiers: fix typo Curren to Current
> >   iio: cdc: fix spelling mistakes in comments
> >   iio: chemical: rephrase sentence and fix typo in comment
> >   iio: common: fix spelling mistakes in comments
> > 
> >  drivers/iio/accel/adis16201.c                          | 2 +-
> >  drivers/iio/accel/adis16209.c                          | 2 +-
> >  drivers/iio/adc/ad4030.c                               | 2 +-
> >  drivers/iio/adc/ad4170-4.c                             | 6 +++---
> >  drivers/iio/adc/ad7380.c                               | 2 +-
> >  drivers/iio/adc/ad7887.c                               | 2 +-
> >  drivers/iio/adc/ad7923.c                               | 4 ++--
> >  drivers/iio/adc/at91_adc.c                             | 4 ++--
> >  drivers/iio/adc/max1363.c                              | 2 +-
> >  drivers/iio/adc/mcp3564.c                              | 2 +-
> >  drivers/iio/adc/men_z188_adc.c                         | 2 +-
> >  drivers/iio/adc/npcm_adc.c                             | 2 +-
> >  drivers/iio/adc/palmas_gpadc.c                         | 2 +-
> >  drivers/iio/adc/rohm-bd79124.c                         | 4 ++--
> >  drivers/iio/adc/spear_adc.c                            | 2 +-
> >  drivers/iio/adc/stm32-adc-core.c                       | 2 +-
> >  drivers/iio/adc/stm32-adc.c                            | 2 +-
> >  drivers/iio/adc/sun20i-gpadc-iio.c                     | 2 +-
> >  drivers/iio/adc/ti_am335x_adc.c                        | 2 +-
> >  drivers/iio/adc/twl4030-madc.c                         | 2 +-
> >  drivers/iio/adc/twl6030-gpadc.c                        | 4 ++--
> >  drivers/iio/amplifiers/ada4250.c                       | 2 +-
> >  drivers/iio/cdc/ad7150.c                               | 2 +-
> >  drivers/iio/cdc/ad7746.c                               | 2 +-
> >  drivers/iio/chemical/bme680_core.c                     | 2 +-
> >  drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c   | 2 +-
> >  drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 2 +-
> >  drivers/iio/common/inv_sensors/inv_sensors_timestamp.c | 2 +-
> >  drivers/iio/common/ms_sensors/ms_sensors_i2c.c         | 2 +-
> >  29 files changed, 35 insertions(+), 35 deletions(-)
> > 
> > --
> > 2.53.0  
>
Re: [PATCH v4 0/6] iio: fix spelling mistakes in comments
Posted by ShiHao 3 weeks, 2 days ago
On Wed, Mar 11, 2026 at 03:40:07PM +0530, Dhruva Gole wrote:
> 
> I just tried applying this series locally, on top of linux-next tag: next-20260310
> 
> Could you please make sure to use git format-patch with the option --base HEAD~N
> where N is the number of your patches?
> This will help identify what you used as the base commit for all your
> changes. Make sure it's usually on top of the latest linux-next.
> 
> I also ran checkpatch on them, and saw a bunch of errors and warnings,
> not sure if you've run it on your end and ensured it's clean?
>
> Also, in the changelog, please add links to your previous revisions.
> This make reviewing things and getting context much easier.
> Best regards,
> Dhruva Gole
> Texas Instruments Incorporated


Hi everyone,

I have a quick question regarding my patch series. I noticed that a 
similar patch was already submitted and has been accepted, so I removed
those changes from my series. However, I have added a few additional
fixes and the series has now grown to about 13 patches. The original
series had only 6 patches, so I am unsure whether I should send this
as v5 or resend it as a new series. I would appreciate any guidance.
I want to avoid creating unnecessary noise on the mailing list.

Best regards,
Shi Hao
Re: [PATCH v4 0/6] iio: fix spelling mistakes in comments
Posted by Jonathan Cameron 3 weeks, 2 days ago
On Sun, 15 Mar 2026 18:14:20 +0530
ShiHao <i.shihao.999@gmail.com> wrote:

> On Wed, Mar 11, 2026 at 03:40:07PM +0530, Dhruva Gole wrote:
> > 
> > I just tried applying this series locally, on top of linux-next tag: next-20260310
> > 
> > Could you please make sure to use git format-patch with the option --base HEAD~N
> > where N is the number of your patches?
> > This will help identify what you used as the base commit for all your
> > changes. Make sure it's usually on top of the latest linux-next.
> > 
> > I also ran checkpatch on them, and saw a bunch of errors and warnings,
> > not sure if you've run it on your end and ensured it's clean?
> >
> > Also, in the changelog, please add links to your previous revisions.
> > This make reviewing things and getting context much easier.
> > Best regards,
> > Dhruva Gole
> > Texas Instruments Incorporated  
> 
> 
> Hi everyone,
> 
> I have a quick question regarding my patch series. I noticed that a 
> similar patch was already submitted and has been accepted, so I removed
> those changes from my series. However, I have added a few additional
> fixes and the series has now grown to about 13 patches. The original
> series had only 6 patches, so I am unsure whether I should send this
> as v5 or resend it as a new series. I would appreciate any guidance.
> I want to avoid creating unnecessary noise on the mailing list.
> 
> Best regards,
> Shi Hao
Hi.

Send it as a v5 and state the above in the cover letter.

Thanks,

Jonathan

> 
>