[PATCH net-next v8 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains

Bartosz Golaszewski posted 6 patches 3 weeks, 6 days ago
There is a newer version of this series
.../bindings/net/allwinner,sun7i-a20-gmac.yaml     |   3 +
.../bindings/net/altr,socfpga-stmmac.yaml          |   3 +
.../bindings/net/amlogic,meson-dwmac.yaml          |   3 +
.../devicetree/bindings/net/eswin,eic7700-eth.yaml |   3 +
.../devicetree/bindings/net/intel,dwmac-plat.yaml  |   3 +
.../bindings/net/loongson,ls1b-gmac.yaml           |   3 +
.../bindings/net/loongson,ls1c-emac.yaml           |   3 +
.../devicetree/bindings/net/nxp,dwmac-imx.yaml     |   3 +
.../devicetree/bindings/net/nxp,lpc1850-dwmac.yaml |   3 +
.../devicetree/bindings/net/nxp,s32-dwmac.yaml     |   3 +
.../devicetree/bindings/net/qcom,ethqos.yaml       |   3 +
.../bindings/net/qcom,sa8255p-ethqos.yaml          |  98 +++++
.../devicetree/bindings/net/renesas,rzn1-gmac.yaml |   3 +
.../bindings/net/renesas,rzv2h-gbeth.yaml          |   3 +
.../devicetree/bindings/net/rockchip-dwmac.yaml    |   3 +
.../devicetree/bindings/net/snps,dwmac.yaml        |   5 +-
.../bindings/net/sophgo,cv1800b-dwmac.yaml         |   3 +
.../bindings/net/sophgo,sg2044-dwmac.yaml          |   3 +
.../bindings/net/starfive,jh7110-dwmac.yaml        |   3 +
.../devicetree/bindings/net/stm32-dwmac.yaml       |   3 +
.../devicetree/bindings/net/tesla,fsd-ethqos.yaml  |   3 +
.../devicetree/bindings/net/thead,th1520-gmac.yaml |   3 +
.../bindings/net/toshiba,visconti-dwmac.yaml       |   3 +
MAINTAINERS                                        |   1 +
drivers/net/ethernet/stmicro/stmmac/Kconfig        |   2 +-
.../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c    | 401 +++++++++++++++++----
26 files changed, 498 insertions(+), 72 deletions(-)
[PATCH net-next v8 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains
Posted by Bartosz Golaszewski 3 weeks, 6 days ago
Add support for the firmware-managed variant of the DesignWare MAC on
the sa8255p platform. This series contains new DT bindings and driver
changes required to support the MAC in the STMMAC driver.

It also reorganizes the ethqos code quite a bit to make the introduction
of power domains into the driver a bit easier on the eye.

The DTS changes will go in separately.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Changes in v8:
- Rebase on top of recent changes in linux-next which required an
  extensive rework
- Drop partial R-b tags
- Link to v7: https://patch.msgid.link/20260306-qcom-sa8255p-emac-v7-0-d6a3013094b7@oss.qualcomm.com

Changes in v7:
- Restored the correct authorship after learning git uses .mailmap for
  the --author switch
- Rebased on top of changes from Russell
- Fixed resource management issues in error paths
- Link to v6: https://lore.kernel.org/r/20260112-qcom-sa8255p-emac-v6-0-86a3d4b2ad83@oss.qualcomm.com

Changes in v6:
- Fix $id value in the bindings
- Drop patch 3/8 from the series
- Update init/exit callback signatures
- Link to v5: https://lore.kernel.org/r/20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org
- Link to v6: https://lore.kernel.org/r/20251219-qcom-sa8255p-emac-v6-0-487f1082461e@oss.qualcomm.com

Changes in v5:
- Name the DT binding document after the new compatbile
- Add missing space
- Make the power-domains limits stricter
- Link to v4: https://lore.kernel.org/r/20251104-qcom-sa8255p-emac-v4-0-f76660087cea@linaro.org

Changes in v4:
- Remove the phys property from the SCMI bindings
- Mark the power-domain-names property as required
- Set maxItems for power-domains to 1 for all existing bindings to
  maintain the current requirements after modifying the value in the
  top-level document
- Link to v3: https://lore.kernel.org/r/20251027-qcom-sa8255p-emac-v3-0-75767b9230ab@linaro.org

Changes in v3:
- Drop 'power' and 'perf' prefixes from power domain names
- Rebase on top of Russell's changes to dwmac
- Rebase on top of even more changes from Russell that are not yet
  in next (E1vB6ld-0000000BIPy-2Qi4@rmk-PC.armlinux.org.uk)
- Link to v2: https://lore.kernel.org/all/20251008-qcom-sa8255p-emac-v2-0-92bc29309fce@linaro.org/

Changes in v2:
- Fix the power-domains property in DT bindings
- Rework the DT bindings example
- Drop the DTS patch, it will go upstream separately
- Link to v1: https://lore.kernel.org/r/20250910-qcom-sa8255p-emac-v1-0-32a79cf1e668@linaro.org

---
Bartosz Golaszewski (6):
      dt-bindings: net: qcom: document the ethqos device for SCMI-based systems
      net: stmmac: qcom-ethqos: use generic device properties
      net: stmmac: qcom-ethqos: wrap emac driver data in additional structure
      net: stmmac: qcom-ethqos: split power management fields into a separate structure
      net: stmmac: qcom-ethqos: split power management context into a separate struct
      net: stmmac: qcom-ethqos: add support for sa8255p

 .../bindings/net/allwinner,sun7i-a20-gmac.yaml     |   3 +
 .../bindings/net/altr,socfpga-stmmac.yaml          |   3 +
 .../bindings/net/amlogic,meson-dwmac.yaml          |   3 +
 .../devicetree/bindings/net/eswin,eic7700-eth.yaml |   3 +
 .../devicetree/bindings/net/intel,dwmac-plat.yaml  |   3 +
 .../bindings/net/loongson,ls1b-gmac.yaml           |   3 +
 .../bindings/net/loongson,ls1c-emac.yaml           |   3 +
 .../devicetree/bindings/net/nxp,dwmac-imx.yaml     |   3 +
 .../devicetree/bindings/net/nxp,lpc1850-dwmac.yaml |   3 +
 .../devicetree/bindings/net/nxp,s32-dwmac.yaml     |   3 +
 .../devicetree/bindings/net/qcom,ethqos.yaml       |   3 +
 .../bindings/net/qcom,sa8255p-ethqos.yaml          |  98 +++++
 .../devicetree/bindings/net/renesas,rzn1-gmac.yaml |   3 +
 .../bindings/net/renesas,rzv2h-gbeth.yaml          |   3 +
 .../devicetree/bindings/net/rockchip-dwmac.yaml    |   3 +
 .../devicetree/bindings/net/snps,dwmac.yaml        |   5 +-
 .../bindings/net/sophgo,cv1800b-dwmac.yaml         |   3 +
 .../bindings/net/sophgo,sg2044-dwmac.yaml          |   3 +
 .../bindings/net/starfive,jh7110-dwmac.yaml        |   3 +
 .../devicetree/bindings/net/stm32-dwmac.yaml       |   3 +
 .../devicetree/bindings/net/tesla,fsd-ethqos.yaml  |   3 +
 .../devicetree/bindings/net/thead,th1520-gmac.yaml |   3 +
 .../bindings/net/toshiba,visconti-dwmac.yaml       |   3 +
 MAINTAINERS                                        |   1 +
 drivers/net/ethernet/stmicro/stmmac/Kconfig        |   2 +-
 .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c    | 401 +++++++++++++++++----
 26 files changed, 498 insertions(+), 72 deletions(-)
---
base-commit: faa893280833784cf45adcb71d2d38d780b5d909
change-id: 20250704-qcom-sa8255p-emac-8460235ac512

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Re: [PATCH net-next v8 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains
Posted by Jakub Kicinski 3 weeks, 4 days ago
On Wed, 11 Mar 2026 18:03:35 +0100 Bartosz Golaszewski wrote:
> Add support for the firmware-managed variant of the DesignWare MAC on
> the sa8255p platform. This series contains new DT bindings and driver
> changes required to support the MAC in the STMMAC driver.
> 
> It also reorganizes the ethqos code quite a bit to make the introduction
> of power domains into the driver a bit easier on the eye.

Not entirely sure what the conclusion was in the sub-thread with Russell
but FWIW this doesn't apply to net-next as posted so respin will be
needed either way.
Re: [PATCH net-next v8 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains
Posted by Bartosz Golaszewski 3 weeks, 4 days ago
On Fri, Mar 13, 2026 at 2:16 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 11 Mar 2026 18:03:35 +0100 Bartosz Golaszewski wrote:
> > Add support for the firmware-managed variant of the DesignWare MAC on
> > the sa8255p platform. This series contains new DT bindings and driver
> > changes required to support the MAC in the STMMAC driver.
> >
> > It also reorganizes the ethqos code quite a bit to make the introduction
> > of power domains into the driver a bit easier on the eye.
>
> Not entirely sure what the conclusion was in the sub-thread with Russell
> but FWIW this doesn't apply to net-next as posted so respin will be
> needed either way.

net-next is quite the moving target, isn't it? I did just that between
v7 and v8. :)

As for Russell's response: I think this is the third time we're doing
this for this driver. :( This series is not touching the existing
functionality and rebasing of Russell's changes on top of this should
for most part be trivial. The core of the changeset is to add support
for power domains to enable ethernet on SCMI driven SoCs. I would
really appreciate it if we could get it upstream and then any
subsequent rework can take into account the two types of systems we
support.

Russell: I see your point and didn't mind the first two times but it's
been way too long since I posted v1.

Bartosz
Re: [PATCH net-next v8 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains
Posted by Maxime Ripard 3 weeks, 4 days ago
Hi Jakub,

On Thu, Mar 12, 2026 at 06:16:54PM -0700, Jakub Kicinski wrote:
> On Wed, 11 Mar 2026 18:03:35 +0100 Bartosz Golaszewski wrote:
> > Add support for the firmware-managed variant of the DesignWare MAC on
> > the sa8255p platform. This series contains new DT bindings and driver
> > changes required to support the MAC in the STMMAC driver.
> > 
> > It also reorganizes the ethqos code quite a bit to make the introduction
> > of power domains into the driver a bit easier on the eye.
> 
> Not entirely sure what the conclusion was in the sub-thread with Russell
> but FWIW this doesn't apply to net-next as posted so respin will be
> needed either way.

We'd really like for this series to go in, so fwiw I'd prefer that we
don't create a dependency on a series that has never been posted for
this to be merged.

Maxime