[PATCH] ynl: ethtool: remove duplicated unspec entry

Hangbin Liu posted 1 patch 3 weeks, 6 days ago
Documentation/netlink/specs/ethtool.yaml | 4 ----
1 file changed, 4 deletions(-)
[PATCH] ynl: ethtool: remove duplicated unspec entry
Posted by Hangbin Liu 3 weeks, 6 days ago
There is a duplicated unspec entry. Remove it.

Fixes: 0187e602c03c ("ynl: add missing pieces to ethtool spec to better match uapi header")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 Documentation/netlink/specs/ethtool.yaml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 0a2d2343f79a..f47e9e68889a 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -306,10 +306,6 @@ attribute-sets:
     name: strings
     attr-cnt-name: __ethtool-a-strings-cnt
     attributes:
-      -
-        name: unspec
-        type: unused
-        value: 0
       -
         name: unspec
         type: unused

---
base-commit: 73aefba4e2eb713cf7bc4ad83cfc9b5d4f966f6d
change-id: 20260311-b4-drop_dup_unspec-2d316fa82d51

Best regards,
-- 
Hangbin Liu <liuhangbin@gmail.com>
Re: [PATCH] ynl: ethtool: remove duplicated unspec entry
Posted by Jakub Kicinski 3 weeks, 5 days ago
On Wed, 11 Mar 2026 11:22:29 +0800 Hangbin Liu wrote:
> There is a duplicated unspec entry. Remove it.
> 
> Fixes: 0187e602c03c ("ynl: add missing pieces to ethtool spec to better match uapi header")

Does it break some user space that assumes no duplicates?
Otherwise I think we can merge it via net-next. (no need to repost)
Re: [PATCH] ynl: ethtool: remove duplicated unspec entry
Posted by Hangbin Liu 3 weeks, 5 days ago
On Wed, Mar 11, 2026 at 05:25:59PM -0700, Jakub Kicinski wrote:
> On Wed, 11 Mar 2026 11:22:29 +0800 Hangbin Liu wrote:
> > There is a duplicated unspec entry. Remove it.
> > 
> > Fixes: 0187e602c03c ("ynl: add missing pieces to ethtool spec to better match uapi header")
> 
> Does it break some user space that assumes no duplicates?

No

> Otherwise I think we can merge it via net-next. (no need to repost)

Sure, OK for me.

Thanks
Hangbin