[PATCH v2] staging: media: atomisp: fix block comment style in refcount.c

Oskar Ray-Frayssinet posted 1 patch 4 weeks ago
.../atomisp/pci/base/refcount/src/refcount.c  | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
[PATCH v2] staging: media: atomisp: fix block comment style in refcount.c
Posted by Oskar Ray-Frayssinet 4 weeks ago
Fix block comment formatting to comply with kernel coding style:
- Move text from opening '/*' line to a separate continuation line
- Add leading '*' on continuation lines
- Move trailing '*/' to a separate line
- Replace commented-out code with #if 0 ... #endif blocks

Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
 .../atomisp/pci/base/refcount/src/refcount.c  | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c b/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
index 00e8a73f413e..68c3bc181a96 100644
--- a/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
+++ b/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
@@ -15,7 +15,8 @@
 
 #include "ia_css_debug.h"
 
-/* TODO: enable for other memory aswell
+/*
+ * TODO: enable for other memory aswell
  * now only for ia_css_ptr
  */
 struct ia_css_refcount_entry {
@@ -99,10 +100,11 @@ void ia_css_refcount_uninit(void)
 		 */
 		entry = myrefcount.items + i;
 		if (entry->data != mmgr_NULL) {
-			/*	ia_css_debug_dtrace(IA_CSS_DBG_TRACE,
-			 *	"ia_css_refcount_uninit: freeing (%x)\n",
-			 *	entry->data);
-			 */
+#if 0
+			ia_css_debug_dtrace(IA_CSS_DBG_TRACE,
+				"ia_css_refcount_uninit: freeing (%x)\n",
+				entry->data);
+#endif
 			hmm_free(entry->data);
 			entry->data = mmgr_NULL;
 			entry->count = 0;
@@ -174,9 +176,10 @@ bool ia_css_refcount_decrement(s32 id, ia_css_ptr ptr)
 		if (entry->count > 0) {
 			entry->count -= 1;
 			if (entry->count == 0) {
-				/* ia_css_debug_dtrace(IA_CSS_DBEUG_TRACE,
-				 * "ia_css_refcount_decrement: freeing\n");
-				 */
+#if 0
+				ia_css_debug_dtrace(IA_CSS_DBEUG_TRACE,
+						    "ia_css_refcount_decrement: freeing\n");
+#endif
 				hmm_free(ptr);
 				entry->data = mmgr_NULL;
 				entry->id = 0;
-- 
2.43.0
Re: [PATCH v2] staging: media: atomisp: fix block comment style in refcount.c
Posted by Andy Shevchenko 4 weeks ago
On Tue, Mar 10, 2026 at 09:35:46PM +0100, Oskar Ray-Frayssinet wrote:
> Fix block comment formatting to comply with kernel coding style:
> - Move text from opening '/*' line to a separate continuation line
> - Add leading '*' on continuation lines
> - Move trailing '*/' to a separate line

> - Replace commented-out code with #if 0 ... #endif blocks

This should be done in a separate patch as this is not about comments.

> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---

Where is the changelog?

-- 
With Best Regards,
Andy Shevchenko