efi: fix type in efi_mem_type()

[PATCH] efi: fix type in efi_mem_type()

Posted by Marek Marczykowski-Górecki 4 weeks ago

Drop const, as use of efi_mem_desc_lookup() will modify the variable.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603101851.bAhG7uGN-lkp@intel.com/
Fixes: 5992265762e6 "efi: make efi_mem_type() and efi_mem_attributes() work on Xen PV"
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
 drivers/firmware/efi/efi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 36efc92bdf02..288834a193d1 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -1001,7 +1001,7 @@ u64 efi_mem_attributes(unsigned long phys_addr)
  */
 int efi_mem_type(unsigned long phys_addr)
 {
-	const efi_memory_desc_t md;
+	efi_memory_desc_t md;
 
 	if (!efi_enabled(EFI_MEMMAP) && !efi_enabled(EFI_PARAVIRT))
 		return -ENOTSUPP;
-- 
2.52.0

Re: [PATCH] efi: fix type in efi_mem_type()

Posted by Ard Biesheuvel 4 weeks ago


On Tue, 10 Mar 2026, at 19:56, Marek Marczykowski-Górecki wrote:
> Drop const, as use of efi_mem_desc_lookup() will modify the variable.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202603101851.bAhG7uGN-lkp@intel.com/
> Fixes: 5992265762e6 "efi: make efi_mem_type() and efi_mem_attributes() 
> work on Xen PV"
> Signed-off-by: Marek Marczykowski-Górecki 
> <marmarek@invisiblethingslab.com>
> ---
>  drivers/firmware/efi/efi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks, but i've fixed up the original commit instead.