[PATCH v2 2/5] iio: dac: ad5504: sort headers alphabetically

Taha Ed-Dafili posted 5 patches 4 weeks ago
[PATCH v2 2/5] iio: dac: ad5504: sort headers alphabetically
Posted by Taha Ed-Dafili 4 weeks ago
Rearrange the include headers in alphabetical order to follow the
standard kernel coding style. This is a preparatory cleanup with
no functional changes.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com>
---
 drivers/iio/dac/ad5504.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
index 355bcb6a8ba0..20a36e4a389e 100644
--- a/drivers/iio/dac/ad5504.c
+++ b/drivers/iio/dac/ad5504.c
@@ -5,16 +5,16 @@
  * Copyright 2011 Analog Devices Inc.
  */
 
-#include <linux/interrupt.h>
-#include <linux/fs.h>
+#include <linux/bitops.h>
 #include <linux/device.h>
+#include <linux/fs.h>
+#include <linux/interrupt.h>
 #include <linux/kernel.h>
-#include <linux/spi/spi.h>
+#include <linux/module.h>
+#include <linux/regulator/consumer.h>
 #include <linux/slab.h>
+#include <linux/spi/spi.h>
 #include <linux/sysfs.h>
-#include <linux/regulator/consumer.h>
-#include <linux/module.h>
-#include <linux/bitops.h>
 
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
-- 
2.47.3
Re: [PATCH v2 2/5] iio: dac: ad5504: sort headers alphabetically
Posted by Krzysztof Kozlowski 4 weeks ago
On 10/03/2026 18:48, Taha Ed-Dafili wrote:
> Rearrange the include headers in alphabetical order to follow the
> standard kernel coding style. This is a preparatory cleanup with
> no functional changes.
> 
> Suggested-by: Andy Shevchenko <andy@kernel.org>

Where was this patch suggested by Andy?

Best regards,
Krzysztof
Re: [PATCH v2 2/5] iio: dac: ad5504: sort headers alphabetically
Posted by Jonathan Cameron 3 weeks, 2 days ago
On Tue, 10 Mar 2026 21:15:16 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 10/03/2026 18:48, Taha Ed-Dafili wrote:
> > Rearrange the include headers in alphabetical order to follow the
> > standard kernel coding style. This is a preparatory cleanup with
> > no functional changes.
> > 
> > Suggested-by: Andy Shevchenko <andy@kernel.org>  
> 
> Where was this patch suggested by Andy?
https://lore.kernel.org/all/aY40-0v9tbXC4tPY@smile.fi.intel.com/

It's one of Andy's favourite bits or 'whilst you are here
feedback' and was given for this specific driver.

> 
> Best regards,
> Krzysztof
Re: [PATCH v2 2/5] iio: dac: ad5504: sort headers alphabetically
Posted by Andy Shevchenko 4 weeks ago
On Tue, Mar 10, 2026 at 05:48:32PM +0000, Taha Ed-Dafili wrote:
> Rearrange the include headers in alphabetical order to follow the
> standard kernel coding style. This is a preparatory cleanup with
> no functional changes.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko