sound/soc/codecs/Kconfig | 14 +- sound/soc/codecs/Makefile | 2 + sound/soc/codecs/wm_adsp.c | 234 +++-- sound/soc/codecs/wm_adsp.h | 19 + sound/soc/codecs/wm_adsp_fw_find_test.c | 1221 +++++++++++++++++++++++ 5 files changed, 1383 insertions(+), 107 deletions(-) create mode 100644 sound/soc/codecs/wm_adsp_fw_find_test.c
This series makes some improvements to the code that searches for firmware
files.
Patch 1 is a trivial patch to remove an unused function argument, before
adding any new code that uses this API.
Patches 2..4 add KUnit testing to prove that the subsequent changes don't
break anything.
The remaining patches remove duplicated code and clean up some of the
implementation.
Richard Fitzgerald (10):
ASoC: wm_adsp: Remove unused argument to
wm_adsp_release_firmware_files()
ASoC: wm_adsp: Add KUnit redirection stubs for firmware file search
ASoC: wm_adsp: Export function for KUnit test to get firmware
filenames
ASoC: wm_adsp: Add kunit test for firmware file search
ASoC: wm_adsp: Remove duplicated code to find firmware file
ASoC: wm_adsp: Use consistent error checks in
wm_adsp_request_firmware_files()
ASoC: wm_adsp: Convert '/' to '-' when normalizing firmware filenames
ASoC: wm_adsp: Add KUnit test cases for '/' in firmware filenames
ASoC: wm_adsp: Use a struct to pass around firmware struct and
filename
ASoC: wm_adsp: Combine some similar code in firmware file search
sound/soc/codecs/Kconfig | 14 +-
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/wm_adsp.c | 234 +++--
sound/soc/codecs/wm_adsp.h | 19 +
sound/soc/codecs/wm_adsp_fw_find_test.c | 1221 +++++++++++++++++++++++
5 files changed, 1383 insertions(+), 107 deletions(-)
create mode 100644 sound/soc/codecs/wm_adsp_fw_find_test.c
--
2.47.3
On Tue, 10 Mar 2026 14:18:07 +0000, Richard Fitzgerald wrote:
> This series makes some improvements to the code that searches for firmware
> files.
>
> Patch 1 is a trivial patch to remove an unused function argument, before
> adding any new code that uses this API.
>
> Patches 2..4 add KUnit testing to prove that the subsequent changes don't
> break anything.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[01/10] ASoC: wm_adsp: Remove unused argument to wm_adsp_release_firmware_files()
commit: 1eadb7791ee5699ca58920ef705ce0934c814ece
[02/10] ASoC: wm_adsp: Add KUnit redirection stubs for firmware file search
commit: 70057cfe492d600c2b83598e8b8b64780b2ca147
[03/10] ASoC: wm_adsp: Export function for KUnit test to get firmware filenames
commit: b4e6b01191afb9516570437a7aff61019134fd59
[04/10] ASoC: wm_adsp: Add kunit test for firmware file search
commit: bf2d44d07de726b0393439cb4d4defc5cf89a4fc
[05/10] ASoC: wm_adsp: Remove duplicated code to find firmware file
commit: 2c7c27025374abbdeda201ad103ddf27e8079aec
[06/10] ASoC: wm_adsp: Use consistent error checks in wm_adsp_request_firmware_files()
commit: f8f0c68c75214e326c0d4cbcab8ecab882201f48
[07/10] ASoC: wm_adsp: Convert '/' to '-' when normalizing firmware filenames
commit: 66170cc7ed59fb7e1e192e53f1d690bd04e8c720
[08/10] ASoC: wm_adsp: Add KUnit test cases for '/' in firmware filenames
commit: d8a4c96082e6f5c7aaf6f3e101effe7ff0ea4d6e
[09/10] ASoC: wm_adsp: Use a struct to pass around firmware struct and filename
commit: 7bca3ca55ef53ca66fdf6e663290d0596a8f520d
[10/10] ASoC: wm_adsp: Combine some similar code in firmware file search
commit: 8fc5c7895185d1119ae76b509892a1d14e0bd483
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
On Tue, Mar 10, 2026 at 02:18:07PM +0000, Richard Fitzgerald wrote: > This series makes some improvements to the code that searches for firmware > files. > > Patch 1 is a trivial patch to remove an unused function argument, before > adding any new code that uses this API. > > Patches 2..4 add KUnit testing to prove that the subsequent changes don't > break anything. > > The remaining patches remove duplicated code and clean up some of the > implementation. Actually I'm seeing failures with this running on arm64, they were missed by my testing due to issues with KUnit in -rc1, looking at this clearly a lot of the problems are knock on results of an initial failure: [14:52:36] ============ wm_adsp_fw_find_test_search_order ============ [14:52:36] [PASSED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:( ) [14:52:36] [PASSED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:( ) [14:52:36] [PASSED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: expects:( ) [14:52:36] [PASSED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:( ) [14:52:36] [PASSED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 expects:( ) [14:52:36] [PASSED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 wmfw_optional expects:( ) [14:52:36] [PASSED] cs1234 dsp1 fwf_name:ao system:ABC123 alsa_name:amp1 expects:( ) [14:52:36] [PASSED] cs1234 dsp1 fwf_name:ao system:ABC123 alsa_name:amp1 wmfw_optional expects:( ) [14:52:36] ======== [PASSED] wm_adsp_fw_find_test_search_order ======== [14:52:36] ============ wm_adsp_fw_find_test_search_order ============ [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-abc123-amp1.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-abc123-amp1.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-abc123-amp1.wmfw cirrus/cs1234-dsp1-mbc [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-abc123-amp1.wmfw cirrus/cs [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw cirrus/cs1234-dsp1-mbc-vss- [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw cirrus/cs1234- [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw cirrus/cs1234-dsp1-mbc-vss- [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw cirrus/cs1234- [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:( cirrus/cs1234-dsp1-mbc-vss-abc123-amp1.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:( cirrus/cs1234-dsp1-mbc-vss-abc123.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cs1234-dsp1-mbc-vss.wmfw cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cs1234-dsp1-mbc-vss.wmfw cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mb [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name:amp1 wmfw_optional expects:( cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Unable to handle kernel paging request at virtual address ffffffffc202b0c8 [14:52:36] Mem abort info: [14:52:36] ESR = 0x0000000096000006 [14:52:36] EC = 0x25: DABT (current EL), IL = 32 bits [14:52:36] SET = 0, FnV = 0 [14:52:36] EA = 0, S1PTW = 0 [14:52:36] FSC = 0x06: level 2 translation fault [14:52:36] Data abort info: [14:52:36] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000 [14:52:36] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [14:52:36] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [14:52:36] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000040e95000 [14:52:36] [ffffffffc202b0c8] pgd=0000000000000000, p4d=0000000041103403, pud=0000000041104403, pmd=0000000000000000 [14:52:36] Internal error: Oops: 0000000096000006 [#2] SMP [14:52:36] CPU: 0 UID: 0 PID: 11523 Comm: kunit_try_catch Tainted: G D W N 7.0.0-rc3-ga7ea17ac86d4 #11 PREEMPTLAZY [14:52:36] Tainted: [D]=DIE, [W]=WARN, [N]=TEST [14:52:36] Hardware name: linux,dummy-virt (DT) [14:52:36] pstate: a3400005 (NzCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) [14:52:36] pc : kfree+0x38/0x2a0 [14:52:36] lr : release_firmware+0x28/0x6c [14:52:36] sp : ffff80008348bda0 [14:52:36] x29: ffff80008348bda0 x28: 0000000000000000 x27: 0000000000000000 [14:52:36] x26: 0000000000000000 x25: 0000000000000000 x24: ffff800080fbb850 [14:52:36] x23: ffff8000803e9e80 x22: ffff800080fbb680 x21: ffff000006923b40 [14:52:36] x20: ffff800080ac3010 x19: ffffffffc202b0c0 x18: 0000000000000014 [14:52:36] x17: 00000000f7d33fac x16: 00000000fda59ba1 x15: 00000000e1f102aa [14:52:36] x14: 000000000000026d x13: 0000000000000000 x12: ffff00003fddaf40 [14:52:36] x11: 00000000000000c0 x10: ffff0000045a26e8 x9 : 0000000000000000 [14:52:36] x8 : ffff00000a1e4cc0 x7 : 0000000000000000 x6 : 0000000000000001 [14:52:36] x5 : 000000000000003c x4 : ffff800080fbb898 x3 : ffff8000803e8820 [14:52:36] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffffffffc202b0c0 [14:52:36] Call trace: [14:52:36] kfree+0x38/0x2a0 (P) [14:52:36] release_firmware+0x28/0x6c [14:52:36] wm_adsp_release_firmware_files+0x20/0x80 [14:52:36] wm_adsp_fw_find_test_case_exit+0x18/0x24 [14:52:36] kunit_try_run_case_cleanup+0x2c/0x44 [14:52:36] kunit_generic_run_threadfn_adapter+0x28/0x4c [14:52:36] kthread+0x108/0x120 [14:52:36] ret_from_fork+0x10/0x20 [14:52:36] Code: d34cfe73 f2d83fe0 8b131813 aa1303e0 (f9400661) [14:52:36] ---[ end trace 0000000000000000 ]--- [14:52:36] # wm_adsp_fw_find_test_search_order: try faulted: last line seen sound/soc/codecs/wm_adsp_fw_find_test.c:193 [14:52:36] # wm_adsp_fw_find_test_search_order: internal error occurred during test case cleanup: -4 [14:52:36] # wm_adsp_fw_find_test_search_order: pass:0 fail:21 skip:0 total:21 [14:52:36] ======== [FAILED] wm_adsp_fw_find_test_search_order ======== [14:52:36] ============ wm_adsp_fw_find_test_search_order ============ [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw cirrus/cs1234-dsp1-mbc-vss-abc1 [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-abc123.wmfw cirrus/cs1234-dsp1 [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:( cirrus/cs1234-dsp1-mbc-vss-abc123.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: expects:(cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:(cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: expects:(cs1234-dsp1-mbc-vss.wmfw cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:(cs1234-dsp1-mbc-vss.wmfw cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vs [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:ABC123 alsa_name: wmfw_optional expects:( cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] # wm_adsp_fw_find_test_search_order: pass:0 fail:14 skip:0 total:14 [14:52:36] ======== [FAILED] wm_adsp_fw_find_test_search_order ======== [14:52:36] ============ wm_adsp_fw_find_test_search_order ============ [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 expects:(cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 wmfw_optional expects:(cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 expects:(cs1234-dsp1-mbc-vss.wmfw cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 wmfw_optional expects:(cs1234-dsp1-mbc-vss.wmfw cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vss. [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name:amp1 wmfw_optional expects:( cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] # wm_adsp_fw_find_test_search_order: pass:0 fail:9 skip:0 total:9 [14:52:36] ======== [FAILED] wm_adsp_fw_find_test_search_order ======== [14:52:36] ============ wm_adsp_fw_find_test_search_order ============ [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: expects:(cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: wmfw_optional expects:(cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: expects:(cs1234-dsp1-mbc-vss.wmfw cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: wmfw_optional expects:(cs1234-dsp1-mbc-vss.wmfw cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: wmfw_optional expects:( cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] # wm_adsp_fw_find_test_search_order: pass:0 fail:9 skip:0 total:9 [14:52:36] ======== [FAILED] wm_adsp_fw_find_test_search_order ======== [14:52:36] ============ wm_adsp_fw_find_test_search_order ============ [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:Vendor alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss-vendor.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:Vendor Device alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss-vendor-device.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:Vendor_Device alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss-vendor-device.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:Vendor/Device alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss-vendor-device.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:1234:56AB alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss-1234-56ab.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:abc alsa_name:LEFT expects:(cirrus/cs1234-dsp1-mbc-vss-abc-left.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:abc alsa_name:LEFT AMP expects:(cirrus/cs1234-dsp1-mbc-vss-abc-left-amp.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:abc alsa_name:Left Amp expects:(cirrus/cs1234-dsp1-mbc-vss-abc-left-amp.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:abc alsa_name:Amp_1 expects:(cirrus/cs1234-dsp1-mbc-vss-abc-amp-1.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:abc alsa_name:cs1234.1 expects:(cirrus/cs1234-dsp1-mbc-vss-abc-cs1234.1.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:abc alsa_name:Spk/Jack expects:(cirrus/cs1234-dsp1-mbc-vss-abc-spk-jack.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_search_order: failed to initialize: -16 [14:52:36] # wm_adsp_fw_find_test_search_order: pass:0 fail:11 skip:0 total:11 [14:52:36] ======== [FAILED] wm_adsp_fw_find_test_search_order ======== [14:52:36] ============= wm_adsp_fw_find_test_pick_file ============== [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WFBF1111 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-wfbf1111-amp1.wmfw cirrus/cs1234-dsp1 [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WFBF1111 alsa_name:l1u2 expects:(cirrus/cs1234-dsp1-mbc-vss-wfbf1111-l1u2.wmfw cirrus/cs1234-dsp1 [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WSBF1111 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-wsbf1111.wmfw cirrus/cs1234-dsp1-mbc- [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WSBF1111 alsa_name:l1u2 expects:(cirrus/cs1234-dsp1-mbc-vss-wsbf1111.wmfw cirrus/cs1234-dsp1-mbc- [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WFBF1111 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-wfbf1111-amp1.wmfw cirru [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WSBS1111 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-wsbs1111.wmfw cirrus/cs1234-dsp1-mbc- [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WSBF1111 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-wsbf1111.wmfw cirrus/cs1 [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:XXBF1111 alsa_name:amp1 wmfw_optional expects:( cirrus/cs1234-dsp1-mbc-vss-xxbf1111-amp1.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WFBF1111 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-wfbf1111-amp1.wmfw cirrus/cs1234-dsp1 [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WFXX1111 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss-wfxx1111.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:WFXX1111 alsa_name:amp1 wmfw_optional expects:(cirrus/cs1234-dsp1-mbc-vss-wfxx1111.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system:XXXX1111 alsa_name:amp1 expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234nobin dsp1 fwf_name: system:XXXX1111 alsa_name:amp1 expects:(cirrus/cs1234nobin-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] wm1234nobin dsp1 fwf_name: system: alsa_name: expects:(wm1234nobin-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] wm1234 dsp1 fwf_name: system: alsa_name: expects:(wm1234-dsp1-mbc-vss.wmfw wm1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234nobin dsp1 fwf_name: system: alsa_name: expects:(cirrus/cs1234nobin-dsp1-mbc-vss.wmfw ) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] [FAILED] cs1234 dsp1 fwf_name: system: alsa_name: expects:(cirrus/cs1234-dsp1-mbc-vss.wmfw cirrus/cs1234-dsp1-mbc-vss.bin) [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_pick_file: failed to initialize: -16 [14:52:36] # wm_adsp_fw_find_test_pick_file: pass:0 fail:17 skip:0 total:17 [14:52:36] ========= [FAILED] wm_adsp_fw_find_test_pick_file ========== [14:52:36] Error: Driver 'wm_adsp_test_drv' is already registered, aborting... [14:52:36] # wm_adsp_fw_find_test_find_firmware_byindex: failed to initialize: -16 [14:52:36] [FAILED] wm_adsp_fw_find_test_find_firmware_byindex [14:52:36] # module: snd_soc_wm_adsp_test [14:52:36] # wm-adsp-fw-find: pass:1 fail:7 skip:0 total:8 [14:52:36] # Totals: pass:8 fail:82 skip:0 total:90 [14:52:36] ================= [FAILED] wm-adsp-fw-find ================= Failures: wm-adsp-fw-find.wm_adsp_fw_find_test_search_order, wm-adsp-fw-find.wm_adsp_fw_find_test_search_order, wm-adsp-fw-find.wm_adsp_fw_find_test_search_order, wm-adsp-fw-find.wm_adsp_fw_find_test_search_order, wm-adsp-fw-find.wm_adsp_fw_find_test_search_order, wm-adsp-fw-find.wm_adsp_fw_find_test_pick_file, wm-adsp-fw-find.wm_adsp_fw_find_test_find_firmware_byindex
On Fri, Mar 13, 2026 at 02:58:13PM +0000, Mark Brown wrote: > On Tue, Mar 10, 2026 at 02:18:07PM +0000, Richard Fitzgerald wrote: > > This series makes some improvements to the code that searches for firmware > > files. > > Patch 1 is a trivial patch to remove an unused function argument, before > > adding any new code that uses this API. > > Patches 2..4 add KUnit testing to prove that the subsequent changes don't > > break anything. > > The remaining patches remove duplicated code and clean up some of the > > implementation. > Actually I'm seeing failures with this running on arm64, they were > missed by my testing due to issues with KUnit in -rc1, looking at this > clearly a lot of the problems are knock on results of an initial failure: Any updates on getting this fixed?
On Tue, Mar 17, 2026 at 03:37:53PM +0000, Mark Brown wrote: > On Fri, Mar 13, 2026 at 02:58:13PM +0000, Mark Brown wrote: > > On Tue, Mar 10, 2026 at 02:18:07PM +0000, Richard Fitzgerald wrote: > > > > This series makes some improvements to the code that searches for firmware > > > files. > > > > Patch 1 is a trivial patch to remove an unused function argument, before > > > adding any new code that uses this API. > > > > Patches 2..4 add KUnit testing to prove that the subsequent changes don't > > > break anything. > > > > The remaining patches remove duplicated code and clean up some of the > > > implementation. > > > Actually I'm seeing failures with this running on arm64, they were > > missed by my testing due to issues with KUnit in -rc1, looking at this > > clearly a lot of the problems are knock on results of an initial failure: > > Any updates on getting this fixed? Apologies Richard is on holiday this week. I will see if I can find a moment to have a quick look. Thanks, Charles
On Tue, Mar 17, 2026 at 03:52:33PM +0000, Charles Keepax wrote: > On Tue, Mar 17, 2026 at 03:37:53PM +0000, Mark Brown wrote: > > On Fri, Mar 13, 2026 at 02:58:13PM +0000, Mark Brown wrote: > > > On Tue, Mar 10, 2026 at 02:18:07PM +0000, Richard Fitzgerald wrote: > > > > > > This series makes some improvements to the code that searches for firmware > > > > files. > > > > > > Patch 1 is a trivial patch to remove an unused function argument, before > > > > adding any new code that uses this API. > > > > > > Patches 2..4 add KUnit testing to prove that the subsequent changes don't > > > > break anything. > > > > > > The remaining patches remove duplicated code and clean up some of the > > > > implementation. > > > > > Actually I'm seeing failures with this running on arm64, they were > > > missed by my testing due to issues with KUnit in -rc1, looking at this > > > clearly a lot of the problems are knock on results of an initial failure: > > > > Any updates on getting this fixed? > > Apologies Richard is on holiday this week. I will see if I can > find a moment to have a quick look. The rabbit whole looks pretty deep on this one. As far as I can see it fails adding the device because the device already exists on the bus but this is the first time it added the device and also I can find no evidence it even created a bus in the first place. Feels like there is a large piece of my understanding of how this is supposed to work that is missing. I think we might have to wait for Richard to return on Monday, how much of a problem is that from your end? Thanks, Charles
On Tue, Mar 17, 2026 at 05:47:19PM +0000, Charles Keepax wrote: > The rabbit whole looks pretty deep on this one. As far as I can > see it fails adding the device because the device already exists > on the bus but this is the first time it added the device and also > I can find no evidence it even created a bus in the first place. > Feels like there is a large piece of my understanding of how > this is supposed to work that is missing. I think we might have > to wait for Richard to return on Monday, how much of a problem > is that from your end? This is holding inclusion of any new ASoC code since last Thursday out of -next, that's pretty disruptive really. It might be easiest to just drop the changes and let Richard resubmit when he gets back.
On Tue, Mar 17, 2026 at 06:11:23PM +0000, Mark Brown wrote: > On Tue, Mar 17, 2026 at 05:47:19PM +0000, Charles Keepax wrote: > > > The rabbit whole looks pretty deep on this one. As far as I can > > see it fails adding the device because the device already exists > > on the bus but this is the first time it added the device and also > > I can find no evidence it even created a bus in the first place. > > Feels like there is a large piece of my understanding of how > > this is supposed to work that is missing. I think we might have > > to wait for Richard to return on Monday, how much of a problem > > is that from your end? > > This is holding inclusion of any new ASoC code since last Thursday out > of -next, that's pretty disruptive really. It might be easiest to just > drop the changes and let Richard resubmit when he gets back. Ok I will have a bit more of a gander today and chat to the boss here, but I suspect you are right we may have to revert the change. I will report back by end of today if not sooner. Thanks, Charles
On Wed, Mar 18, 2026 at 09:31:41AM +0000, Charles Keepax wrote: > On Tue, Mar 17, 2026 at 06:11:23PM +0000, Mark Brown wrote: > > On Tue, Mar 17, 2026 at 05:47:19PM +0000, Charles Keepax wrote: > > > > > The rabbit whole looks pretty deep on this one. As far as I can > > > see it fails adding the device because the device already exists > > > on the bus but this is the first time it added the device and also > > > I can find no evidence it even created a bus in the first place. > > > Feels like there is a large piece of my understanding of how > > > this is supposed to work that is missing. I think we might have > > > to wait for Richard to return on Monday, how much of a problem > > > is that from your end? > > > > This is holding inclusion of any new ASoC code since last Thursday out > > of -next, that's pretty disruptive really. It might be easiest to just > > drop the changes and let Richard resubmit when he gets back. > > Ok I will have a bit more of a gander today and chat to the boss > here, but I suspect you are right we may have to revert the > change. I will report back by end of today if not sooner. Ok looking again with fresh eyes I think I have it. Turns out most of my problems yesterday were just finding the right incantations to get kunit to show me all the debug. Patch incoming shortly. Thanks, Charles
On Wed, Mar 18, 2026 at 10:27:15AM +0000, Charles Keepax wrote: > On Wed, Mar 18, 2026 at 09:31:41AM +0000, Charles Keepax wrote: > > Ok I will have a bit more of a gander today and chat to the boss > > here, but I suspect you are right we may have to revert the > > change. I will report back by end of today if not sooner. > Ok looking again with fresh eyes I think I have it. Turns out > most of my problems yesterday were just finding the right > incantations to get kunit to show me all the debug. > Patch incoming shortly. Awesome, thanks so much!
© 2016 - 2026 Red Hat, Inc.