Starting with sc7280(kodiak), the ICE will have its own device-tree node.
So add the qcom,ice property to reference it.
To avoid double-modeling, when qcom,ice is present, disallow an embedded
ICE register region in the SDHCI node. Older SoCs without ICE remain
valid as no additional requirement is imposed.
Co-developed-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
---
Some initial work is done by Abel here:
https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/
and by Abhinaba here:
https://lore.kernel.org/all/20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-1-2a34d8d03c72@oss.qualcomm.com/
This patch adds the purpose and usage for phandle in the description and encodes
it properly in the schema.
---
.../devicetree/bindings/mmc/sdhci-msm.yaml | 95 +++++++++++++------
1 file changed, 67 insertions(+), 28 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 938be8228d66..cc9f7724bdf0 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -140,6 +140,11 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
description: platform specific settings for DLL_CONFIG reg.
+ qcom,ice:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ phandle to the Inline Crypto Engine (ICE) hardware block for this controller.
+
iommus:
minItems: 1
maxItems: 8
@@ -193,35 +198,69 @@ allOf:
enum:
- qcom,sdhci-msm-v4
then:
- properties:
- reg:
- minItems: 2
- items:
- - description: Host controller register map
- - description: SD Core register map
- - description: CQE register map
- - description: Inline Crypto Engine register map
- reg-names:
- minItems: 2
- items:
- - const: hc
- - const: core
- - const: cqhci
- - const: ice
+ if:
+ required:
+ - qcom,ice
+ then:
+ properties:
+ reg:
+ minItems: 2
+ items:
+ - description: Host controller register map
+ - description: SD Core register map
+ - description: CQE register map
+ reg-names:
+ minItems: 2
+ items:
+ - const: hc
+ - const: core
+ - const: cqhci
+ else:
+ properties:
+ reg:
+ minItems: 2
+ items:
+ - description: Host controller register map
+ - description: SD Core register map
+ - description: CQE register map
+ - description: Inline Crypto Engine register map
+ reg-names:
+ minItems: 2
+ items:
+ - const: hc
+ - const: core
+ - const: cqhci
+ - const: ice
else:
- properties:
- reg:
- minItems: 1
- items:
- - description: Host controller register map
- - description: CQE register map
- - description: Inline Crypto Engine register map
- reg-names:
- minItems: 1
- items:
- - const: hc
- - const: cqhci
- - const: ice
+ if:
+ required:
+ - qcom,ice
+ then:
+ properties:
+ reg:
+ minItems: 1
+ items:
+ - description: Host controller register map
+ - description: CQE register map
+ reg-names:
+ minItems: 1
+ items:
+ - const: hc
+ - const: cqhci
+ else:
+ properties:
+ reg:
+ minItems: 1
+ items:
+ - description: Host controller register map
+ - description: CQE register map
+ - description: Inline Crypto Engine register map
+ reg-names:
+ minItems: 1
+ items:
+ - const: hc
+ - const: cqhci
+ - const: ice
unevaluatedProperties: false
--
2.34.1On 3/10/2026 5:05 PM, Neeraj Soni wrote: > Starting with sc7280(kodiak), the ICE will have its own device-tree node. > So add the qcom,ice property to reference it. > > To avoid double-modeling, when qcom,ice is present, disallow an embedded > ICE register region in the SDHCI node. Older SoCs without ICE remain > valid as no additional requirement is imposed. > > Co-developed-by: Abel Vesa <abel.vesa@linaro.org> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> > Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> > Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> Reviewed-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> -- Regards Kuldeep
On Tue, Mar 10, 2026 at 05:05:55PM +0530, Neeraj Soni wrote: > Starting with sc7280(kodiak), the ICE will have its own device-tree node. > So add the qcom,ice property to reference it. > > To avoid double-modeling, when qcom,ice is present, disallow an embedded > ICE register region in the SDHCI node. Older SoCs without ICE remain > valid as no additional requirement is imposed. > > Co-developed-by: Abel Vesa <abel.vesa@linaro.org> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> > Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> > Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> > Can you please finally start using b4? Except errors in your process I don't see links to previous discussions either. <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On 3/11/2026 11:46 AM, Krzysztof Kozlowski wrote: > On Tue, Mar 10, 2026 at 05:05:55PM +0530, Neeraj Soni wrote: >> Starting with sc7280(kodiak), the ICE will have its own device-tree node. >> So add the qcom,ice property to reference it. >> >> To avoid double-modeling, when qcom,ice is present, disallow an embedded >> ICE register region in the SDHCI node. Older SoCs without ICE remain >> valid as no additional requirement is imposed. >> >> Co-developed-by: Abel Vesa <abel.vesa@linaro.org> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> >> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> >> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> >> > > Can you please finally start using b4? Except errors in your process I > don't see links to previous discussions either. > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions of patchset, under or above your Signed-off-by tag, unless > patch changed significantly (e.g. new properties added to the DT > bindings). Tag is "received", when provided in a message replied to you > on the mailing list. Tools like b4 can help here. However, there's no > need to repost patches *only* to add the tags. The upstream maintainer > will do that for tags received on the version they apply. I understand that a repost is not needed only to add the tag but in this case whether a repost is expected since a new patch 'v6' was posted without 'Reviewed-by:' tag which was provided on 'v5'? > > Please read: > https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof > Regards, Neeraj
On 3/11/2026 11:46 AM, Krzysztof Kozlowski wrote: > On Tue, Mar 10, 2026 at 05:05:55PM +0530, Neeraj Soni wrote: >> Starting with sc7280(kodiak), the ICE will have its own device-tree node. >> So add the qcom,ice property to reference it. >> >> To avoid double-modeling, when qcom,ice is present, disallow an embedded >> ICE register region in the SDHCI node. Older SoCs without ICE remain >> valid as no additional requirement is imposed. >> >> Co-developed-by: Abel Vesa <abel.vesa@linaro.org> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> >> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> >> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> >> > > Can you please finally start using b4? Except errors in your process I > don't see links to previous discussions either. > Sure. I will be adding links for previouse discussions going forward for all patches. > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions of patchset, under or above your Signed-off-by tag, unless > patch changed significantly (e.g. new properties added to the DT > bindings). Tag is "received", when provided in a message replied to you > on the mailing list. Tools like b4 can help here. However, there's no > need to repost patches *only* to add the tags. The upstream maintainer > will do that for tags received on the version they apply. > > Please read: > https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > This was not done on purpose but i missed to add Reviewed-by tag. > Best regards, > Krzysztof > Regards, Neeraj
© 2016 - 2026 Red Hat, Inc.