[PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format

Chancel Liu posted 1 patch 1 month ago
There is a newer version of this series
Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
1 file changed, 1 insertion(+)
[PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
Posted by Chancel Liu 1 month ago
The imx-card machine driver originally supported only codecs operating
in i2s or dsp_b formats. This machine driver can support CS42448 codec
and this codec typically uses dsp_a for its TDM interface. Therefore,
dsp_a format support is required for describing such sound cards in DT.

Update DT bindings to include "dsp_a" in the list of supported DAI
formats.

Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
---
 Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
index 3c75c8c78987..5c08289346c0 100644
--- a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
+++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
@@ -36,6 +36,7 @@ patternProperties:
         items:
           enum:
             - i2s
+            - dsp_a
             - dsp_b
 
       dai-tdm-slot-num:
-- 
2.50.1
Re: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
Posted by Krzysztof Kozlowski 4 weeks ago
On Tue, Mar 10, 2026 at 03:35:22PM +0900, Chancel Liu wrote:
> The imx-card machine driver originally supported only codecs operating
> in i2s or dsp_b formats. This machine driver can support CS42448 codec
> and this codec typically uses dsp_a for its TDM interface. Therefore,

And what about other formats, which was asked last time?

> dsp_a format support is required for describing such sound cards in DT.
> 
> Update DT bindings to include "dsp_a" in the list of supported DAI
> formats.
> 
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
>  Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
>  1 file changed, 1 insertion(+)

Where is changelog?

Where is any explanation how you handled or not handled previous review?

Best regards,
Krzysztof
Re: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
Posted by Frank Li 4 weeks, 1 day ago
On Tue, Mar 10, 2026 at 03:35:22PM +0900, Chancel Liu wrote:
> The imx-card machine driver originally supported only codecs operating
> in i2s or dsp_b formats. This machine driver can support CS42448 codec
> and this codec typically uses dsp_a for its TDM interface. Therefore,
> dsp_a format support is required for describing such sound cards in DT.

binding is descript hardware not driver. s/driver/device.

Frank
>
> Update DT bindings to include "dsp_a" in the list of supported DAI
> formats.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
>  Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> index 3c75c8c78987..5c08289346c0 100644
> --- a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> @@ -36,6 +36,7 @@ patternProperties:
>          items:
>            enum:
>              - i2s
> +            - dsp_a
>              - dsp_b
>
>        dai-tdm-slot-num:
> --
> 2.50.1
>