1. Patchew
  2. linux
  3. View series

[PATCH] gpu: nova: rename drivers to use kebab-case convention

Cheng-Yang Chou posted 1 patch 1 month ago 
drivers/gpu/drm/nova/driver.rs     | 4 ++--
drivers/gpu/drm/nova/nova.rs       | 2 +-
drivers/gpu/nova-core/nova_core.rs | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
[PATCH] gpu: nova: rename drivers to use kebab-case convention
Posted by Cheng-Yang Chou 1 month ago 
Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
driver from "Nova" to "nova-drm" to follow kernel naming conventions
before these names become UAPI (e.g. exposed via driver_override).

Link: https://github.com/Rust-for-Linux/linux/issues/1228
Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
---
 drivers/gpu/drm/nova/driver.rs     | 4 ++--
 drivers/gpu/drm/nova/nova.rs       | 2 +-
 drivers/gpu/nova-core/nova_core.rs | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
index b1af0a099551..addf70c33cb2 100644
--- a/drivers/gpu/drm/nova/driver.rs
+++ b/drivers/gpu/drm/nova/driver.rs
@@ -32,11 +32,11 @@ pub(crate) struct NovaData {
     major: 0,
     minor: 0,
     patchlevel: 0,
-    name: c"nova",
+    name: c"nova-drm",
     desc: c"Nvidia Graphics",
 };
 
-const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
+const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
 const AUXILIARY_NAME: &CStr = c"nova-drm";
 
 kernel::auxiliary_device_table!(
diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
index 8893e58ee0db..1fd454c7e0df 100644
--- a/drivers/gpu/drm/nova/nova.rs
+++ b/drivers/gpu/drm/nova/nova.rs
@@ -10,7 +10,7 @@
 
 kernel::module_auxiliary_driver! {
     type: NovaDriver,
-    name: "Nova",
+    name: "nova-drm",
     authors: ["Danilo Krummrich"],
     description: "Nova GPU driver",
     license: "GPL v2",
diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nova_core.rs
index c1121e7c64c5..90e98380687b 100644
--- a/drivers/gpu/nova-core/nova_core.rs
+++ b/drivers/gpu/nova-core/nova_core.rs
@@ -22,7 +22,7 @@
 
 kernel::module_pci_driver! {
     type: driver::NovaCore,
-    name: "NovaCore",
+    name: "nova-core",
     authors: ["Danilo Krummrich"],
     description: "Nova Core GPU driver",
     license: "GPL v2",
-- 
2.48.1
Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Posted by John Hubbard 4 weeks, 1 day ago 
On 3/9/26 11:24 PM, Cheng-Yang Chou wrote:
> Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
> driver from "Nova" to "nova-drm" to follow kernel naming conventions
> before these names become UAPI (e.g. exposed via driver_override).
> 
> Link: https://github.com/Rust-for-Linux/linux/issues/1228
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
> ---
>  drivers/gpu/drm/nova/driver.rs     | 4 ++--
>  drivers/gpu/drm/nova/nova.rs       | 2 +-
>  drivers/gpu/nova-core/nova_core.rs | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
> index b1af0a099551..addf70c33cb2 100644
> --- a/drivers/gpu/drm/nova/driver.rs
> +++ b/drivers/gpu/drm/nova/driver.rs
> @@ -32,11 +32,11 @@ pub(crate) struct NovaData {
>      major: 0,
>      minor: 0,
>      patchlevel: 0,
> -    name: c"nova",
> +    name: c"nova-drm",
>      desc: c"Nvidia Graphics",

hmm, as long as we are fooling around with names here, I see that
this should be "NVIDIA Graphics and Compute", really.

Obviously that can be done separately, though.

>  };
>  
> -const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
> +const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
>  const AUXILIARY_NAME: &CStr = c"nova-drm";
>  
>  kernel::auxiliary_device_table!(
> diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
> index 8893e58ee0db..1fd454c7e0df 100644
> --- a/drivers/gpu/drm/nova/nova.rs
> +++ b/drivers/gpu/drm/nova/nova.rs
> @@ -10,7 +10,7 @@
>  
>  kernel::module_auxiliary_driver! {
>      type: NovaDriver,
> -    name: "Nova",
> +    name: "nova-drm",

Well, but now it is out of sync with the file name: nova.rs.

You should change both, or neither, I'm thinking.

>      authors: ["Danilo Krummrich"],
>      description: "Nova GPU driver",
>      license: "GPL v2",
> diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nova_core.rs
> index c1121e7c64c5..90e98380687b 100644
> --- a/drivers/gpu/nova-core/nova_core.rs
> +++ b/drivers/gpu/nova-core/nova_core.rs
> @@ -22,7 +22,7 @@
>  
>  kernel::module_pci_driver! {
>      type: driver::NovaCore,
> -    name: "NovaCore",
> +    name: "nova-core",

This bit looks good.

>      authors: ["Danilo Krummrich"],
>      description: "Nova Core GPU driver",
>      license: "GPL v2",

thanks,
-- 
John Hubbard
Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Posted by Cheng-Yang Chou 3 weeks, 6 days ago 
Hi John,

On Tue, Mar 10, 2026 at 06:34:51PM -0700, John Hubbard wrote:
> On 3/9/26 11:24 PM, Cheng-Yang Chou wrote:
> > -    name: c"nova",
> > +    name: c"nova-drm",
> >      desc: c"Nvidia Graphics",
> 
> hmm, as long as we are fooling around with names here, I see that
> this should be "NVIDIA Graphics and Compute", really.
> 
> Obviously that can be done separately, though.

Ok.

> 
> >  };
> >  
> > -const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
> > +const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
> >  const AUXILIARY_NAME: &CStr = c"nova-drm";
> >  
> >  kernel::auxiliary_device_table!(
> > diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
> > index 8893e58ee0db..1fd454c7e0df 100644
> > --- a/drivers/gpu/drm/nova/nova.rs
> > +++ b/drivers/gpu/drm/nova/nova.rs
> > @@ -10,7 +10,7 @@
> >  
> >  kernel::module_auxiliary_driver! {
> >      type: NovaDriver,
> > -    name: "Nova",
> > +    name: "nova-drm",
> 
> Well, but now it is out of sync with the file name: nova.rs.
> 
> You should change both, or neither, I'm thinking.

I think renaming the file to nova_drm.rs would better reflect the
driver's identity now that the module name is nova-drm, making it easier
for readers to associate the source file with the driver.

Would that work for you?

-- 
Thanks,
Cheng-Yang
Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Posted by Danilo Krummrich 3 weeks, 6 days ago 
On Thu Mar 12, 2026 at 7:45 PM CET, Cheng-Yang Chou wrote:
> Hi John,
>
> On Tue, Mar 10, 2026 at 06:34:51PM -0700, John Hubbard wrote:
>> On 3/9/26 11:24 PM, Cheng-Yang Chou wrote:
>> > -    name: c"nova",
>> > +    name: c"nova-drm",
>> >      desc: c"Nvidia Graphics",
>> 
>> hmm, as long as we are fooling around with names here, I see that
>> this should be "NVIDIA Graphics and Compute", really.

SGTM.

>> >  kernel::module_auxiliary_driver! {
>> >      type: NovaDriver,
>> > -    name: "Nova",
>> > +    name: "nova-drm",
>> 
>> Well, but now it is out of sync with the file name: nova.rs.
>> 
>> You should change both, or neither, I'm thinking.
>
> I think renaming the file to nova_drm.rs would better reflect the
> driver's identity now that the module name is nova-drm, making it easier
> for readers to associate the source file with the driver.
>
> Would that work for you?

I think the module name should ideally match the directoy name, i.e. we have

	drivers/gpu/nova-core/

with the module name "nova-core" and

	drivers/gpu/drm/nova/

with the module name "nova-drm".

The reason why this is not .../nova-drm/ already is that I figured it would be a
bit redundant given that "drm" is already part of the path.

While I don't mind changing this, I wonder what this would mean for the
Kconfig, CONFIG_DRM_NOVA_DRM? :)
Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Posted by John Hubbard 3 weeks, 6 days ago 
On 3/12/26 12:16 PM, Danilo Krummrich wrote:
> On Thu Mar 12, 2026 at 7:45 PM CET, Cheng-Yang Chou wrote:
...
>> Would that work for you?
> 
> I think the module name should ideally match the directoy name, i.e. we have
> 
> 	drivers/gpu/nova-core/
> 
> with the module name "nova-core" and
> 
> 	drivers/gpu/drm/nova/
> 
> with the module name "nova-drm".

When p

When people do things like lsmod(1), they don't see the directory
path for the module source code, so if the name doesn't include
drm, then no one knows that "nova" implies "nova-drm".

On the other hand, I was OK with just explaining to people that "nova"
is the upper layer kernel module, and that it's the one that does
DRM things.

Which is why I'm merely "OK" with the name change, as opposed to
thinking that it's required.


> 
> The reason why this is not .../nova-drm/ already is that I figured it would be a
> bit redundant given that "drm" is already part of the path.
> 
> While I don't mind changing this, I wonder what this would mean for the
> Kconfig, CONFIG_DRM_NOVA_DRM? :)

I also worry that we might not have enough DRM's in that
CONFIG item. haha :)

thanks,
-- 
John Hubbard
Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Posted by Danilo Krummrich 3 weeks, 6 days ago 
On Thu Mar 12, 2026 at 8:21 PM CET, John Hubbard wrote:
> On 3/12/26 12:16 PM, Danilo Krummrich wrote:
>> On Thu Mar 12, 2026 at 7:45 PM CET, Cheng-Yang Chou wrote:
> ...
>>> Would that work for you?
>> 
>> I think the module name should ideally match the directoy name, i.e. we have
>> 
>> 	drivers/gpu/nova-core/
>> 
>> with the module name "nova-core" and
>> 
>> 	drivers/gpu/drm/nova/
>> 
>> with the module name "nova-drm".
>
> When p
>
> When people do things like lsmod(1), they don't see the directory
> path for the module source code, so if the name doesn't include
> drm, then no one knows that "nova" implies "nova-drm".
>
> On the other hand, I was OK with just explaining to people that "nova"
> is the upper layer kernel module, and that it's the one that does
> DRM things.
>
> Which is why I'm merely "OK" with the name change, as opposed to
> thinking that it's required.

Just to clarify, I think we should change the directory name and the module name
to nova-drm; the above is what we'd get with the current patch.

>> 
>> The reason why this is not .../nova-drm/ already is that I figured it would be a
>> bit redundant given that "drm" is already part of the path.
>> 
>> While I don't mind changing this, I wonder what this would mean for the
>> Kconfig, CONFIG_DRM_NOVA_DRM? :)
>
> I also worry that we might not have enough DRM's in that
> CONFIG item. haha :)
Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Posted by John Hubbard 3 weeks, 6 days ago 
On 3/12/26 11:45 AM, Cheng-Yang Chou wrote:
...
>>>   kernel::module_auxiliary_driver! {
>>>       type: NovaDriver,
>>> -    name: "Nova",
>>> +    name: "nova-drm",
>>
>> Well, but now it is out of sync with the file name: nova.rs.
>>
>> You should change both, or neither, I'm thinking.
> 
> I think renaming the file to nova_drm.rs would better reflect the
> driver's identity now that the module name is nova-drm, making it easier
> for readers to associate the source file with the driver.
> 
> Would that work for you?
> 

I'm OK with the name change.

thanks,
-- 
John Hubbard
Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Posted by Timur Tabi 4 weeks, 1 day ago 
On Tue, 2026-03-10 at 14:24 +0800, Cheng-Yang Chou wrote:
> Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
> driver from "Nova" to "nova-drm" to follow kernel naming conventions
> before these names become UAPI (e.g. exposed via driver_override).
> 
> Link: https://github.com/Rust-for-Linux/linux/issues/1228
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>

As a Turk, I always approve of kebab-case.

FWIW,

Acked-by: Timur Tabi <ttabi@nvidia.com>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.