[v1] drm/atomic: Rework initial state allocation

[PATCH 12/14] drm/tidss: Drop call to drm_mode_config_reset at probe time

Posted by Maxime Ripard 4 weeks ago

Now that we have drm_mode_config_create_state() to create the initial
state called as part of drm_dev_register(), we don't need to call
drm_mode_config_reset() during the driver probe.

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
 drivers/gpu/drm/tidss/tidss_kms.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
index 8bb93194e5ac686050c47f986b8cb6063eae22d3..b4779c09a1bfa5be7010bcd7d4f1379362996d2e 100644
--- a/drivers/gpu/drm/tidss/tidss_kms.c
+++ b/drivers/gpu/drm/tidss/tidss_kms.c
@@ -285,11 +285,9 @@ int tidss_modeset_init(struct tidss_device *tidss)
 
 	ret = drm_vblank_init(ddev, tidss->num_crtcs);
 	if (ret)
 		return ret;
 
-	drm_mode_config_reset(ddev);
-
 	dev_dbg(tidss->dev, "%s done\n", __func__);
 
 	return 0;
 }

-- 
2.53.0

Re: [PATCH 12/14] drm/tidss: Drop call to drm_mode_config_reset at probe time

Posted by Tomi Valkeinen 3 weeks, 6 days ago

Hi,

On 10/03/2026 18:07, Maxime Ripard wrote:
> Now that we have drm_mode_config_create_state() to create the initial
> state called as part of drm_dev_register(), we don't need to call
> drm_mode_config_reset() during the driver probe.
> 
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
>  drivers/gpu/drm/tidss/tidss_kms.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
> index 8bb93194e5ac686050c47f986b8cb6063eae22d3..b4779c09a1bfa5be7010bcd7d4f1379362996d2e 100644
> --- a/drivers/gpu/drm/tidss/tidss_kms.c
> +++ b/drivers/gpu/drm/tidss/tidss_kms.c
> @@ -285,11 +285,9 @@ int tidss_modeset_init(struct tidss_device *tidss)
>  
>  	ret = drm_vblank_init(ddev, tidss->num_crtcs);
>  	if (ret)
>  		return ret;
>  
> -	drm_mode_config_reset(ddev);
> -
>  	dev_dbg(tidss->dev, "%s done\n", __func__);
>  
>  	return 0;
>  }
> 

There's actually a bug in the upstream tidss driver: it has another
drm_mode_config_reset() call in tidss_drv.c. I have an unsent patch to
drop one of those (the one removed in this patch). Without that patch of
mine, both drm_mode_config_reset() calls should be dropped to actually
test the functionality with tidss.

 Tomi

Re: [PATCH 12/14] drm/tidss: Drop call to drm_mode_config_reset at probe time

Posted by Tomi Valkeinen 3 weeks, 6 days ago

Hi,

On 11/03/2026 09:40, Tomi Valkeinen wrote:
> Hi,
> 
> On 10/03/2026 18:07, Maxime Ripard wrote:
>> Now that we have drm_mode_config_create_state() to create the initial
>> state called as part of drm_dev_register(), we don't need to call
>> drm_mode_config_reset() during the driver probe.
>>
>> Signed-off-by: Maxime Ripard <mripard@kernel.org>
>> ---
>>  drivers/gpu/drm/tidss/tidss_kms.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
>> index 8bb93194e5ac686050c47f986b8cb6063eae22d3..b4779c09a1bfa5be7010bcd7d4f1379362996d2e 100644
>> --- a/drivers/gpu/drm/tidss/tidss_kms.c
>> +++ b/drivers/gpu/drm/tidss/tidss_kms.c
>> @@ -285,11 +285,9 @@ int tidss_modeset_init(struct tidss_device *tidss)
>>  
>>  	ret = drm_vblank_init(ddev, tidss->num_crtcs);
>>  	if (ret)
>>  		return ret;
>>  
>> -	drm_mode_config_reset(ddev);
>> -
>>  	dev_dbg(tidss->dev, "%s done\n", __func__);
>>  
>>  	return 0;
>>  }
>>
> 
> There's actually a bug in the upstream tidss driver: it has another
> drm_mode_config_reset() call in tidss_drv.c. I have an unsent patch to
> drop one of those (the one removed in this patch). Without that patch of
> mine, both drm_mode_config_reset() calls should be dropped to actually
> test the functionality with tidss.
I sent the fix:

https://lore.kernel.org/all/20260311-tidss-minor-fixes-v1-0-ee5e6e14a566%40ideasonboard.com/

 Tomi