[v1] ASoC: codecs: aw88166: Support device specific firmware

[PATCH 1/2] ASoC: dt-bindings: Document firmware-name for awinic,aw88166

Posted by Aaron Kling via B4 Relay 3 weeks, 6 days ago

From: Aaron Kling <webgeek1234@gmail.com>

The driver currently loads a hardcoded firmware. Allow devices to
provide specifically tuned firmware, so the driver can use that instead.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
index 994d68c074a9f221576a5bfef6ba125e3e30bfea..e12d030475e24dd11afaa3c9af4b53703f25f981 100644
--- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
+++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
@@ -48,6 +48,9 @@ properties:
       Flag bit used to keep the phase synchronized in the case of multiple PA
     $ref: /schemas/types.yaml#/definitions/flag
 
+  firmware-name:
+    maxItems: 1
+
 required:
   - compatible
   - reg

-- 
2.53.0

Re: [PATCH 1/2] ASoC: dt-bindings: Document firmware-name for awinic,aw88166

Posted by Krzysztof Kozlowski 3 weeks, 6 days ago

On Tue, Mar 10, 2026 at 11:43:04PM -0500, Aaron Kling wrote:
> The driver currently loads a hardcoded firmware. Allow devices to
> provide specifically tuned firmware, so the driver can use that instead.
> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>  Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> index 994d68c074a9f221576a5bfef6ba125e3e30bfea..e12d030475e24dd11afaa3c9af4b53703f25f981 100644
> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> @@ -48,6 +48,9 @@ properties:
>        Flag bit used to keep the phase synchronized in the case of multiple PA
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  firmware-name:
> +    maxItems: 1

Duplicated patch. Please work on next or maintainer's tree.

Best regards,
Krzysztof

Re: [PATCH 1/2] ASoC: dt-bindings: Document firmware-name for awinic,aw88166

Posted by Aaron Kling 3 weeks, 6 days ago

On Wed, Mar 11, 2026 at 8:16 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, Mar 10, 2026 at 11:43:04PM -0500, Aaron Kling wrote:
> > The driver currently loads a hardcoded firmware. Allow devices to
> > provide specifically tuned firmware, so the driver can use that instead.
> >
> > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> > index 994d68c074a9f221576a5bfef6ba125e3e30bfea..e12d030475e24dd11afaa3c9af4b53703f25f981 100644
> > --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> > +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> > @@ -48,6 +48,9 @@ properties:
> >        Flag bit used to keep the phase synchronized in the case of multiple PA
> >      $ref: /schemas/types.yaml#/definitions/flag
> >
> > +  firmware-name:
> > +    maxItems: 1
>
> Duplicated patch. Please work on next or maintainer's tree.

Noted. I was working on -next, but a couple weeks old. Will rebase and
drop this in the next revision.

Aaron