[v3] media: staging: atomisp: Remove unnecessary return statements from void functions

[PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c

Posted by Tomasz Unger 4 weeks ago

Remove redundant 'return;' statement at the end of void function
ifmtr_set_if_blocking_mode(). Void functions do not need an explicit
return statement at the end.

Found with checkpatch.pl --strict.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
 drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
index 50b0b31d734a..31dd3f99e28e 100644
--- a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
+++ b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
@@ -472,7 +472,6 @@ static void ifmtr_set_if_blocking_mode(
 		}
 	}
 
-	return;
 }
 
 static int ifmtr_start_column(

-- 
2.53.0

Re: [PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c

Posted by Dan Carpenter 3 weeks, 6 days ago

On Tue, Mar 10, 2026 at 10:39:15PM +0100, Tomasz Unger wrote:
> Remove redundant 'return;' statement at the end of void function
> ifmtr_set_if_blocking_mode(). Void functions do not need an explicit
> return statement at the end.
> 
> Found with checkpatch.pl --strict.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
>  drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
> index 50b0b31d734a..31dd3f99e28e 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
> @@ -472,7 +472,6 @@ static void ifmtr_set_if_blocking_mode(
>  		}
>  	}
>  
> -	return;

Delete the blank line as well.

regards,
dan carpenter

>  }
>  
>  static int ifmtr_start_column(
>