staging: atomisp: replace msleep with usleep_range in atomisp-gc2235.c

[PATCH] staging: atomisp: replace msleep with usleep_range in atomisp-gc2235.c

Posted by Oskar Ray-Frayssinet 1 month ago

Replace msleep(5) with usleep_range(5000, 6000) to avoid sleeping
longer than necessary. msleep() with values less than 20ms may sleep
for up to 20ms due to timer granularity.

Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index d3414312e1de..db5e007efc56 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
 			goto fail_power;
 	}
 
-	msleep(5);
+	usleep_range(5000, 6000);
 	return 0;
 
 fail_clk:
-- 
2.43.0

Re: [PATCH] staging: atomisp: replace msleep with usleep_range in atomisp-gc2235.c

Posted by Andy Shevchenko 4 weeks, 1 day ago

On Tue, Mar 10, 2026 at 12:14:45AM +0100, Oskar Ray-Frayssinet wrote:
> Replace msleep(5) with usleep_range(5000, 6000) to avoid sleeping
> longer than necessary. msleep() with values less than 20ms may sleep
> for up to 20ms due to timer granularity.

Use () in Subject, use fsleep() in the code.

-- 
With Best Regards,
Andy Shevchenko

[PATCH v2] staging: media: atomisp: replace msleep() with fsleep() in atomisp-gc2235.c

Posted by Oskar Ray-Frayssinet 4 weeks, 1 day ago

Replace msleep(5) with fsleep(5000) to avoid sleeping longer than
necessary. msleep() with values less than 20ms may sleep for up to
20ms due to timer granularity. fsleep() selects the appropriate sleep
function automatically.

Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index d3414312e1de..7999c8595a68 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
 			goto fail_power;
 	}
 
-	msleep(5);
+	fsleep(5000);
 	return 0;
 
 fail_clk:
-- 
2.43.0