[PATCH v2] staging: rtl8723bs: fix line length in rtw_pwrctrl.c

Ayan Mahmood posted 1 patch 1 month ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
[PATCH v2] staging: rtl8723bs: fix line length in rtw_pwrctrl.c
Posted by Ayan Mahmood 1 month ago
Refactor lines exceeding 100 characters in rtw_pwrctrl.c to
comply with kernel coding style as noted in the driver TODO.

Signed-off-by: Ayan Mahmood <ayanmahmood249@gmail.com>
---
v2:
 - Rebase on staging-testing branch as requested

 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index 666e241704d9..568b4301b7cb 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -331,7 +331,8 @@ static u8 PS_RDY_CHECK(struct adapter *padapter)
 	return true;
 }
 
-void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, u8 smart_ps, u8 bcn_ant_mode, const char *msg)
+void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode,
+		     u8 smart_ps, u8 bcn_ant_mode, const char *msg)
 {
 	struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
 
@@ -359,7 +360,8 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, u8 smart_ps, u8 bcn_a
 			hal_btcoex_LpsNotify(padapter, ps_mode);
 		}
 	} else {
-		if ((PS_RDY_CHECK(padapter) && check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE)) ||
+		if ((PS_RDY_CHECK(padapter) &&
+		     check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE)) ||
 		    ((hal_btcoex_IsBtControlLps(padapter)) && (hal_btcoex_IsLpsOn(padapter)))
 			) {
 			u8 pslv;
@@ -452,7 +454,8 @@ void LPS_Enter(struct adapter *padapter, const char *msg)
 			if (pwrpriv->pwr_mode == PS_MODE_ACTIVE) {
 				scnprintf(buf, sizeof(buf), "WIFI-%s", msg);
 				pwrpriv->bpower_saving = true;
-				rtw_set_ps_mode(padapter, pwrpriv->power_mgnt, padapter->registrypriv.smart_ps, 0, buf);
+				rtw_set_ps_mode(padapter, pwrpriv->power_mgnt,
+						padapter->registrypriv.smart_ps, 0, buf);
 			}
 		} else
 			pwrpriv->LpsIdleCount++;
-- 
2.43.0
Re: [PATCH v2] staging: rtl8723bs: fix line length in rtw_pwrctrl.c
Posted by Ethan Tidmore 1 month ago
On Mon Mar 9, 2026 at 3:21 PM CDT, Ayan Mahmood wrote:
> Refactor lines exceeding 100 characters in rtw_pwrctrl.c to
> comply with kernel coding style as noted in the driver TODO.
>
> Signed-off-by: Ayan Mahmood <ayanmahmood249@gmail.com>

...

>  			hal_btcoex_LpsNotify(padapter, ps_mode);
>  		}
>  	} else {
> -		if ((PS_RDY_CHECK(padapter) && check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE)) ||
> +		if ((PS_RDY_CHECK(padapter) &&
> +		     check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE)) ||
>  		    ((hal_btcoex_IsBtControlLps(padapter)) && (hal_btcoex_IsLpsOn(padapter)))
>  			) {

Go ahead and put the ) { in the correct spot:

  		    ((hal_btcoex_IsBtControlLps(padapter)) && (hal_btcoex_IsLpsOn(padapter)))) {

Thanks,

ET