arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25

[PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25

Posted by Eduard Bostina 1 month ago

Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
raw value is written in this register. This makes the code not obvious
to read and modify.

Use the MX8MP_SION symbolic macro instead of the magic value to improve
code readability.

Signed-off-by: Eduard Bostina <egbostina@gmail.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
index ef012e8365b1f..6ad824a7e07e0 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
@@ -345,7 +345,7 @@ &pinctrl_dhcom_l
 
 	pinctrl_ptn5150: ptn5150grp {
 		fsl,pins = <
-			MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25		0x40000000
+			MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25		MX8MP_SION
 		>;
 	};
 };
-- 
2.43.0

Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25

Posted by Marek Vasut 3 weeks, 5 days ago

On 3/9/26 7:15 PM, Eduard Bostina wrote:
> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
> raw value is written in this register. This makes the code not obvious
> to read and modify.
> 
> Use the MX8MP_SION symbolic macro instead of the magic value to improve
> code readability.
> 
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
>   arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> index ef012e8365b1f..6ad824a7e07e0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> @@ -345,7 +345,7 @@ &pinctrl_dhcom_l
>   
>   	pinctrl_ptn5150: ptn5150grp {
>   		fsl,pins = <
> -			MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25		0x40000000
> +			MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25		MX8MP_SION
Isn't the SION bit at the same bit offset at least since iMX5x ? Maybe 
the MX8MP_* prefix isn't necessary ?

Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25

Posted by Daniel Baluta 3 weeks, 2 days ago

On 3/13/26 18:44, Marek Vasut wrote:
> On 3/9/26 7:15 PM, Eduard Bostina wrote:
>> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
>> raw value is written in this register. This makes the code not obvious
>> to read and modify. 


[..]

>>       pinctrl_ptn5150: ptn5150grp {
>>               fsl,pins = <
>> -                     MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25               0x40000000
>> +                     MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25               MX8MP_SION
> Isn't the SION bit at the same bit offset at least since iMX5x ? Maybe
> the MX8MP_* prefix isn't necessary ?
>
Hi Marek,

I think this can be factored out once we finish moving all the configs to symbolic macros.

Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25

Posted by Frank Li 3 weeks, 5 days ago

On Mon, 09 Mar 2026 20:15:23 +0200, Eduard Bostina wrote:
> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
> raw value is written in this register. This makes the code not obvious
> to read and modify.
> 
> Use the MX8MP_SION symbolic macro instead of the magic value to improve
> code readability.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
      commit: 79ab6e297167b6eee7540af315bc5569e42182ee

Best regards,
-- 
Frank Li <Frank.Li@nxp.com>

Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25

Posted by Daniel Baluta 4 weeks, 1 day ago

On Mon, Mar 9, 2026 at 8:20 PM Eduard Bostina <egbostina@gmail.com> wrote:
>
> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
> raw value is written in this register. This makes the code not obvious
> to read and modify.
>
> Use the MX8MP_SION symbolic macro instead of the magic value to improve
> code readability.
>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>


Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>