[PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520

Icenowy Zheng posted 2 patches 1 month ago
[PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Icenowy Zheng 1 month ago
The G and J coefficients provided by T-Head TH1520 manual (which calls
them A and C coefficients and calls H coefficient in the binding as B)
have 1/100 degree Celsius precision (the values are 42.74 and -0.16
respectively), however the binding currently only allows coefficients as
precise as 100 milli-Celsius (1/10 degree Celsius).

Change the multipleOf value of these two coefficients to 10 (in the unit
of milli-Celsius) to satisfy the need of TH1520.

Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Reviewed-by: Drew Fustini <fustini@kernel.org>
---
Changes in v3:
- Added Drew's R-b.
- Fixed some typos in the commit message and slightly reworded the
  precision sentence.

 Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
index 56db2292f062d..7d57c2934a8a1 100644
--- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
+++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
@@ -105,7 +105,7 @@ properties:
       G coefficient for temperature equation.
       Default for series 5 = 60000
       Default for series 6 = 57400
-    multipleOf: 100
+    multipleOf: 10
     minimum: 1000
     $ref: /schemas/types.yaml#/definitions/uint32
 
@@ -131,7 +131,7 @@ properties:
       J coefficient for temperature equation.
       Default for series 5 = -100
       Default for series 6 = 0
-    multipleOf: 100
+    multipleOf: 10
     maximum: 0
     $ref: /schemas/types.yaml#/definitions/int32
 
-- 
2.52.0
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Guenter Roeck 3 weeks, 1 day ago
On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> The G and J coefficients provided by T-Head TH1520 manual (which calls
> them A and C coefficients and calls H coefficient in the binding as B)
> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> respectively), however the binding currently only allows coefficients as
> precise as 100 milli-Celsius (1/10 degree Celsius).
> 
> Change the multipleOf value of these two coefficients to 10 (in the unit
> of milli-Celsius) to satisfy the need of TH1520.
> 
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> Reviewed-by: Drew Fustini <fustini@kernel.org>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Applied.

Thanks,
Guenter
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Drew Fustini 2 weeks, 6 days ago
On Tue, Mar 17, 2026 at 08:55:05AM -0700, Guenter Roeck wrote:
> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > them A and C coefficients and calls H coefficient in the binding as B)
> > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > respectively), however the binding currently only allows coefficients as
> > precise as 100 milli-Celsius (1/10 degree Celsius).
> > 
> > Change the multipleOf value of these two coefficients to 10 (in the unit
> > of milli-Celsius) to satisfy the need of TH1520.
> > 
> > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Applied.
> 
> Thanks,
> Guenter

Hi, what branch is it applied to? I don't see it in next-20260319, so
I'm thinking I should wait on the dts patch.

Thanks,
Drew
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Guenter Roeck 2 weeks, 6 days ago
On 3/19/26 10:05, Drew Fustini wrote:
> On Tue, Mar 17, 2026 at 08:55:05AM -0700, Guenter Roeck wrote:
>> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
>>> The G and J coefficients provided by T-Head TH1520 manual (which calls
>>> them A and C coefficients and calls H coefficient in the binding as B)
>>> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
>>> respectively), however the binding currently only allows coefficients as
>>> precise as 100 milli-Celsius (1/10 degree Celsius).
>>>
>>> Change the multipleOf value of these two coefficients to 10 (in the unit
>>> of milli-Celsius) to satisfy the need of TH1520.
>>>
>>> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
>>> Reviewed-by: Drew Fustini <fustini@kernel.org>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>
>> Applied.
>>
>> Thanks,
>> Guenter
> 
> Hi, what branch is it applied to? I don't see it in next-20260319, so
> I'm thinking I should wait on the dts patch.
> 

Sorry, I forgot to push. It is now in hwmon-next and should show up in
next- in a couple of days.

Guenter
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Conor Dooley 3 weeks, 2 days ago
On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> The G and J coefficients provided by T-Head TH1520 manual (which calls
> them A and C coefficients and calls H coefficient in the binding as B)
> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> respectively), however the binding currently only allows coefficients as
> precise as 100 milli-Celsius (1/10 degree Celsius).
> 
> Change the multipleOf value of these two coefficients to 10 (in the unit
> of milli-Celsius) to satisfy the need of TH1520.
> 
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> Reviewed-by: Drew Fustini <fustini@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Drew Fustini 3 weeks, 4 days ago
On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> The G and J coefficients provided by T-Head TH1520 manual (which calls
> them A and C coefficients and calls H coefficient in the binding as B)
> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> respectively), however the binding currently only allows coefficients as
> precise as 100 milli-Celsius (1/10 degree Celsius).
> 
> Change the multipleOf value of these two coefficients to 10 (in the unit
> of milli-Celsius) to satisfy the need of TH1520.
> 
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> Reviewed-by: Drew Fustini <fustini@kernel.org>
> ---
> Changes in v3:
> - Added Drew's R-b.
> - Fixed some typos in the commit message and slightly reworded the
>   precision sentence.
> 
>  Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 56db2292f062d..7d57c2934a8a1 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -105,7 +105,7 @@ properties:
>        G coefficient for temperature equation.
>        Default for series 5 = 60000
>        Default for series 6 = 57400
> -    multipleOf: 100
> +    multipleOf: 10
>      minimum: 1000
>      $ref: /schemas/types.yaml#/definitions/uint32
>  
> @@ -131,7 +131,7 @@ properties:
>        J coefficient for temperature equation.
>        Default for series 5 = -100
>        Default for series 6 = 0
> -    multipleOf: 100
> +    multipleOf: 10
>      maximum: 0
>      $ref: /schemas/types.yaml#/definitions/int32
>  
> -- 
> 2.52.0
> 

I have applied this to thead-dt-for-next.

https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19

Thanks,
Drew
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Conor Dooley 3 weeks, 3 days ago
On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > them A and C coefficients and calls H coefficient in the binding as B)
> > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > respectively), however the binding currently only allows coefficients as
> > precise as 100 milli-Celsius (1/10 degree Celsius).
> > 
> > Change the multipleOf value of these two coefficients to 10 (in the unit
> > of milli-Celsius) to satisfy the need of TH1520.
> > 
> > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > ---
> > Changes in v3:
> > - Added Drew's R-b.
> > - Fixed some typos in the commit message and slightly reworded the
> >   precision sentence.
> > 
> >  Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > index 56db2292f062d..7d57c2934a8a1 100644
> > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > @@ -105,7 +105,7 @@ properties:
> >        G coefficient for temperature equation.
> >        Default for series 5 = 60000
> >        Default for series 6 = 57400
> > -    multipleOf: 100
> > +    multipleOf: 10
> >      minimum: 1000
> >      $ref: /schemas/types.yaml#/definitions/uint32
> >  
> > @@ -131,7 +131,7 @@ properties:
> >        J coefficient for temperature equation.
> >        Default for series 5 = -100
> >        Default for series 6 = 0
> > -    multipleOf: 100
> > +    multipleOf: 10
> >      maximum: 0
> >      $ref: /schemas/types.yaml#/definitions/int32
> >  
> > -- 
> > 2.52.0
> > 
> 
> I have applied this to thead-dt-for-next.

That's odd, why is a hwmon binding in your branch?

> https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19

I don't see an ack on it from the relevant maintainer either?
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Guenter Roeck 3 weeks, 2 days ago
On 3/15/26 05:12, Conor Dooley wrote:
> On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
>> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
>>> The G and J coefficients provided by T-Head TH1520 manual (which calls
>>> them A and C coefficients and calls H coefficient in the binding as B)
>>> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
>>> respectively), however the binding currently only allows coefficients as
>>> precise as 100 milli-Celsius (1/10 degree Celsius).
>>>
>>> Change the multipleOf value of these two coefficients to 10 (in the unit
>>> of milli-Celsius) to satisfy the need of TH1520.
>>>
>>> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
>>> Reviewed-by: Drew Fustini <fustini@kernel.org>
>>> ---
>>> Changes in v3:
>>> - Added Drew's R-b.
>>> - Fixed some typos in the commit message and slightly reworded the
>>>    precision sentence.
>>>
>>>   Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>> index 56db2292f062d..7d57c2934a8a1 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>> @@ -105,7 +105,7 @@ properties:
>>>         G coefficient for temperature equation.
>>>         Default for series 5 = 60000
>>>         Default for series 6 = 57400
>>> -    multipleOf: 100
>>> +    multipleOf: 10
>>>       minimum: 1000
>>>       $ref: /schemas/types.yaml#/definitions/uint32
>>>   
>>> @@ -131,7 +131,7 @@ properties:
>>>         J coefficient for temperature equation.
>>>         Default for series 5 = -100
>>>         Default for series 6 = 0
>>> -    multipleOf: 100
>>> +    multipleOf: 10
>>>       maximum: 0
>>>       $ref: /schemas/types.yaml#/definitions/int32
>>>   
>>> -- 
>>> 2.52.0
>>>
>>
>> I have applied this to thead-dt-for-next.
> 
> That's odd, why is a hwmon binding in your branch?
> 
>> https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
> 
> I don't see an ack on it from the relevant maintainer either?

I don't get it either. Normally I am the one to apply hwmon bindings
through the hwmon branch.

Guenter
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Drew Fustini 3 weeks, 2 days ago
On Mon, Mar 16, 2026 at 07:11:37AM -0700, Guenter Roeck wrote:
> On 3/15/26 05:12, Conor Dooley wrote:
> > On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> > > On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > > > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > > > them A and C coefficients and calls H coefficient in the binding as B)
> > > > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > > > respectively), however the binding currently only allows coefficients as
> > > > precise as 100 milli-Celsius (1/10 degree Celsius).
> > > > 
> > > > Change the multipleOf value of these two coefficients to 10 (in the unit
> > > > of milli-Celsius) to satisfy the need of TH1520.
> > > > 
> > > > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > > > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > > > ---
> > > > Changes in v3:
> > > > - Added Drew's R-b.
> > > > - Fixed some typos in the commit message and slightly reworded the
> > > >    precision sentence.
> > > > 
> > > >   Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> > > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > index 56db2292f062d..7d57c2934a8a1 100644
> > > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > @@ -105,7 +105,7 @@ properties:
> > > >         G coefficient for temperature equation.
> > > >         Default for series 5 = 60000
> > > >         Default for series 6 = 57400
> > > > -    multipleOf: 100
> > > > +    multipleOf: 10
> > > >       minimum: 1000
> > > >       $ref: /schemas/types.yaml#/definitions/uint32
> > > > @@ -131,7 +131,7 @@ properties:
> > > >         J coefficient for temperature equation.
> > > >         Default for series 5 = -100
> > > >         Default for series 6 = 0
> > > > -    multipleOf: 100
> > > > +    multipleOf: 10
> > > >       maximum: 0
> > > >       $ref: /schemas/types.yaml#/definitions/int32
> > > > -- 
> > > > 2.52.0
> > > > 
> > > 
> > > I have applied this to thead-dt-for-next.
> > 
> > That's odd, why is a hwmon binding in your branch?
> > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
> > 
> > I don't see an ack on it from the relevant maintainer either?
> 
> I don't get it either. Normally I am the one to apply hwmon bindings
> through the hwmon branch.

Sorry, I should not have done this. I should only be applying dts/dtsi
patches to my thead dt branch.

Thanks,
Drew
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Drew Fustini 3 weeks, 3 days ago
On Sun, Mar 15, 2026 at 12:12:13PM +0000, Conor Dooley wrote:
> On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> > On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > > them A and C coefficients and calls H coefficient in the binding as B)
> > > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > > respectively), however the binding currently only allows coefficients as
> > > precise as 100 milli-Celsius (1/10 degree Celsius).
> > > 
> > > Change the multipleOf value of these two coefficients to 10 (in the unit
> > > of milli-Celsius) to satisfy the need of TH1520.
> > > 
> > > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > > ---
> > > Changes in v3:
> > > - Added Drew's R-b.
> > > - Fixed some typos in the commit message and slightly reworded the
> > >   precision sentence.
> > > 
> > >  Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > index 56db2292f062d..7d57c2934a8a1 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > @@ -105,7 +105,7 @@ properties:
> > >        G coefficient for temperature equation.
> > >        Default for series 5 = 60000
> > >        Default for series 6 = 57400
> > > -    multipleOf: 100
> > > +    multipleOf: 10
> > >      minimum: 1000
> > >      $ref: /schemas/types.yaml#/definitions/uint32
> > >  
> > > @@ -131,7 +131,7 @@ properties:
> > >        J coefficient for temperature equation.
> > >        Default for series 5 = -100
> > >        Default for series 6 = 0
> > > -    multipleOf: 100
> > > +    multipleOf: 10
> > >      maximum: 0
> > >      $ref: /schemas/types.yaml#/definitions/int32
> > >  
> > > -- 
> > > 2.52.0
> > > 
> > 
> > I have applied this to thead-dt-for-next.
> 
> That's odd, why is a hwmon binding in your branch?
> 
> > https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
> 
> I don't see an ack on it from the relevant maintainer either?

Sorry, my mistake, I should not have applied the binding. And you are
right to point out that there was no ack from Guenter or Rahul Tanwar.
I will drop both patches from thead-dt-for-next and wait for agreement
on the binding.

Thanks,
Drew
Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Conor Dooley 3 weeks, 2 days ago
On Sun, Mar 15, 2026 at 08:44:02AM -0700, Drew Fustini wrote:
> On Sun, Mar 15, 2026 at 12:12:13PM +0000, Conor Dooley wrote:
> > On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> > > On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > > > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > > > them A and C coefficients and calls H coefficient in the binding as B)
> > > > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > > > respectively), however the binding currently only allows coefficients as
> > > > precise as 100 milli-Celsius (1/10 degree Celsius).
> > > > 
> > > > Change the multipleOf value of these two coefficients to 10 (in the unit
> > > > of milli-Celsius) to satisfy the need of TH1520.
> > > > 
> > > > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > > > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > > > ---
> > > > Changes in v3:
> > > > - Added Drew's R-b.
> > > > - Fixed some typos in the commit message and slightly reworded the
> > > >   precision sentence.
> > > > 
> > > >  Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > index 56db2292f062d..7d57c2934a8a1 100644
> > > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > @@ -105,7 +105,7 @@ properties:
> > > >        G coefficient for temperature equation.
> > > >        Default for series 5 = 60000
> > > >        Default for series 6 = 57400
> > > > -    multipleOf: 100
> > > > +    multipleOf: 10
> > > >      minimum: 1000
> > > >      $ref: /schemas/types.yaml#/definitions/uint32
> > > >  
> > > > @@ -131,7 +131,7 @@ properties:
> > > >        J coefficient for temperature equation.
> > > >        Default for series 5 = -100
> > > >        Default for series 6 = 0
> > > > -    multipleOf: 100
> > > > +    multipleOf: 10
> > > >      maximum: 0
> > > >      $ref: /schemas/types.yaml#/definitions/int32
> > > >  
> > > > -- 
> > > > 2.52.0
> > > > 
> > > 
> > > I have applied this to thead-dt-for-next.
> > 
> > That's odd, why is a hwmon binding in your branch?
> > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
> > 
> > I don't see an ack on it from the relevant maintainer either?
> 
> Sorry, my mistake, I should not have applied the binding. And you are
> right to point out that there was no ack from Guenter or Rahul Tanwar.

It was Guenter I was thinking of, but there's not one from myself, Rob
or Krzysztof either.

> I will drop both patches from thead-dt-for-next and wait for agreement
> on the binding.
> 
> Thanks,
> Drew


Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Posted by Guenter Roeck 3 weeks, 2 days ago
On 3/16/26 04:09, Conor Dooley wrote:
> On Sun, Mar 15, 2026 at 08:44:02AM -0700, Drew Fustini wrote:
>> On Sun, Mar 15, 2026 at 12:12:13PM +0000, Conor Dooley wrote:
>>> On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
>>>> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
>>>>> The G and J coefficients provided by T-Head TH1520 manual (which calls
>>>>> them A and C coefficients and calls H coefficient in the binding as B)
>>>>> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
>>>>> respectively), however the binding currently only allows coefficients as
>>>>> precise as 100 milli-Celsius (1/10 degree Celsius).
>>>>>
>>>>> Change the multipleOf value of these two coefficients to 10 (in the unit
>>>>> of milli-Celsius) to satisfy the need of TH1520.
>>>>>
>>>>> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
>>>>> Reviewed-by: Drew Fustini <fustini@kernel.org>
>>>>> ---
>>>>> Changes in v3:
>>>>> - Added Drew's R-b.
>>>>> - Fixed some typos in the commit message and slightly reworded the
>>>>>    precision sentence.
>>>>>
>>>>>   Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
>>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>>>> index 56db2292f062d..7d57c2934a8a1 100644
>>>>> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>>>> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>>>> @@ -105,7 +105,7 @@ properties:
>>>>>         G coefficient for temperature equation.
>>>>>         Default for series 5 = 60000
>>>>>         Default for series 6 = 57400
>>>>> -    multipleOf: 100
>>>>> +    multipleOf: 10
>>>>>       minimum: 1000
>>>>>       $ref: /schemas/types.yaml#/definitions/uint32
>>>>>   
>>>>> @@ -131,7 +131,7 @@ properties:
>>>>>         J coefficient for temperature equation.
>>>>>         Default for series 5 = -100
>>>>>         Default for series 6 = 0
>>>>> -    multipleOf: 100
>>>>> +    multipleOf: 10
>>>>>       maximum: 0
>>>>>       $ref: /schemas/types.yaml#/definitions/int32
>>>>>   
>>>>> -- 
>>>>> 2.52.0
>>>>>
>>>>
>>>> I have applied this to thead-dt-for-next.
>>>
>>> That's odd, why is a hwmon binding in your branch?
>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
>>>
>>> I don't see an ack on it from the relevant maintainer either?
>>
>> Sorry, my mistake, I should not have applied the binding. And you are
>> right to point out that there was no ack from Guenter or Rahul Tanwar.
> 
> It was Guenter I was thinking of, but there's not one from myself, Rob
> or Krzysztof either.
> 

... which is why I didn't apply it yet.

Guenter

>> I will drop both patches from thead-dt-for-next and wait for agreement
>> on the binding.
>>
>> Thanks,
>> Drew
> 
>