[PATCH net v4 3/5] selftests: net: rename pmtu.sh to pmtu-test.sh

Aleksei Oladko posted 5 patches 1 month ago
There is a newer version of this series
[PATCH net v4 3/5] selftests: net: rename pmtu.sh to pmtu-test.sh
Posted by Aleksei Oladko 1 month ago
Rename the pmtu.sh test script to pmtu-test.sh. No functional
changes are made, only the file name is updated.

Signed-off-by: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
---
 tools/testing/selftests/net/Makefile                  | 2 +-
 tools/testing/selftests/net/{pmtu.sh => pmtu-test.sh} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename tools/testing/selftests/net/{pmtu.sh => pmtu-test.sh} (100%)

diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 605c54c0e8a3..8fa6ef771757 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -63,7 +63,7 @@ TEST_PROGS := \
 	netns-name.sh \
 	netns-sysctl.sh \
 	nl_netdev.py \
-	pmtu.sh \
+	pmtu-test.sh \
 	psock_snd.sh \
 	reuseaddr_ports_exhausted.sh \
 	reuseport_addr_any.sh \
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu-test.sh
similarity index 100%
rename from tools/testing/selftests/net/pmtu.sh
rename to tools/testing/selftests/net/pmtu-test.sh
-- 
2.43.0
Re: [PATCH net v4 3/5] selftests: net: rename pmtu.sh to pmtu-test.sh
Posted by Jakub Kicinski 4 weeks ago
On Mon,  9 Mar 2026 15:20:11 +0000 Aleksei Oladko wrote:
> Rename the pmtu.sh test script to pmtu-test.sh. No functional
> changes are made, only the file name is updated.

Please try to fix the test ?
Re: [PATCH net v4 3/5] selftests: net: rename pmtu.sh to pmtu-test.sh
Posted by Aleksei Oladko 3 weeks, 3 days ago
In v2 
(https://lore.kernel.org/linux-kselftest/f7t1pj9v8h7.fsf@redhat.com/T/#m80f10ade0ba8963ac6b09b8aba07163cb3e4cf59), 
I was asked to rename the main script for tracking purposes. Should I 
proceed with this setup?

On 3/12/26 4:10 AM, Jakub Kicinski wrote:
> On Mon,  9 Mar 2026 15:20:11 +0000 Aleksei Oladko wrote:
>> Rename the pmtu.sh test script to pmtu-test.sh. No functional
>> changes are made, only the file name is updated.
> Please try to fix the test ?
Re: [PATCH net v4 3/5] selftests: net: rename pmtu.sh to pmtu-test.sh
Posted by Stefano Brivio 3 weeks, 2 days ago
On Sun, 15 Mar 2026 20:25:31 +0100
Aleksei Oladko <aleksey.oladko@virtuozzo.com> wrote:

> In v2 
> (https://lore.kernel.org/linux-kselftest/f7t1pj9v8h7.fsf@redhat.com/T/#m80f10ade0ba8963ac6b09b8aba07163cb3e4cf59), 
> I was asked to rename the main script for tracking purposes. Should I 
> proceed with this setup?

Ah, sorry, I missed Jakub's comment as it came just before Aaron Cc'ed
me (that's the Message-ID above).

I didn't consider that when I suggested to keep the current pmtu.sh as
pmtu.sh instead (this seems to be missing from your quote). Never mind
then!

-- 
Stefano
Re: [PATCH net v4 3/5] selftests: net: rename pmtu.sh to pmtu-test.sh
Posted by Jakub Kicinski 4 weeks ago
On Wed, 11 Mar 2026 20:10:57 -0700 Jakub Kicinski wrote:
> On Mon,  9 Mar 2026 15:20:11 +0000 Aleksei Oladko wrote:
> > Rename the pmtu.sh test script to pmtu-test.sh. No functional
> > changes are made, only the file name is updated.  
> 
> Please try to fix the test ?

BTW IIRC there's a way to make the runner run every test in a new netns.
But personally I'm not sure whether that should free us from making the
tests not break the host, probably not..
Re: [PATCH net v4 3/5] selftests: net: rename pmtu.sh to pmtu-test.sh
Posted by Stefano Brivio 4 weeks, 1 day ago
Nit, only in case this needs a re-spin for whatever reason:

On Mon,  9 Mar 2026 15:20:11 +0000
Aleksei Oladko <aleksey.oladko@virtuozzo.com> wrote:

> Rename the pmtu.sh test script to pmtu-test.sh. No functional
> changes are made, only the file name is updated.

I don't think pmtu-test.sh is very descriptive. I think leaving it as
pmtu.sh and having the new pmtu.sh named pmtu_run.sh would be more
self-explanatory. But it's not a strong preference either way.

> Signed-off-by: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
> ---
>  tools/testing/selftests/net/Makefile                  | 2 +-
>  tools/testing/selftests/net/{pmtu.sh => pmtu-test.sh} | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename tools/testing/selftests/net/{pmtu.sh => pmtu-test.sh} (100%)
> 
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 605c54c0e8a3..8fa6ef771757 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -63,7 +63,7 @@ TEST_PROGS := \
>  	netns-name.sh \
>  	netns-sysctl.sh \
>  	nl_netdev.py \
> -	pmtu.sh \
> +	pmtu-test.sh \
>  	psock_snd.sh \
>  	reuseaddr_ports_exhausted.sh \
>  	reuseport_addr_any.sh \
> diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu-test.sh
> similarity index 100%
> rename from tools/testing/selftests/net/pmtu.sh
> rename to tools/testing/selftests/net/pmtu-test.sh

-- 
Stefano