Convert Cavium ThunderX GPIO text based device tree
node to YAML schema format, ensuring validation and
consistency across Device Tree.

Signed-off-by: Shi Hao <i.shihao.999@gmail.com>
---
 .../gpio/cavium-thunder-8890-gpio.yaml        | 52 +++++++++++++++++++
 .../bindings/gpio/gpio-thunderx.txt           | 27 ----------
 2 files changed, 52 insertions(+), 27 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml
 delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-thunderx.txt

diff --git a/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml b/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml
new file mode 100644
index 000000000000..16d7c347f913
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/cavium-thunder-8890-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cavium ThunderX GPIO controller
+
+description: |
+  Device Tree binding for the GPIO controller found in
+  Cavium ThunderX and OCTEON-TX SoCs.
+
+maintainers:
+  - Linus Walleij <linusw@kernel.org>
+  - Rob Herring <robh@kernel.org>
+
+properties:
+  compatible:
+    enum:
+      - cavium,thunder-8890-gpio
+
+  reg:
+    maxItems: 1
+
+  gpio-controller: true
+
+  "#gpio-cells":
+    const: 2
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+    const: 2
+
+required:
+  - compatible
+  - reg
+  - gpio-controller
+  - '#gpio-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    gpio_6_0: gpio@6,0 {
+      compatible = "cavium,thunder-8890-gpio";
+      reg = <0x3000 0x100>; /*  DEVFN = 0x30 (6:0) */
+      gpio-controller;
+      #gpio-cells = <2>;
+      interrupt-controller;
+      #interrupt-cells = <2>;
+    };
diff --git a/Documentation/devicetree/bindings/gpio/gpio-thunderx.txt b/Documentation/devicetree/bindings/gpio/gpio-thunderx.txt
deleted file mode 100644
index 3f883ae29d11..000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-thunderx.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-Cavium ThunderX/OCTEON-TX GPIO controller bindings
-
-Required Properties:
-- reg: The controller bus address.
-- gpio-controller: Marks the device node as a GPIO controller.
-- #gpio-cells: Must be 2.
-  - First cell is the GPIO pin number relative to the controller.
-  - Second cell is a standard generic flag bitfield as described in gpio.txt.
-
-Optional Properties:
-- compatible: "cavium,thunder-8890-gpio", unused as PCI driver binding is used.
-- interrupt-controller: Marks the device node as an interrupt controller.
-- #interrupt-cells: Must be present and have value of 2 if
-                    "interrupt-controller" is present.
-  - First cell is the GPIO pin number relative to the controller.
-  - Second cell is triggering flags as defined in interrupts.txt.
-
-Example:
-
-gpio_6_0: gpio@6,0 {
-	compatible = "cavium,thunder-8890-gpio";
-	reg = <0x3000 0 0 0 0>; /*  DEVFN = 0x30 (6:0) */
-	gpio-controller;
-	#gpio-cells = <2>;
-	interrupt-controller;
-	#interrupt-cells = <2>;
-};
--
2.53.0

On 09/03/2026 09:22, Shi Hao wrote:
> Convert Cavium ThunderX GPIO text based device tree
> node to YAML schema format, ensuring validation and
> consistency across Device Tree.
> 
> Signed-off-by: Shi Hao <i.shihao.999@gmail.com>
> ---
>  .../gpio/cavium-thunder-8890-gpio.yaml        | 52 +++++++++++++++++++
>  .../bindings/gpio/gpio-thunderx.txt           | 27 ----------
>  2 files changed, 52 insertions(+), 27 deletions(-)

Also same mistakes here, no checkpatch.

There were no follow ups, no comments from your side. Do you read the
replies people give you?

Best regards,
Krzysztof

On Mon, Mar 09, 2026 at 01:52:52PM +0530, Shi Hao wrote:
> Convert Cavium ThunderX GPIO text based device tree
> node to YAML schema format, ensuring validation and
> consistency across Device Tree.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Is this part of some LFX/GSoC program and thus should be first reviewed
by your mentors?

> 
> Signed-off-by: Shi Hao <i.shihao.999@gmail.com>
> ---
>  .../gpio/cavium-thunder-8890-gpio.yaml        | 52 +++++++++++++++++++
>  .../bindings/gpio/gpio-thunderx.txt           | 27 ----------
>  2 files changed, 52 insertions(+), 27 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml

Filename based on compatible,

>  delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-thunderx.txt
> 
> diff --git a/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml b/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml
> new file mode 100644
> index 000000000000..16d7c347f913
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/cavium-thunder-8890-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cavium ThunderX GPIO controller
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  Device Tree binding for the GPIO controller found in

s/Device Tree binding for// because we do not need description of DT
binding that it is a DT binding.

> +  Cavium ThunderX and OCTEON-TX SoCs.
> +
> +maintainers:
> +  - Linus Walleij <linusw@kernel.org>
> +  - Rob Herring <robh@kernel.org>

You cannot have here subsystem maintainers. This needs platform or
driver maintainers.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - cavium,thunder-8890-gpio
> +
> +  reg:
> +    maxItems: 1
> +
> +  gpio-controller: true
> +
> +  "#gpio-cells":
> +    const: 2
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - '#gpio-cells'

Use consistent quotes, either ' or "

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    gpio_6_0: gpio@6,0 {
> +      compatible = "cavium,thunder-8890-gpio";
> +      reg = <0x3000 0x100>; /*  DEVFN = 0x30 (6:0) */

I have doubts this was checked with W=1.

Best regards,
Krzysztof

On 10/03/2026 10:40, Krzysztof Kozlowski wrote:
> On Mon, Mar 09, 2026 at 01:52:52PM +0530, Shi Hao wrote:
>> Convert Cavium ThunderX GPIO text based device tree
>> node to YAML schema format, ensuring validation and
>> consistency across Device Tree.
> 
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 
> Is this part of some LFX/GSoC program and thus should be first reviewed
> by your mentors?

I see GSoC:
https://lore.kernel.org/all/aapjuiq0JSVWfmWA@fedora/

so which mentors reviewed this patch?

One more thing - subject: there is no YAML here. Please read submitting
patches in DT dir.

Best regards,
Krzysztof