This series mostly ports the fixes that were made over the years to the
sc8280xp drivers to the sc8180x ones. (With apologies to everyone for
somewhat stealing the commit messages in places :D)
The most pressing issue this resolves is s2idle exit on the Surface Pro X
being slow and breaking NVMe:
nvme 0002:01:00.0: Unable to change power state from D3cold to D0, device inaccessible
xhci-hcd xhci-hcd.0.auto: xHC error in resume, USBSTS 0x401, Reinit
usb usb1: root hub lost power or was reset
usb usb2: root hub lost power or was reset
nvme nvme0: controller is down; will reset: CSTS=0xffffffff, PCI_STATUS read failed (134)
nvme nvme0: Does your device have a faulty power saving mode enabled?
nvme nvme0: Try "nvme_core.default_ps_max_latency_us=0 pcie_aspm=off pcie_port_pm=off" and report a bug
nvme 0002:01:00.0: Unable to change power state from D3cold to D0, device inaccessible
Hopefully it also contributes towards improving power usage eventually..
One thing I'm left wondering about is 8d114b94fc39 ("clk: qcom:
gcc-sc8280xp: use collapse-voting for PCIe GDSCs"), not sure if it
applies and if it does, where I'd find the values. (Downstream dtsi for
sdmshrike, which is the closest SoC that the msm kernel supports AFAIK,
was my only reference and it doesn't seem to have anything related.)
And 9410fb940114 ("clk: qcom: gcc-sc8280xp: use phy-mux clock for PCIe")
.. we don't have the _src clocks for PCIe defined at all here (o.0)
BTW there's also a dispcc patch I sent as an RFC but probably
should've been part of this series:
https://lore.kernel.org/all/20260307111801.631060-1-val@packett.cool/
Thanks,
~val
Val Packett (7):
dt-bindings: clock: qcom,gcc-sc8180x: Add missing GDSCs
clk: qcom: gcc-sc8180x: Add missing GDSCs
clk: qcom: gcc-sc8180x: Use retention for USB power domains
clk: qcom: gcc-sc8180x: Use retention for PCIe power domains
clk: qcom: gcc-sc8180x: Add missing GDSC flags
clk: qcom: gcc-sc8180x: Add runtime PM
clk: qcom: camcc-sc8180x: Disable always-on clocks on probe failure
drivers/clk/qcom/camcc-sc8180x.c | 14 ++-
drivers/clk/qcom/gcc-sc8180x.c | 112 +++++++++++++++----
include/dt-bindings/clock/qcom,gcc-sc8180x.h | 5 +
3 files changed, 109 insertions(+), 22 deletions(-)
--
2.52.0