The "raising min_free_kbytes" pr_info message in
set_recommended_min_free_kbytes() and the "min_free_kbytes is not
updated to" pr_warn in calculate_min_free_kbytes() can spam the
kernel log when called repeatedly.
Switch the pr_info in set_recommended_min_free_kbytes() and the
pr_warn in calculate_min_free_kbytes() to their _ratelimited variants
to prevent the log spam for this message.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
mm/khugepaged.c | 4 ++--
mm/page_alloc.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 56a41c21b44c9..d44d463ccfd3e 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -2671,8 +2671,8 @@ void set_recommended_min_free_kbytes(void)
if (recommended_min > min_free_kbytes) {
if (user_min_free_kbytes >= 0)
- pr_info("raising min_free_kbytes from %d to %lu to help transparent hugepage allocations\n",
- min_free_kbytes, recommended_min);
+ pr_info_ratelimited("raising min_free_kbytes from %d to %lu to help transparent hugepage allocations\n",
+ min_free_kbytes, recommended_min);
min_free_kbytes = recommended_min;
}
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2d4b6f1a554ed..c840c886807bf 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6553,8 +6553,8 @@ void calculate_min_free_kbytes(void)
if (new_min_free_kbytes > user_min_free_kbytes)
min_free_kbytes = clamp(new_min_free_kbytes, 128, 262144);
else
- pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
- new_min_free_kbytes, user_min_free_kbytes);
+ pr_warn_ratelimited("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
+ new_min_free_kbytes, user_min_free_kbytes);
}
--
2.47.3
On 3/9/26 7:07 PM, Breno Leitao wrote: > The "raising min_free_kbytes" pr_info message in > set_recommended_min_free_kbytes() and the "min_free_kbytes is not > updated to" pr_warn in calculate_min_free_kbytes() can spam the > kernel log when called repeatedly. > > Switch the pr_info in set_recommended_min_free_kbytes() and the > pr_warn in calculate_min_free_kbytes() to their _ratelimited variants > to prevent the log spam for this message. > > Signed-off-by: Breno Leitao <leitao@debian.org> > --- LGTM. Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
On 3/9/26 12:07, Breno Leitao wrote: > The "raising min_free_kbytes" pr_info message in > set_recommended_min_free_kbytes() and the "min_free_kbytes is not > updated to" pr_warn in calculate_min_free_kbytes() can spam the > kernel log when called repeatedly. > > Switch the pr_info in set_recommended_min_free_kbytes() and the > pr_warn in calculate_min_free_kbytes() to their _ratelimited variants > to prevent the log spam for this message. > > Signed-off-by: Breno Leitao <leitao@debian.org> > --- Acked-by: David Hildenbrand (Arm) <david@kernel.org> -- Cheers, David
-cc old mail +cc new one :) [it'll take a while for this to propagate I know]
On Mon, Mar 09, 2026 at 04:07:33AM -0700, Breno Leitao wrote:
> The "raising min_free_kbytes" pr_info message in
> set_recommended_min_free_kbytes() and the "min_free_kbytes is not
> updated to" pr_warn in calculate_min_free_kbytes() can spam the
> kernel log when called repeatedly.
>
> Switch the pr_info in set_recommended_min_free_kbytes() and the
> pr_warn in calculate_min_free_kbytes() to their _ratelimited variants
> to prevent the log spam for this message.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
LGTM, so:
Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
> ---
> mm/khugepaged.c | 4 ++--
> mm/page_alloc.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 56a41c21b44c9..d44d463ccfd3e 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2671,8 +2671,8 @@ void set_recommended_min_free_kbytes(void)
>
> if (recommended_min > min_free_kbytes) {
> if (user_min_free_kbytes >= 0)
> - pr_info("raising min_free_kbytes from %d to %lu to help transparent hugepage allocations\n",
> - min_free_kbytes, recommended_min);
> + pr_info_ratelimited("raising min_free_kbytes from %d to %lu to help transparent hugepage allocations\n",
> + min_free_kbytes, recommended_min);
>
> min_free_kbytes = recommended_min;
> }
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 2d4b6f1a554ed..c840c886807bf 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6553,8 +6553,8 @@ void calculate_min_free_kbytes(void)
> if (new_min_free_kbytes > user_min_free_kbytes)
> min_free_kbytes = clamp(new_min_free_kbytes, 128, 262144);
> else
> - pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
> - new_min_free_kbytes, user_min_free_kbytes);
> + pr_warn_ratelimited("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
> + new_min_free_kbytes, user_min_free_kbytes);
>
> }
>
>
> --
> 2.47.3
>
© 2016 - 2026 Red Hat, Inc.