From: Hasun Park <hasunpark@gmail.com>
Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
machine driver.
Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
platform-specific jack/DMIC quirk path is selected.
Signed-off-by: Hasun Park <hasunpark@gmail.com>
---
sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
index c30ccf23005a..d22b71e3fd2d 100644
--- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
+++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
@@ -111,6 +111,14 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
},
.driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
},
+ {
+ .callback = soc_sdw_quirk_cb,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
+ },
+ .driver_data = (void *)(RT711_JD1 | ASOC_SDW_ACP_DMIC),
+ },
{}
};
--
2.53.0On 08/03/26 20:46, hasunpark@gmail.com wrote:
> [You don't often get email from hasunpark@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Hasun Park <hasunpark@gmail.com>
>
> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
> machine driver.
>
> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
> platform-specific jack/DMIC quirk path is selected.
As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
>
> Signed-off-by: Hasun Park <hasunpark@gmail.com>
> ---
> sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> index c30ccf23005a..d22b71e3fd2d 100644
> --- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> @@ -111,6 +111,14 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
> },
> .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
> },
> + {
> + .callback = soc_sdw_quirk_cb,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
> + },
> + .driver_data = (void *)(RT711_JD1 | ASOC_SDW_ACP_DMIC),
> + },
> {}
> };
>
> --
> 2.53.0
>
On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote: > On 08/03/26 20:46, hasunpark@gmail.com wrote: > > From: Hasun Park <hasunpark@gmail.com> > > Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy > > machine driver. > > Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the > > platform-specific jack/DMIC quirk path is selected. > As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case? > If you are using RT721 (UAJ + DMIC combination) below quirk is not required. Presumably nothing stops the system integrator wiring a DMIC directly to the SoC even if the CODEC can also use it? It doesn't seem an obviously silly configuration.
On 11/03/26 22:51, Mark Brown wrote: > On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote: >> On 08/03/26 20:46, hasunpark@gmail.com wrote: >>> From: Hasun Park <hasunpark@gmail.com> >>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy >>> machine driver. >>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the >>> platform-specific jack/DMIC quirk path is selected. >> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case? >> If you are using RT721 (UAJ + DMIC combination) below quirk is not required. > Presumably nothing stops the system integrator wiring a DMIC directly to > the SoC even if the CODEC can also use it? It doesn't seem an obviously > silly configuration. On this platform Soundwire Codec RT721 already comes up with DMIC endpoint. As per our understanding current soundwire topology points to use RT721 + TI codecs. ACP DMIC is not being used. If we want to use ACP PDM DMIC where DMIC's are connected to SOC and routed to ACP PDM controller instead of Soundwire Codec (Which supports DMIC path), then ACP_PDM_DMIC quirk should be enabled.
On 11/03/26 23:02, Mukunda,Vijendar wrote: > On 11/03/26 22:51, Mark Brown wrote: >> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote: >>> On 08/03/26 20:46, hasunpark@gmail.com wrote: >>>> From: Hasun Park <hasunpark@gmail.com> >>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy >>>> machine driver. >>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the >>>> platform-specific jack/DMIC quirk path is selected. >>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case? >>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required. >> Presumably nothing stops the system integrator wiring a DMIC directly to >> the SoC even if the CODEC can also use it? It doesn't seem an obviously >> silly configuration. > On this platform Soundwire Codec RT721 already comes up with DMIC > endpoint. As per our understanding current soundwire topology points to > use RT721 + TI codecs. ACP DMIC is not being used. > If we want to use ACP PDM DMIC where DMIC's are connected to SOC and > routed to ACP PDM controller instead of Soundwire Codec (Which supports > DMIC path), then ACP_PDM_DMIC quirk should be enabled. We have cross-checked hw configuration. This platform uses DMIC connected to Soundwire codec(ALC721). This patch should be dropped. > >
>On 11/03/26 23:02, Mukunda,Vijendar wrote: >> On 11/03/26 22:51, Mark Brown wrote: >>> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote: >>>> On 08/03/26 20:46, hasunpark@gmail.com wrote: >>>>> From: Hasun Park <hasunpark@gmail.com> >>>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy >>>>> machine driver. >>>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the >>>>> platform-specific jack/DMIC quirk path is selected. >>>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case? >>>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required. >>> Presumably nothing stops the system integrator wiring a DMIC directly to >>> the SoC even if the CODEC can also use it? It doesn't seem an obviously >>> silly configuration. >> On this platform Soundwire Codec RT721 already comes up with DMIC >> endpoint. As per our understanding current soundwire topology points to >> use RT721 + TI codecs. ACP DMIC is not being used. >> If we want to use ACP PDM DMIC where DMIC's are connected to SOC and >> routed to ACP PDM controller instead of Soundwire Codec (Which supports >> DMIC path), then ACP_PDM_DMIC quirk should be enabled. > >We have cross-checked hw configuration. This platform uses DMIC connected >to Soundwire codec(ALC721). This patch should be dropped. Thanks for double-checking the hw configs. I'm not sure to drop this patch because when i test it dmic only works when i add quirk and enable BE link to ACP. But one thing i have to update is both jack and dmic both works fine with ASOC_SDW_ACP_DMIC not RT711_JD1|ASOC_SDW_ACP_DMIC.
On 16/03/26 21:16, Hasun Park wrote: >> On 11/03/26 23:02, Mukunda,Vijendar wrote: >>> On 11/03/26 22:51, Mark Brown wrote: >>>> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote: >>>>> On 08/03/26 20:46, hasunpark@gmail.com wrote: >>>>>> From: Hasun Park <hasunpark@gmail.com> >>>>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy >>>>>> machine driver. >>>>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the >>>>>> platform-specific jack/DMIC quirk path is selected. >>>>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case? >>>>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required. >>>> Presumably nothing stops the system integrator wiring a DMIC directly to >>>> the SoC even if the CODEC can also use it? It doesn't seem an obviously >>>> silly configuration. >>> On this platform Soundwire Codec RT721 already comes up with DMIC >>> endpoint. As per our understanding current soundwire topology points to >>> use RT721 + TI codecs. ACP DMIC is not being used. >>> If we want to use ACP PDM DMIC where DMIC's are connected to SOC and >>> routed to ACP PDM controller instead of Soundwire Codec (Which supports >>> DMIC path), then ACP_PDM_DMIC quirk should be enabled. >> We have cross-checked hw configuration. This platform uses DMIC connected >> to Soundwire codec(ALC721). This patch should be dropped. > Thanks for double-checking the hw configs. > > I'm not sure to drop this patch because when i test it dmic only works when i add quirk and enable BE link to ACP. > > But one thing i have to update is both jack and dmic both works fine with ASOC_SDW_ACP_DMIC not RT711_JD1|ASOC_SDW_ACP_DMIC. Hi Park, There is a confusion. We don't have a platform to cross-check. Could you please double confirm, when you record audio stream from UI, which capture PCM device being used ? Or else you can do command line testing using arecord and confirm the pcm device. As per our CE team, the platform you have mentioned uses different hardware configuration. Could you please double confirm exact model details? Share us dmidecode and acpidump. Share us aplay -l and arecord -l listing.
On 17/03/26 09:30, Mukunda,Vijendar wrote: > On 16/03/26 21:16, Hasun Park wrote: >>> On 11/03/26 23:02, Mukunda,Vijendar wrote: >>>> On 11/03/26 22:51, Mark Brown wrote: >>>>> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote: >>>>>> On 08/03/26 20:46, hasunpark@gmail.com wrote: >>>>>>> From: Hasun Park <hasunpark@gmail.com> >>>>>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy >>>>>>> machine driver. >>>>>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the >>>>>>> platform-specific jack/DMIC quirk path is selected. >>>>>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case? >>>>>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required. >>>>> Presumably nothing stops the system integrator wiring a DMIC directly to >>>>> the SoC even if the CODEC can also use it? It doesn't seem an obviously >>>>> silly configuration. >>>> On this platform Soundwire Codec RT721 already comes up with DMIC >>>> endpoint. As per our understanding current soundwire topology points to >>>> use RT721 + TI codecs. ACP DMIC is not being used. >>>> If we want to use ACP PDM DMIC where DMIC's are connected to SOC and >>>> routed to ACP PDM controller instead of Soundwire Codec (Which supports >>>> DMIC path), then ACP_PDM_DMIC quirk should be enabled. >>> We have cross-checked hw configuration. This platform uses DMIC connected >>> to Soundwire codec(ALC721). This patch should be dropped. >> Thanks for double-checking the hw configs. >> >> I'm not sure to drop this patch because when i test it dmic only works when i add quirk and enable BE link to ACP. >> >> But one thing i have to update is both jack and dmic both works fine with ASOC_SDW_ACP_DMIC not RT711_JD1|ASOC_SDW_ACP_DMIC. > Hi Park, There is a confusion. We don't have a platform to cross-check. Could > you please double confirm, > when you record audio stream from UI, which capture PCM device being used ? Or > else you can do > command line testing using arecord and confirm the pcm device. > > As per our CE team, the platform you have mentioned uses different hardware > configuration. > Could you please double confirm exact model details? Share us dmidecode and > acpidump. > Share us aplay -l and arecord -l listing. Got the confirmation on hw configuration being used for this ASUS platform from our CE team. ACP PDM DMIC being used for this platform. > >
Sorry I'm late. I was just about to start working on your request. Is there anything else you need me to check? Let me know if there's anything else. Best Regards.
On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote: > We have cross-checked hw configuration. This platform uses DMIC connected > to Soundwire codec(ALC721). This patch should be dropped. Thanks for duble checking. I already sent my PR for this -rc, I'll take the other two patches once -rc4 is out all being well.
On 3/12/26 9:06 PM, Mark Brown wrote: > On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote: > >> We have cross-checked hw configuration. This platform uses DMIC connected >> to Soundwire codec(ALC721). This patch should be dropped. > > Thanks for duble checking. I already sent my PR for this -rc, I'll take > the other two patches once -rc4 is out all being well. Hi Mark, should these patches be cc-ed to stable? As it stands, I don't think stable kernels will pick this up. -- Regards, Eric
On Sun, Mar 15, 2026 at 08:20:00PM +0000, Eric Naim wrote: > On 3/12/26 9:06 PM, Mark Brown wrote: > > On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote: > > Thanks for duble checking. I already sent my PR for this -rc, I'll take > > the other two patches once -rc4 is out all being well. > should these patches be cc-ed to stable? As it stands, I don't think stable kernels will pick this up. Feel free to raise it with the stable people if they don't pick them up. I gave up on tagging things since their automated selection of patches picks up vastly more than I would ever select.
On 3/15/2026 6:53 PM, Mark Brown wrote: > On Sun, Mar 15, 2026 at 08:20:00PM +0000, Eric Naim wrote: >> On 3/12/26 9:06 PM, Mark Brown wrote: >>> On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote: > >>> Thanks for duble checking. I already sent my PR for this -rc, I'll take >>> the other two patches once -rc4 is out all being well. > >> should these patches be cc-ed to stable? As it stands, I don't think stable kernels will pick this up. > > Feel free to raise it with the stable people if they don't pick them up. > I gave up on tagging things since their automated selection of patches > picks up vastly more than I would ever select. Eric, Hold horses on this one. Vijendar confirmed the hardware design and this patch is wrong [1]. Let's not get it out to stable. https://lore.kernel.org/linux-sound/a7e7e79d-c839-4a76-8a2a-f3422d2cc089@amd.com/ [1]
On 3/16/26 10:30 AM, Mario Limonciello wrote: > > > On 3/15/2026 6:53 PM, Mark Brown wrote: >> On Sun, Mar 15, 2026 at 08:20:00PM +0000, Eric Naim wrote: >>> On 3/12/26 9:06 PM, Mark Brown wrote: >>>> On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote: >> >>>> Thanks for duble checking. I already sent my PR for this -rc, I'll take >>>> the other two patches once -rc4 is out all being well. >> >>> should these patches be cc-ed to stable? As it stands, I don't think stable kernels will pick this up. >> >> Feel free to raise it with the stable people if they don't pick them up. >> I gave up on tagging things since their automated selection of patches >> picks up vastly more than I would ever select. > > Eric, > > Hold horses on this one. Vijendar confirmed the hardware design and this patch is wrong [1]. Let's not get it out to stable. > > https://lore.kernel.org/linux-sound/a7e7e79d-c839-4a76-8a2a-f3422d2cc089@amd.com/ [1] Wasn't that specifically referring to patch 3/3? There weren't any comments from the second patch and the first patch was also accepted (begrudgingly). Please correct me if I'm wrong. -- Regards, Eric
Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
machine driver.
Set driver_data to ASOC_SDW_ACP_DMIC for this board so the
platform-specific DMIC quirk path is selected.
Changes in v2:
- drop RT711_JD1 since only DMIC needs quirk
Signed-off-by: Hasun Park <hasunpark@gmail.com>
---
sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
index c30ccf23005a..6388cd7cb28e 100644
--- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
+++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
@@ -111,6 +111,14 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
},
.driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
},
+ {
+ .callback = soc_sdw_quirk_cb,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
+ },
+ .driver_data = (void *)(ASOC_SDW_ACP_DMIC),
+ },
{}
};
--
2.53.0On Fri, 20 Mar 2026 01:33:21 +0900, Hasun Park wrote:
> ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.0
Thanks!
[1/1] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine
https://git.kernel.org/broonie/sound/c/2594196f4e3b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
On Fri, Mar 20, 2026 at 01:33:21AM +0900, Hasun Park wrote: > Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy > machine driver. > > Set driver_data to ASOC_SDW_ACP_DMIC for this board so the > platform-specific DMIC quirk path is selected. > > Changes in v2: > - drop RT711_JD1 since only DMIC needs quirk Changelogs like this should go... > Signed-off-by: Hasun Park <hasunpark@gmail.com> > --- ...after the --- here so that they can be automatically removed by tools. Don't worry about it here, just something to be aware of for future submissions.
© 2016 - 2026 Red Hat, Inc.