For some devices it makes more sense to just redefine reserved-memory,
for example on the ASUS ROG Phone 3 it is completely different with the
exception of hyp_mem, xbl_aop_mem, cmd_db and smem_mem.

Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index c7dffa440074..3298c36c3e55 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -763,7 +763,7 @@ opp-120000000 {
 		};
 	};
 
-	reserved-memory {
+	reserved_memory: reserved-memory {
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;

-- 
2.53.0

On Sun, Mar 08, 2026 at 08:40:38PM +0000, Alexander Koskovich wrote:
> For some devices it makes more sense to just redefine reserved-memory,
> for example on the ASUS ROG Phone 3 it is completely different with the
> exception of hyp_mem, xbl_aop_mem, cmd_db and smem_mem.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-

Same comment as before. This makes no sense as its own patch.

Best regards,
Krzysztof

On 09/03/2026 09:00, Krzysztof Kozlowski wrote:
> On Sun, Mar 08, 2026 at 08:40:38PM +0000, Alexander Koskovich wrote:
>> For some devices it makes more sense to just redefine reserved-memory,
>> for example on the ASUS ROG Phone 3 it is completely different with the
>> exception of hyp_mem, xbl_aop_mem, cmd_db and smem_mem.
>>
>> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> 
> Same comment as before. This makes no sense as its own patch.

And this is v2, not v1!

Best regards,
Krzysztof

On Monday, March 9th, 2026 at 4:00 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 09/03/2026 09:00, Krzysztof Kozlowski wrote:
> > On Sun, Mar 08, 2026 at 08:40:38PM +0000, Alexander Koskovich wrote:
> >> For some devices it makes more sense to just redefine reserved-memory,
> >> for example on the ASUS ROG Phone 3 it is completely different with the
> >> exception of hyp_mem, xbl_aop_mem, cmd_db and smem_mem.
> >>
> >> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> >> ---
> >>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> >
> > Same comment as before. This makes no sense as its own patch.
> 
> And this is v2, not v1!

Are you saying it should be fully included in the ROG 3 patch instead of being a separate change? Can just include into v2 of the ROG 3 series when I resubmit later if that's the case.

Oops on the version, should I increment version of a patch if the contents themselves haven't changed? Or is it just for any resend of a patch, version should be incremented?

> 
> Best regards,
> Krzysztof
> 

Thanks,
Alex

On 3/9/26 9:08 AM, Alexander Koskovich wrote:
> 
> On Monday, March 9th, 2026 at 4:00 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>> On 09/03/2026 09:00, Krzysztof Kozlowski wrote:
>>> On Sun, Mar 08, 2026 at 08:40:38PM +0000, Alexander Koskovich wrote:
>>>> For some devices it makes more sense to just redefine reserved-memory,
>>>> for example on the ASUS ROG Phone 3 it is completely different with the
>>>> exception of hyp_mem, xbl_aop_mem, cmd_db and smem_mem.
>>>>
>>>> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
>>>> ---
>>>>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
>>>
>>> Same comment as before. This makes no sense as its own patch.
>>
>> And this is v2, not v1!
> 
> Are you saying it should be fully included in the ROG 3 patch instead of being a separate change? Can just include into v2 of the ROG 3 series when I resubmit later if that's the case.

Yes

> Oops on the version, should I increment version of a patch if the contents themselves haven't changed? Or is it just for any resend of a patch, version should be incremented?

All patches in a series should have the same version tag, i.e. it's the
'series version'

Konrad