usb: typec: qcom: Add shared USBIN VBUS detection via GPIO

[PATCH RFC 1/2] dt-bindings: usb: qcom,pmic-typec: Document vbus-detect-gpios property

Posted by Alexander Koskovich 1 month ago

Add the optional vbus-detect-gpios property for devices where the PMIC's
built-in VBUS detection is unreliable.

Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
 Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
index 6d3fa2bc9cee..f45bf3e34c03 100644
--- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
@@ -78,6 +78,12 @@ properties:
       - const: msg-rx-discarded
       - const: fr-swap
 
+  vbus-detect-gpios:
+    maxItems: 1
+    description:
+      GPIO used to detect VBUS presence when the PMIC's built-in VBUS
+      detection is unreliable.
+
   vdd-vbus-supply:
     description: VBUS power supply.
 

-- 
2.53.0

Re: [PATCH RFC 1/2] dt-bindings: usb: qcom,pmic-typec: Document vbus-detect-gpios property

Posted by Dmitry Baryshkov 4 weeks ago

On Sun, Mar 08, 2026 at 11:20:27PM +0000, Alexander Koskovich wrote:
> Add the optional vbus-detect-gpios property for devices where the PMIC's
> built-in VBUS detection is unreliable.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
>  Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> index 6d3fa2bc9cee..f45bf3e34c03 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> @@ -78,6 +78,12 @@ properties:
>        - const: msg-rx-discarded
>        - const: fr-swap
>  
> +  vbus-detect-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO used to detect VBUS presence when the PMIC's built-in VBUS
> +      detection is unreliable.

Can we use vbus-gpios from the usb-connector instead?

> +
>    vdd-vbus-supply:
>      description: VBUS power supply.
>  
> 
> -- 
> 2.53.0
> 
> 

-- 
With best wishes
Dmitry

Re: [PATCH RFC 1/2] dt-bindings: usb: qcom,pmic-typec: Document vbus-detect-gpios property

Posted by Alexander Koskovich 4 weeks ago

On Wednesday, March 11th, 2026 at 10:34 PM, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:

> On Sun, Mar 08, 2026 at 11:20:27PM +0000, Alexander Koskovich wrote:
> > Add the optional vbus-detect-gpios property for devices where the PMIC's
> > built-in VBUS detection is unreliable.
> >
> > Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> > ---
> >  Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> > index 6d3fa2bc9cee..f45bf3e34c03 100644
> > --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> > +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> > @@ -78,6 +78,12 @@ properties:
> >        - const: msg-rx-discarded
> >        - const: fr-swap
> >
> > +  vbus-detect-gpios:
> > +    maxItems: 1
> > +    description:
> > +      GPIO used to detect VBUS presence when the PMIC's built-in VBUS
> > +      detection is unreliable.
> 
> Can we use vbus-gpios from the usb-connector instead?

Didn't see that! Yes definitely, will update v2 to use that instead.

> 
> > +
> >    vdd-vbus-supply:
> >      description: VBUS power supply.
> >
> >
> > --
> > 2.53.0
> >
> >
> 
> --
> With best wishes
> Dmitry
> 

Thanks,
Alex

Re: [PATCH RFC 1/2] dt-bindings: usb: qcom,pmic-typec: Document vbus-detect-gpios property

Posted by Bryan O'Donoghue 4 weeks ago

On 08/03/2026 23:20, Alexander Koskovich wrote:
> +  vbus-detect-gpios:

Should this be plural ?

arch/arm64/boot/dts/qcom/apq8096-db820c.dts:		pinctrl-0 = 
<&usb2_vbus_det_gpio>;
arch/arm64/boot/dts/qcom/apq8096-db820c.dts:		pinctrl-0 = 
<&usb3_vbus_det_gpio>;
arch/arm64/boot/dts/qcom/apq8096-db820c.dts:	usb3_vbus_det_gpio: 
pm8996-gpio22-state {
arch/arm64/boot/dts/qcom/apq8096-db820c.dts:	usb2_vbus_det_gpio: 
pmi8996-gpio6-state {

Seems a minor point

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

---
bod

Re: [PATCH RFC 1/2] dt-bindings: usb: qcom,pmic-typec: Document vbus-detect-gpios property

Posted by Konrad Dybcio 3 weeks, 3 days ago

On 3/12/26 12:02 AM, Bryan O'Donoghue wrote:
> On 08/03/2026 23:20, Alexander Koskovich wrote:
>> +  vbus-detect-gpios:
> 
> Should this be plural ?

Yes

e.g.

Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml

Konrad