Add bindings for Wacom W9002 and two Wacom W9007 variants which can be
found in tablets.
Co-developed-by: Ferass El Hafidi <funderscore@postmarketos.org>
Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
Signed-off-by: Hendrik Noack <hendrik-noack@gmx.de>
---
.../input/touchscreen/wacom,w9007a-lt03.yaml | 86 +++++++++++++++++++
1 file changed, 86 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,w9007a-lt03.yaml
diff --git a/Documentation/devicetree/bindings/input/touchscreen/wacom,w9007a-lt03.yaml b/Documentation/devicetree/bindings/input/touchscreen/wacom,w9007a-lt03.yaml
new file mode 100644
index 000000000000..feb87f5db39d
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/wacom,w9007a-lt03.yaml
@@ -0,0 +1,86 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/touchscreen/wacom,w9007a-lt03.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Wacom W9000-series penabled I2C touchscreen
+
+maintainers:
+ - Hendrik Noack <hendrik-noack@gmx.de>
+
+description: |
+ The W9000-series are penabled touchscreen controllers by Wacom.
+
+ The firmware of chips between devices can differ and with it also
+ how the chips behaves.
+
+allOf:
+ - $ref: touchscreen.yaml#
+
+properties:
+ compatible:
+ enum:
+ - wacom,w9002
+ - wacom,w9007a-lt03
+ - wacom,w9007a-v1
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ vdd-supply:
+ description:
+ Optional regulator for the VDD digital voltage.
+
+ flash-mode-gpios:
+ maxItems: 1
+ description:
+ Optional GPIO specifier for the touchscreen's flash-mode pin.
+
+ pen-inserted-gpios:
+ maxItems: 1
+ description:
+ Optional GPIO specifier for the touchscreen's pen-insert pin.
+
+ reset-gpios:
+ maxItems: 1
+ description:
+ Optional GPIO specifier for the touchscreen's reset pin.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - vdd-supply
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ digitizer@56 {
+ compatible = "wacom,w9007a-lt03";
+ reg = <0x56>;
+ interrupt-parent = <&gpd1>;
+ interrupts = <1 IRQ_TYPE_EDGE_RISING>;
+
+ vdd-supply = <&stylus_reg>;
+
+ flash-mode-gpios = <&gpd1 3 GPIO_ACTIVE_HIGH>;
+ pen-inserted-gpios = <&gpx0 0 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&gpx0 1 GPIO_ACTIVE_LOW>;
+
+ touchscreen-x-mm = <216>;
+ touchscreen-y-mm = <135>;
+ touchscreen-inverted-x;
+ };
+ };
--
2.43.0Hi Hendrik, On Sat, Mar 07, 2026 at 07:15:32PM +0100, Hendrik Noack wrote: > Add bindings for Wacom W9002 and two Wacom W9007 variants which can be > found in tablets. > > Co-developed-by: Ferass El Hafidi <funderscore@postmarketos.org> > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> > Signed-off-by: Hendrik Noack <hendrik-noack@gmx.de> > --- > .../input/touchscreen/wacom,w9007a-lt03.yaml | 86 +++++++++++++++++++ > 1 file changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,w9007a-lt03.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/wacom,w9007a-lt03.yaml b/Documentation/devicetree/bindings/input/touchscreen/wacom,w9007a-lt03.yaml > new file mode 100644 > index 000000000000..feb87f5db39d > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/wacom,w9007a-lt03.yaml > @@ -0,0 +1,86 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/wacom,w9007a-lt03.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Wacom W9000-series penabled I2C touchscreen > + > +maintainers: > + - Hendrik Noack <hendrik-noack@gmx.de> > + > +description: | > + The W9000-series are penabled touchscreen controllers by Wacom. > + > + The firmware of chips between devices can differ and with it also > + how the chips behaves. > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - wacom,w9002 > + - wacom,w9007a-lt03 > + - wacom,w9007a-v1 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: > + description: > + Optional regulator for the VDD digital voltage. > + > + flash-mode-gpios: > + maxItems: 1 > + description: > + Optional GPIO specifier for the touchscreen's flash-mode pin. > + > + pen-inserted-gpios: > + maxItems: 1 > + description: > + Optional GPIO specifier for the touchscreen's pen-insert pin. Looking at this again this has nothing to do with the W9000 touchscreen controller. The behavior is applicable to any device with a touchscreen and a pen. Rather this is a generic functionality/policy to put the pen interface in low power mode when it is put away. I think this should be done by userspace through combination to listening to the SW_PEN_INSERTED events (via gpio-keys driver) and toggling "inhibit" on the touchscreen device. Thanks. -- Dmitry
On 07/03/2026 19:15, Hendrik Noack wrote: > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: > + description: > + Optional regulator for the VDD digital voltage. Drop "Optional regulator for" Also, vdd is mandatory, not optional. How device can work without supply? > + > + flash-mode-gpios: > + maxItems: 1 > + description: > + Optional GPIO specifier for the touchscreen's flash-mode pin. Drop "Optional GPIO specifier for the". Don't repeat constraints in free form text. Schema tells what is optional or what is not. This also cannot be anything else than GPIO specifier, so repeating obvious is not making it more readable. > + > + pen-inserted-gpios: > + maxItems: 1 > + description: > + Optional GPIO specifier for the touchscreen's pen-insert pin. Drop "Optional GPIO specifier for the". > + > + reset-gpios: > + maxItems: 1 > + description: > + Optional GPIO specifier for the touchscreen's reset pin. Drop description completely. Redundant. It cannot be anything else than reset pin. > + > +required: > + - compatible > + - reg > + - interrupts > + - vdd-supply Best regards, Krzysztof
On Sat, Mar 07, 2026 at 07:15:32PM +0100, Hendrik Noack wrote: > Add bindings for Wacom W9002 and two Wacom W9007 variants which can be > found in tablets. > > Co-developed-by: Ferass El Hafidi <funderscore@postmarketos.org> > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> > Signed-off-by: Hendrik Noack <hendrik-noack@gmx.de> > --- You received review and instruction what to do. Did you read it? Your way of organizing your work makes it difficult for us. Look, try yourself: b4 diff '20260307181557.66927-2-hendrik-noack@gmx.de' Checking for older revisions Grabbing search results from lore.kernel.org Added from v3: 2 patches --- Analyzing 16 messages in the thread Preparing fake-am for v3: dt-bindings: Input: Add Wacom W9000-series penabled touchscreens ERROR: v3 series incomplete; unable to create a fake-am range --- Could not create fake-am range for lower series v3 Best regards, Krzysztof
Hello Krzysztof, 08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@kernel.org>: > You received review and instruction what to do. Did you read it? I read the review of Dmitry and incorporated it into this version. > Your way of organizing your work makes it difficult for us. Look, try > yourself: > > b4 diff '20260307181557.66927-2-hendrik-noack@gmx.de' > Checking for older revisions > Grabbing search results from lore.kernel.org > Added from v3: 2 patches > --- > Analyzing 16 messages in the thread > Preparing fake-am for v3: dt-bindings: Input: Add Wacom W9000-series penabled touchscreens > ERROR: v3 series incomplete; unable to create a fake-am range > --- > Could not create fake-am range for lower series v3 > > > Best regards, > Krzysztof The b4 diff error might happen because git didn't add the v3 label on the 2/2 patch of v3. First running b4 diff on v3 with: b4 diff '20251205152858.14415-2-hendrik-noack@gmx.de resulted in a working diff on v4: b4 diff '20260307181557.66927-2-hendrik-noack@gmx.de' Grabbing thread from lore.kernel.org/all/20260307181557.66927-2-hendrik-noack@gmx.de/t.mbox.gz Checking for older revisions Grabbing search results from lore.kernel.org Added from v3: 2 patches --- Analyzing 17 messages in the thread --- Diffing v3 and v4 Running: git range-diff c371c3410e81..d467d6770a1b 0bfd1357fb44..1c9f51e8b572 --- ... Best regards, Hendrik
On 09/03/2026 13:54, Hendrik Noack wrote: > Hello Krzysztof, > > 08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@kernel.org>: > >> You received review and instruction what to do. Did you read it? > > I read the review of Dmitry and incorporated it into this version. So you ignored my email completely or it did not reach you (it is on lore.kernel.org though)? Best regards, Krzysztof
Hello Krzysztof, 09.03.2026 13:56:41 Krzysztof Kozlowski <krzk@kernel.org>: > On 09/03/2026 13:54, Hendrik Noack wrote: >> Hello Krzysztof, >> >> 08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@kernel.org>: >> >>> You received review and instruction what to do. Did you read it? >> >> I read the review of Dmitry and incorporated it into this version. > > So you ignored my email completely or it did not reach you (it is on > lore.kernel.org though)? I don't know what email you mean. You gave reviews on my first verison, which I already incorporated in v2 and then gave a review-by on v2, which I also added on v3, but now dropped, because I added a property to the DT binding. Best regards, Hendrik
On 09/03/2026 14:12, Hendrik Noack wrote: > Hello Krzysztof, > > 09.03.2026 13:56:41 Krzysztof Kozlowski <krzk@kernel.org>: > >> On 09/03/2026 13:54, Hendrik Noack wrote: >>> Hello Krzysztof, >>> >>> 08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@kernel.org>: >>> >>>> You received review and instruction what to do. Did you read it? >>> >>> I read the review of Dmitry and incorporated it into this version. >> >> So you ignored my email completely or it did not reach you (it is on >> lore.kernel.org though)? > > I don't know what email you mean. You gave reviews on my first verison, which I already incorporated in v2 and then gave a review-by on v2, which I also added on v3, but now dropped, because I added a property to the DT binding. The instruction I gave you when giving review. Please wrap your emails to standard email style, so reading will be easier. Best regards, Krzysztof
Hi Krzysztof & Hendrik, On Mon, 09 Mar 2026 13:21, Krzysztof Kozlowski <krzk@kernel.org> wrote: >On 09/03/2026 14:12, Hendrik Noack wrote: >> Hello Krzysztof, >> >> 09.03.2026 13:56:41 Krzysztof Kozlowski <krzk@kernel.org>: >> >>> On 09/03/2026 13:54, Hendrik Noack wrote: >>>> Hello Krzysztof, >>>> >>>> 08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@kernel.org>: >>>> >>>>> You received review and instruction what to do. Did you read it? >>>> >>>> I read the review of Dmitry and incorporated it into this version. >>> >>> So you ignored my email completely or it did not reach you (it is on >>> lore.kernel.org though)? >> >> I don't know what email you mean. You gave reviews on my first verison, >> which I already incorporated in v2 and then gave a review-by on v2, >> which I also added on v3, but now dropped, because I added a property >> to the DT binding. > >The instruction I gave you when giving review. If you gave review on the v3 dt-bindings, I can't find it on lore: https://lore.kernel.org/all/20251205152858.14415-2-hendrik-noack@gmx.de/ On v2 you gave a R-b to the dt-bindings along with some instructions: https://lore.kernel.org/all/2bf9dbd4-351e-4a79-9fcf-e41c5273d0be@kernel.org/ which were followed from what I can tell; your R-b was retained on v3, but dropped on this revision (v4) because of new properties being added (new `reset-gpio` property, technically also `wacom,w9002` compatible but my understanding is new compatibles don't really matter much), as your email said "Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions [...] unless patch changed (e.g. new properties added to the DT bindings)". You also gave an in-depth review on the actual driver itself on v1: https://lore.kernel.org/all/20251028-funky-rose-rook-3ccab5@kuoka/ Best regards, Ferass > >Please wrap your emails to standard email style, so reading will be easier. > >Best regards, >Krzysztof
On 10/03/2026 17:50, Ferass El Hafidi wrote: > Hi Krzysztof & Hendrik, > > On Mon, 09 Mar 2026 13:21, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> On 09/03/2026 14:12, Hendrik Noack wrote: >>> Hello Krzysztof, >>> >>> 09.03.2026 13:56:41 Krzysztof Kozlowski <krzk@kernel.org>: >>> >>>> On 09/03/2026 13:54, Hendrik Noack wrote: >>>>> Hello Krzysztof, >>>>> >>>>> 08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@kernel.org>: >>>>> >>>>>> You received review and instruction what to do. Did you read it? >>>>> >>>>> I read the review of Dmitry and incorporated it into this version. >>>> >>>> So you ignored my email completely or it did not reach you (it is on >>>> lore.kernel.org though)? >>> >>> I don't know what email you mean. You gave reviews on my first verison, >>> which I already incorporated in v2 and then gave a review-by on v2, >>> which I also added on v3, but now dropped, because I added a property >>> to the DT binding. >> >> The instruction I gave you when giving review. > > If you gave review on the v3 dt-bindings, I can't find it on lore: > https://lore.kernel.org/all/20251205152858.14415-2-hendrik-noack@gmx.de/ > > On v2 you gave a R-b to the dt-bindings along with some instructions: > https://lore.kernel.org/all/2bf9dbd4-351e-4a79-9fcf-e41c5273d0be@kernel.org/ > which were followed from what I can tell; your R-b was retained on v3, > but dropped on this revision (v4) because of new properties being added > (new `reset-gpio` property, technically also `wacom,w9002` compatible > but my understanding is new compatibles don't really matter much), as > your email said "Please add Acked-by/Reviewed-by/Tested-by tags when > posting new versions [...] unless patch changed (e.g. new properties > added to the DT bindings)". Thanks. I also provided the link further explaining what one has to do if one ever decide to drop the review. Dropping it silently is for me rather sign I should ignore this patchset to avoid wasting time of lost reviews. Best regards, Krzysztof
On Tue, 10 Mar 2026 16:55, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>On 10/03/2026 17:50, Ferass El Hafidi wrote:
>> Hi Krzysztof & Hendrik,
>>
>> On Mon, 09 Mar 2026 13:21, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> On 09/03/2026 14:12, Hendrik Noack wrote:
>>>> Hello Krzysztof,
>>>>
>>>> 09.03.2026 13:56:41 Krzysztof Kozlowski <krzk@kernel.org>:
>>>>
>>>>> On 09/03/2026 13:54, Hendrik Noack wrote:
>>>>>> Hello Krzysztof,
>>>>>>
>>>>>> 08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@kernel.org>:
>>>>>>
>>>>>>> You received review and instruction what to do. Did you read it?
>>>>>>
>>>>>> I read the review of Dmitry and incorporated it into this version.
>>>>>
>>>>> So you ignored my email completely or it did not reach you (it is on
>>>>> lore.kernel.org though)?
>>>>
>>>> I don't know what email you mean. You gave reviews on my first verison,
>>>> which I already incorporated in v2 and then gave a review-by on v2,
>>>> which I also added on v3, but now dropped, because I added a property
>>>> to the DT binding.
>>>
>>> The instruction I gave you when giving review.
>>
>> If you gave review on the v3 dt-bindings, I can't find it on lore:
>> https://lore.kernel.org/all/20251205152858.14415-2-hendrik-noack@gmx.de/
>>
>> On v2 you gave a R-b to the dt-bindings along with some instructions:
>> https://lore.kernel.org/all/2bf9dbd4-351e-4a79-9fcf-e41c5273d0be@kernel.org/
>> which were followed from what I can tell; your R-b was retained on v3,
>> but dropped on this revision (v4) because of new properties being added
>> (new `reset-gpio` property, technically also `wacom,w9002` compatible
>> but my understanding is new compatibles don't really matter much), as
>> your email said "Please add Acked-by/Reviewed-by/Tested-by tags when
>> posting new versions [...] unless patch changed (e.g. new properties
>> added to the DT bindings)".
>
>Thanks. I also provided the link further explaining what one has to do
>if one ever decide to drop the review.
Assuming you're talking about that R-b dropping should be mentioned in
the cover letter, that was probably just overlooked.
>
>Dropping it silently is for me rather sign I should ignore this patchset
>to avoid wasting time of lost reviews.
That was most likely not the intent, I think your feedback is valuable.
Best regards,
Ferass
[PS: I see you left some review after your last email, thank you for
your time and sorry for the inconvenience.]
>
>Best regards,
>Krzysztof
© 2016 - 2026 Red Hat, Inc.