[PATCH] staging: media: atomisp: circbuf: Fix leading space indentation

Giorgi Tchankvetadze posted 1 patch 1 month ago
.../staging/media/atomisp/pci/base/circbuf/src/circbuf.c    | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] staging: media: atomisp: circbuf: Fix leading space indentation
Posted by Giorgi Tchankvetadze 1 month ago
Fix lines starting with spaces instead of tabs to comply with 
kernel coding style.

No functional change.

Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
 .../staging/media/atomisp/pci/base/circbuf/src/circbuf.c    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
index cb34d0b5abb5..9aa10cb1185d 100644
--- a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
+++ b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
@@ -192,9 +192,9 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)
  * Please refer to "ia_css_circbuf.h" for details.
  */
 bool ia_css_circbuf_increase_size(
-    ia_css_circbuf_t *cb,
-    unsigned int sz_delta,
-    ia_css_circbuf_elem_t *elems)
+	ia_css_circbuf_t *cb,
+	unsigned int sz_delta,
+	ia_css_circbuf_elem_t *elems)
 {
 	u8 curr_size;
 	u8 curr_end;
-- 
2.52.0
Re: [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation
Posted by Dan Carpenter 1 month ago
On Sat, Mar 07, 2026 at 03:40:00PM +0400, Giorgi Tchankvetadze wrote:
> Fix lines starting with spaces instead of tabs to comply with 
> kernel coding style.
> 
> No functional change.
> 
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
>  .../staging/media/atomisp/pci/base/circbuf/src/circbuf.c    | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> index cb34d0b5abb5..9aa10cb1185d 100644
> --- a/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> +++ b/drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
> @@ -192,9 +192,9 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)
>   * Please refer to "ia_css_circbuf.h" for details.
>   */
>  bool ia_css_circbuf_increase_size(
> -    ia_css_circbuf_t *cb,
> -    unsigned int sz_delta,
> -    ia_css_circbuf_elem_t *elems)
> +	ia_css_circbuf_t *cb,
> +	unsigned int sz_delta,
> +	ia_css_circbuf_elem_t *elems)

We would normally do it like this:

bool ia_css_circbuf_increase_size(ia_css_circbuf_t *cb, unsigned int sz_delta,
				  ia_css_circbuf_elem_t *elems)

regards,
dan carpenter

>  {
>  	u8 curr_size;
>  	u8 curr_end;
> -- 
> 2.52.0
>
Re: [PATCH] staging: media: atomisp: circbuf: Fix leading space indentation
Posted by Giorgi Tchankvetadze 1 month ago
On Sat, Mar 7, 2026 at 6:33 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:

> We would normally do it like this:
>
> bool ia_css_circbuf_increase_size(ia_css_circbuf_t *cb, unsigned int sz_delta,
>                                   ia_css_circbuf_elem_t *elems)

Thanks for the review, Dan. Sent v2.