[PATCH v3 0/3] iio: accel: convert to guard(mutex)

Rajveer Chaudhari posted 3 patches 1 month ago
There is a newer version of this series
drivers/iio/accel/adxl313_core.c | 15 ++----
drivers/iio/accel/adxl355_core.c | 81 ++++++++++++++------------------
drivers/iio/accel/adxl372.c      | 16 +++----
3 files changed, 45 insertions(+), 67 deletions(-)
[PATCH v3 0/3] iio: accel: convert to guard(mutex)
Posted by Rajveer Chaudhari 1 month ago
This series converts manual mutex_lock/mutex_unlock pairs to
guard(mutex) in three ADXL accelerometer drivers. Each conversion
also simplifies error handling by removing goto labels and
returning directly where possible.

v3: Remove remaining goto labels completely as requested by David Lechner.
    Return directly from functions where ret variable is not needed.
v2: Split into one patch per driver as requested by David Lechner.
    Ensured each conversion also simplifies code flow.

Rajveer Chaudhari (3):
  iio: accel: adxl313: convert to guard(mutex)
  iio: accel: adxl355: convert to guard(mutex)
  iio: accel: adxl372: convert to guard(mutex)

 drivers/iio/accel/adxl313_core.c | 15 ++----
 drivers/iio/accel/adxl355_core.c | 81 ++++++++++++++------------------
 drivers/iio/accel/adxl372.c      | 16 +++----
 3 files changed, 45 insertions(+), 67 deletions(-)

-- 
2.53.0
Re: [PATCH v3 0/3] iio: accel: convert to guard(mutex)
Posted by Jonathan Cameron 1 month ago
On Sat,  7 Mar 2026 15:47:55 +0530
Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com> wrote:

> This series converts manual mutex_lock/mutex_unlock pairs to
> guard(mutex) in three ADXL accelerometer drivers. Each conversion
> also simplifies error handling by removing goto labels and
> returning directly where possible.
> 
> v3: Remove remaining goto labels completely as requested by David Lechner.
>     Return directly from functions where ret variable is not needed.
> v2: Split into one patch per driver as requested by David Lechner.
>     Ensured each conversion also simplifies code flow.
> 
> Rajveer Chaudhari (3):
>   iio: accel: adxl313: convert to guard(mutex)
>   iio: accel: adxl355: convert to guard(mutex)
>   iio: accel: adxl372: convert to guard(mutex)
> 
>  drivers/iio/accel/adxl313_core.c | 15 ++----
>  drivers/iio/accel/adxl355_core.c | 81 ++++++++++++++------------------
>  drivers/iio/accel/adxl372.c      | 16 +++----
>  3 files changed, 45 insertions(+), 67 deletions(-)
> 

Hi Rajveer,

Small process thing.  Please send each new version as a separate email
thread.  It can get very hard to follow when we end up with deeply
nested threads so most areas of the kernel prefer to just associate
them via name of the thread and possibly a link in the cover letter
to the previous version.

Jonathan
Re: [PATCH v3 0/3] iio: accel: convert to guard(mutex)
Posted by Rajveer Chaudhari 1 month ago
Hello Jonathan,

I am sorry for making things confusing, do you want me to re-send V3
on a new separate email thread?
Or I should keep this in mind for future patches.

Thankyou,
Rajveer

On Sat, Mar 7, 2026 at 3:56 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat,  7 Mar 2026 15:47:55 +0530
> Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com> wrote:
>
> > This series converts manual mutex_lock/mutex_unlock pairs to
> > guard(mutex) in three ADXL accelerometer drivers. Each conversion
> > also simplifies error handling by removing goto labels and
> > returning directly where possible.
> >
> > v3: Remove remaining goto labels completely as requested by David Lechner.
> >     Return directly from functions where ret variable is not needed.
> > v2: Split into one patch per driver as requested by David Lechner.
> >     Ensured each conversion also simplifies code flow.
> >
> > Rajveer Chaudhari (3):
> >   iio: accel: adxl313: convert to guard(mutex)
> >   iio: accel: adxl355: convert to guard(mutex)
> >   iio: accel: adxl372: convert to guard(mutex)
> >
> >  drivers/iio/accel/adxl313_core.c | 15 ++----
> >  drivers/iio/accel/adxl355_core.c | 81 ++++++++++++++------------------
> >  drivers/iio/accel/adxl372.c      | 16 +++----
> >  3 files changed, 45 insertions(+), 67 deletions(-)
> >
>
> Hi Rajveer,
>
> Small process thing.  Please send each new version as a separate email
> thread.  It can get very hard to follow when we end up with deeply
> nested threads so most areas of the kernel prefer to just associate
> them via name of the thread and possibly a link in the cover letter
> to the previous version.
>
> Jonathan
Re: [PATCH v3 0/3] iio: accel: convert to guard(mutex)
Posted by Jonathan Cameron 1 month ago
On Sat, 7 Mar 2026 16:03:58 +0530
Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com> wrote:

> Hello Jonathan,
> 
> I am sorry for making things confusing, do you want me to re-send V3
> on a new separate email thread?
> Or I should keep this in mind for future patches.
Keep in mind for future patch sets / v4 of this one

Thanks,

J
> 
> Thankyou,
> Rajveer
> 
> On Sat, Mar 7, 2026 at 3:56 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Sat,  7 Mar 2026 15:47:55 +0530
> > Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com> wrote:
> >  
> > > This series converts manual mutex_lock/mutex_unlock pairs to
> > > guard(mutex) in three ADXL accelerometer drivers. Each conversion
> > > also simplifies error handling by removing goto labels and
> > > returning directly where possible.
> > >
> > > v3: Remove remaining goto labels completely as requested by David Lechner.
> > >     Return directly from functions where ret variable is not needed.
> > > v2: Split into one patch per driver as requested by David Lechner.
> > >     Ensured each conversion also simplifies code flow.
> > >
> > > Rajveer Chaudhari (3):
> > >   iio: accel: adxl313: convert to guard(mutex)
> > >   iio: accel: adxl355: convert to guard(mutex)
> > >   iio: accel: adxl372: convert to guard(mutex)
> > >
> > >  drivers/iio/accel/adxl313_core.c | 15 ++----
> > >  drivers/iio/accel/adxl355_core.c | 81 ++++++++++++++------------------
> > >  drivers/iio/accel/adxl372.c      | 16 +++----
> > >  3 files changed, 45 insertions(+), 67 deletions(-)
> > >  
> >
> > Hi Rajveer,
> >
> > Small process thing.  Please send each new version as a separate email
> > thread.  It can get very hard to follow when we end up with deeply
> > nested threads so most areas of the kernel prefer to just associate
> > them via name of the thread and possibly a link in the cover letter
> > to the previous version.
> >
> > Jonathan