1. Patchew
  2. linux
  3. View series

[PATCH v2] iio: adc: max1363: Reformat enum and array initializers

Giorgi Tchankvetadze posted 1 patch 1 month ago 
drivers/iio/adc/max1363.c | 83 ++++++++++++++++++++-------------------
1 file changed, 43 insertions(+), 40 deletions(-)
[PATCH v2] iio: adc: max1363: Reformat enum and array initializers
Posted by Giorgi Tchankvetadze 1 month ago 
Reformat the device enum so each entry is on its own line and add a
trailing comma to the final enumerator. Also reformat the nearby monitor
speeds array for consistency.

No functional change.

Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
v2:
 - Address review comments from Andy Shevchenko and David Lechner
 - Move all enum entries to separate lines
 - Add trailing comma to final enum entry
 - Reformat max1363_monitor_speeds[] initializer
 
drivers/iio/adc/max1363.c | 83 ++++++++++++++++++++-------------------
 1 file changed, 43 insertions(+), 40 deletions(-)

diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index d35f4487b2f9..207d1e960e21 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -637,48 +637,51 @@ static const enum max1363_modes max11644_mode_list[] = {
 static const struct iio_chan_spec max11646_channels[] = MAX1363_2X_CHANS(10);
 static const struct iio_chan_spec max11644_channels[] = MAX1363_2X_CHANS(12);
 
-enum { max1361,
-       max1362,
-       max1363,
-       max1364,
-       max1036,
-       max1037,
-       max1038,
-       max1039,
-       max1136,
-       max1137,
-       max1138,
-       max1139,
-       max1236,
-       max1237,
-       max1238,
-       max1239,
-       max11600,
-       max11601,
-       max11602,
-       max11603,
-       max11604,
-       max11605,
-       max11606,
-       max11607,
-       max11608,
-       max11609,
-       max11610,
-       max11611,
-       max11612,
-       max11613,
-       max11614,
-       max11615,
-       max11616,
-       max11617,
-       max11644,
-       max11645,
-       max11646,
-       max11647
+enum {
+	max1361,
+	max1362,
+	max1363,
+	max1364,
+	max1036,
+	max1037,
+	max1038,
+	max1039,
+	max1136,
+	max1137,
+	max1138,
+	max1139,
+	max1236,
+	max1237,
+	max1238,
+	max1239,
+	max11600,
+	max11601,
+	max11602,
+	max11603,
+	max11604,
+	max11605,
+	max11606,
+	max11607,
+	max11608,
+	max11609,
+	max11610,
+	max11611,
+	max11612,
+	max11613,
+	max11614,
+	max11615,
+	max11616,
+	max11617,
+	max11644,
+	max11645,
+	max11646,
+	max11647,
 };
 
-static const int max1363_monitor_speeds[] = { 133000, 665000, 33300, 16600,
-					      8300, 4200, 2000, 1000 };
+static const int max1363_monitor_speeds[] = {
+	133000, 665000, 33300, 16600,
+	8300, 4200, 2000, 1000,
+};
 
 static ssize_t max1363_monitor_show_freq(struct device *dev,
 					struct device_attribute *attr,
-- 
2.52.0
Re: [PATCH v2] iio: adc: max1363: Reformat enum and array initializers
Posted by Andy Shevchenko 1 month ago 
On Sat, Mar 07, 2026 at 11:15:56AM +0400, Giorgi Tchankvetadze wrote:
> Reformat the device enum so each entry is on its own line and add a
> trailing comma to the final enumerator. Also reformat the nearby monitor
> speeds array for consistency.
> 
> No functional change.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2] iio: adc: max1363: Reformat enum and array initializers
Posted by Jonathan Cameron 3 weeks, 5 days ago 
On Sun, 8 Mar 2026 22:18:00 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sat, Mar 07, 2026 at 11:15:56AM +0400, Giorgi Tchankvetadze wrote:
> > Reformat the device enum so each entry is on its own line and add a
> > trailing comma to the final enumerator. Also reformat the nearby monitor
> > speeds array for consistency.
> > 
> > No functional change.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
Tah. Added and fresh tree pushed out.
Re: [PATCH v2] iio: adc: max1363: Reformat enum and array initializers
Posted by Jonathan Cameron 1 month ago 
On Sat,  7 Mar 2026 11:15:56 +0400
Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> wrote:

> Reformat the device enum so each entry is on its own line and add a
> trailing comma to the final enumerator. Also reformat the nearby monitor
> speeds array for consistency.
> 
> No functional change.
> 
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Hi Giorgi

Seems like all comments have been addressed and looks good to me so
applied to the testing branch of iio.git.  As normal I'm fine rebasing that
for a few days if anyone wants to provide additional feedback or give
tags etc.

Thanks,

Jonathan

> ---
> v2:
>  - Address review comments from Andy Shevchenko and David Lechner
>  - Move all enum entries to separate lines
>  - Add trailing comma to final enum entry
>  - Reformat max1363_monitor_speeds[] initializer
>  
> drivers/iio/adc/max1363.c | 83 ++++++++++++++++++++-------------------
>  1 file changed, 43 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index d35f4487b2f9..207d1e960e21 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -637,48 +637,51 @@ static const enum max1363_modes max11644_mode_list[] = {
>  static const struct iio_chan_spec max11646_channels[] = MAX1363_2X_CHANS(10);
>  static const struct iio_chan_spec max11644_channels[] = MAX1363_2X_CHANS(12);
>  
> -enum { max1361,
> -       max1362,
> -       max1363,
> -       max1364,
> -       max1036,
> -       max1037,
> -       max1038,
> -       max1039,
> -       max1136,
> -       max1137,
> -       max1138,
> -       max1139,
> -       max1236,
> -       max1237,
> -       max1238,
> -       max1239,
> -       max11600,
> -       max11601,
> -       max11602,
> -       max11603,
> -       max11604,
> -       max11605,
> -       max11606,
> -       max11607,
> -       max11608,
> -       max11609,
> -       max11610,
> -       max11611,
> -       max11612,
> -       max11613,
> -       max11614,
> -       max11615,
> -       max11616,
> -       max11617,
> -       max11644,
> -       max11645,
> -       max11646,
> -       max11647
> +enum {
> +	max1361,
> +	max1362,
> +	max1363,
> +	max1364,
> +	max1036,
> +	max1037,
> +	max1038,
> +	max1039,
> +	max1136,
> +	max1137,
> +	max1138,
> +	max1139,
> +	max1236,
> +	max1237,
> +	max1238,
> +	max1239,
> +	max11600,
> +	max11601,
> +	max11602,
> +	max11603,
> +	max11604,
> +	max11605,
> +	max11606,
> +	max11607,
> +	max11608,
> +	max11609,
> +	max11610,
> +	max11611,
> +	max11612,
> +	max11613,
> +	max11614,
> +	max11615,
> +	max11616,
> +	max11617,
> +	max11644,
> +	max11645,
> +	max11646,
> +	max11647,
>  };
>  
> -static const int max1363_monitor_speeds[] = { 133000, 665000, 33300, 16600,
> -					      8300, 4200, 2000, 1000 };
> +static const int max1363_monitor_speeds[] = {
> +	133000, 665000, 33300, 16600,
> +	8300, 4200, 2000, 1000,
> +};
>  
>  static ssize_t max1363_monitor_show_freq(struct device *dev,
>  					struct device_attribute *attr,

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.