[PATCH 0/3] workqueue: Fix table in wq_dump.py for large number of workqueues

Breno Leitao posted 3 patches 1 month ago
tools/workqueue/wq_dump.py | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
[PATCH 0/3] workqueue: Fix table in wq_dump.py for large number of workqueues
Posted by Breno Leitao 1 month ago
On larger machines (e.g. 316 CPUs, 2 NUMA nodes), the "Unbound
workqueue -> node_nr/max_active" section of wq_dump.py has column
alignment issues.

Values like max_active=2048 exceed the hardcoded minimum field width of 3,
causing the header and data rows to misalign.

This series cleans up the formatting:

 1. Remove the backslash separator from the header

 2. Widen format specifiers for 4-digit values and right-align
    nr/max as a single string

 3. Add "NODE" prefix to all node columns for clarity.
    * Although the original code intentionally only labeled the first column,
      the bare numbers for subsequent nodes create more confusion than they
      help. Labeling all columns makes the output self-explanatory.

Before:
  [          workqueue           \ min max  NODE 0       1     dfl ]
  events_unbound                     8 2048   0/2048   0/  8   0/2048
  netns                              1   1   0/  1   0/  1   0/  1
  async                            1024 1024   0/1024   0/1024   0/1024
  cpuset_migrate_mm                  1   1   0/  1   0/  1   0/  1

After:
  [           workqueue             min  max    NODE 0    NODE 1       dfl ]
  events_unbound                      8 2048    0/2048       0/8    0/2048
  netns                               1    1       0/1       0/1       0/1
  async                            1024 1024    0/1024    0/1024    0/1024
  cpuset_migrate_mm                   1    1       0/1       0/1       0/1

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (3):
      tools/workqueue/wq_dump.py: remove backslash separator from node_nr/max_active header
      tools/workqueue/wq_dump.py: fix column alignment in node_nr/max_active section
      tools/workqueue/wq_dump.py: add NODE prefix to all node columns

 tools/workqueue/wq_dump.py | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)
---
base-commit: 5ee8dbf54602dc340d6235b1d6aa17c0f283f48c
change-id: 20260307-wqdump-33fd85802b92

Best regards,
--  
Breno Leitao <leitao@debian.org>
Re: [PATCH 0/3] workqueue: Fix table in wq_dump.py for large number of workqueues
Posted by Tejun Heo 1 month ago
> Breno Leitao (3):
>   tools/workqueue/wq_dump.py: remove backslash separator from node_nr/max_active header
>   tools/workqueue/wq_dump.py: fix column alignment in node_nr/max_active section
>   tools/workqueue/wq_dump.py: add NODE prefix to all node columns

Applied 1-3 to wq/for-7.1.

Thanks.

--
tejun