Convert Atmel AT91 USB Device Controller (UDC) binding to DT schema.
Changes during conversion:
- Include "atmel,pullup-gpio" and "atmel,matrix" in the properties since
they are required by existing in-tree DTS definitions.
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
.../bindings/usb/atmel,at91rm9200-udc.yaml | 77 ++++++++++++++++++++++
1 file changed, 77 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml b/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml
new file mode 100644
index 000000000000..6961cd5d5d89
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/atmel,at91rm9200-udc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel AT91 USB Device Controller (UDC)
+
+maintainers:
+ - Nicolas Ferre <nicolas.ferre@microchip.com>
+ - Alexandre Belloni <alexandre.belloni@bootlin.com>
+
+description:
+ The Atmel AT91 USB Device Controller provides USB gadget (device-mode)
+ functionality on AT91 SoCs. It requires a peripheral clock and an AHB
+ clock for operation and may optionally control VBUS power through a GPIO.
+
+properties:
+ compatible:
+ enum:
+ - atmel,at91rm9200-udc
+ - atmel,at91sam9260-udc
+ - atmel,at91sam9261-udc
+ - atmel,at91sam9263-udc
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ minItems: 2
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: pclk
+ - const: hclk
+
+ atmel,vbus-gpio:
+ description: GPIO used to enable or control VBUS power for the USB bus.
+ maxItems: 1
+
+ atmel,matrix:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the Atmel bus matrix controller.
+
+ atmel,pullup-gpio:
+ description:
+ GPIO controlling the USB D+ pull-up resistor used to signal device
+ connection to the host.
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/clock/at91.h>
+ #include <dt-bindings/gpio/gpio.h>
+ gadget@fffa4000 {
+ compatible = "atmel,at91rm9200-udc";
+ reg = <0xfffa4000 0x4000>;
+ interrupts = <11 IRQ_TYPE_LEVEL_HIGH 2>;
+ clocks = <&udc_clk>, <&udpck>;
+ clock-names = "pclk", "hclk";
+ atmel,vbus-gpio = <&pioC 5 GPIO_ACTIVE_HIGH>;
+ };
+...
--
2.53.0On Sat, Mar 07, 2026 at 09:16:21AM +0000, Charan Pedumuru wrote: > Convert Atmel AT91 USB Device Controller (UDC) binding to DT schema. > Changes during conversion: > - Include "atmel,pullup-gpio" and "atmel,matrix" in the properties since > they are required by existing in-tree DTS definitions. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com> > --- > .../bindings/usb/atmel,at91rm9200-udc.yaml | 77 ++++++++++++++++++++++ Where is the actual conversion? You are supposed to remove other file for this to be a "convert". > 1 file changed, 77 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml b/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml > new file mode 100644 > index 000000000000..6961cd5d5d89 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/atmel,at91rm9200-udc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel AT91 USB Device Controller (UDC) > + > +maintainers: > + - Nicolas Ferre <nicolas.ferre@microchip.com> > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > + > +description: > + The Atmel AT91 USB Device Controller provides USB gadget (device-mode) > + functionality on AT91 SoCs. It requires a peripheral clock and an AHB > + clock for operation and may optionally control VBUS power through a GPIO. > + > +properties: > + compatible: > + enum: > + - atmel,at91rm9200-udc > + - atmel,at91sam9260-udc > + - atmel,at91sam9261-udc > + - atmel,at91sam9263-udc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 2 Drop > + maxItems: 2 > + > + clock-names: > + items: > + - const: pclk > + - const: hclk > + > + atmel,vbus-gpio: > + description: GPIO used to enable or control VBUS power for the USB bus. > + maxItems: 1 > + > + atmel,matrix: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Phandle to the Atmel bus matrix controller. > + > + atmel,pullup-gpio: > + description: > + GPIO controlling the USB D+ pull-up resistor used to signal device > + connection to the host. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +unevaluatedProperties: false additionalProperties Best regards, Krzysztof
On 08-03-2026 14:57, Krzysztof Kozlowski wrote: > On Sat, Mar 07, 2026 at 09:16:21AM +0000, Charan Pedumuru wrote: >> Convert Atmel AT91 USB Device Controller (UDC) binding to DT schema. >> Changes during conversion: >> - Include "atmel,pullup-gpio" and "atmel,matrix" in the properties since >> they are required by existing in-tree DTS definitions. >> >> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com> >> --- >> .../bindings/usb/atmel,at91rm9200-udc.yaml | 77 ++++++++++++++++++++++ > > Where is the actual conversion? You are supposed to remove other file > for this to be a "convert". > >> 1 file changed, 77 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml b/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml >> new file mode 100644 >> index 000000000000..6961cd5d5d89 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/atmel,at91rm9200-udc.yaml >> @@ -0,0 +1,77 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/usb/atmel,at91rm9200-udc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Atmel AT91 USB Device Controller (UDC) >> + >> +maintainers: >> + - Nicolas Ferre <nicolas.ferre@microchip.com> >> + - Alexandre Belloni <alexandre.belloni@bootlin.com> >> + >> +description: >> + The Atmel AT91 USB Device Controller provides USB gadget (device-mode) >> + functionality on AT91 SoCs. It requires a peripheral clock and an AHB >> + clock for operation and may optionally control VBUS power through a GPIO. >> + >> +properties: >> + compatible: >> + enum: >> + - atmel,at91rm9200-udc >> + - atmel,at91sam9260-udc >> + - atmel,at91sam9261-udc >> + - atmel,at91sam9263-udc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 2 > > Drop Sure. > >> + maxItems: 2 >> + >> + clock-names: >> + items: >> + - const: pclk >> + - const: hclk >> + >> + atmel,vbus-gpio: >> + description: GPIO used to enable or control VBUS power for the USB bus. >> + maxItems: 1 >> + >> + atmel,matrix: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Phandle to the Atmel bus matrix controller. >> + >> + atmel,pullup-gpio: >> + description: >> + GPIO controlling the USB D+ pull-up resistor used to signal device >> + connection to the host. >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + >> +unevaluatedProperties: false > > additionalProperties Okay. > > Best regards, > Krzysztof > -- Best Regards, Charan.
© 2016 - 2026 Red Hat, Inc.