[PATCH v4 6/8] irqchip: add ARCH_S32 dependency to Kconfig

Ciprian Costea posted 8 patches 1 month ago
There is a newer version of this series
[PATCH v4 6/8] irqchip: add ARCH_S32 dependency to Kconfig
Posted by Ciprian Costea 1 month ago
From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>

IMX_IRQSTEER is also used on ARCH_S32, but only requires ARCH_MXC. This
can result in unmet dependencies when compiling strictly for ARCH_S32.
Resolve this by adding ARCH_S32 in the driver's dependencies as an
alternative.

Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
---
 drivers/irqchip/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index f07b00d7fef9..ad32a084afba 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -541,11 +541,11 @@ config CSKY_APB_INTC
 
 config IMX_IRQSTEER
 	bool "i.MX IRQSTEER support"
-	depends on ARCH_MXC || COMPILE_TEST
-	default ARCH_MXC
+	depends on ARCH_MXC || ARCH_S32 || COMPILE_TEST
+	default y if ARCH_MXC || ARCH_S32
 	select IRQ_DOMAIN
 	help
-	  Support for the i.MX IRQSTEER interrupt multiplexer/remapper.
+	  Support for the i.MX and S32 IRQSTEER interrupt multiplexer/remapper.
 
 config IMX_INTMUX
 	bool "i.MX INTMUX support" if COMPILE_TEST
-- 
2.43.0
Re: [PATCH v4 6/8] irqchip: add ARCH_S32 dependency to Kconfig
Posted by Thomas Gleixner 1 month ago
On Fri, Mar 06 2026 at 17:15, Ciprian Costea wrote:

That subject line is useless. It says that it adds a random dependency
to Kconfig, which tells nothing. Subject lines have to be descriptive
and useful on their own w/o the need to decode them through the actual
change log.

Just fold this change into the previous patch which adds the ARCH_S32
support into the driver.

Thanks,

        tglx
Re: [PATCH v4 6/8] irqchip: add ARCH_S32 dependency to Kconfig
Posted by Ciprian Marian Costea 1 month ago
On 3/9/2026 11:27 AM, Thomas Gleixner wrote:
> On Fri, Mar 06 2026 at 17:15, Ciprian Costea wrote:
> 
> That subject line is useless. It says that it adds a random dependency
> to Kconfig, which tells nothing. Subject lines have to be descriptive
> and useful on their own w/o the need to decode them through the actual
> change log.
> 
> Just fold this change into the previous patch which adds the ARCH_S32
> support into the driver.
> 
> Thanks,
> 
>          tglx

Makes sense. Thanks for pointing this out.
Will squash this commit with the irqchip driver changes in V5.

Best Regards,
Ciprian