1. Patchew
  2. linux
  3. View series

[PATCH] iio: adc: max1363: Fix leading space indentation

Giorgi Tchankvetadze posted 1 patch 1 month ago 
drivers/iio/adc/max1363.c | 74 +++++++++++++++++++--------------------
1 file changed, 37 insertions(+), 37 deletions(-)
[PATCH] iio: adc: max1363: Fix leading space indentation
Posted by Giorgi Tchankvetadze 1 month ago 
Fix leading space indentation in the device enum (found by checkpatch).

No functional change.

Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
 drivers/iio/adc/max1363.c | 74 +++++++++++++++++++--------------------
 1 file changed, 37 insertions(+), 37 deletions(-)

diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index d35f4487b2f9..75af10bc37de 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -638,43 +638,43 @@ static const struct iio_chan_spec max11646_channels[] = MAX1363_2X_CHANS(10);
 static const struct iio_chan_spec max11644_channels[] = MAX1363_2X_CHANS(12);
 
 enum { max1361,
-       max1362,
-       max1363,
-       max1364,
-       max1036,
-       max1037,
-       max1038,
-       max1039,
-       max1136,
-       max1137,
-       max1138,
-       max1139,
-       max1236,
-       max1237,
-       max1238,
-       max1239,
-       max11600,
-       max11601,
-       max11602,
-       max11603,
-       max11604,
-       max11605,
-       max11606,
-       max11607,
-       max11608,
-       max11609,
-       max11610,
-       max11611,
-       max11612,
-       max11613,
-       max11614,
-       max11615,
-       max11616,
-       max11617,
-       max11644,
-       max11645,
-       max11646,
-       max11647
+	max1362,
+	max1363,
+	max1364,
+	max1036,
+	max1037,
+	max1038,
+	max1039,
+	max1136,
+	max1137,
+	max1138,
+	max1139,
+	max1236,
+	max1237,
+	max1238,
+	max1239,
+	max11600,
+	max11601,
+	max11602,
+	max11603,
+	max11604,
+	max11605,
+	max11606,
+	max11607,
+	max11608,
+	max11609,
+	max11610,
+	max11611,
+	max11612,
+	max11613,
+	max11614,
+	max11615,
+	max11616,
+	max11617,
+	max11644,
+	max11645,
+	max11646,
+	max11647
 };
 
 static const int max1363_monitor_speeds[] = { 133000, 665000, 33300, 16600,
-- 
2.52.0
Re: [PATCH] iio: adc: max1363: Fix leading space indentation
Posted by David Lechner 1 month ago 
On 3/6/26 7:43 AM, Giorgi Tchankvetadze wrote:
> Fix leading space indentation in the device enum (found by checkpatch).
> 
> No functional change.
> 
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
>  drivers/iio/adc/max1363.c | 74 +++++++++++++++++++--------------------
>  1 file changed, 37 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index d35f4487b2f9..75af10bc37de 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -638,43 +638,43 @@ static const struct iio_chan_spec max11646_channels[] = MAX1363_2X_CHANS(10);
>  static const struct iio_chan_spec max11644_channels[] = MAX1363_2X_CHANS(12);
>  
>  enum { max1361,

We should also move max1361 to a new line if we are cleaning this up.


>  };
>  
>  static const int max1363_monitor_speeds[] = { 133000, 665000, 33300, 16600,


And would be nice to move these values to a new line too to keep the style
consistent.
Re: [PATCH] iio: adc: max1363: Fix leading space indentation
Posted by Giorgi Tchankvetadze 1 month ago 
On Fri, Mar 6, 2026 at 6:40 PM David Lechner <dlechner@baylibre.com> wrote:
> >  enum { max1361,
>
> We should also move max1361 to a new line if we are cleaning this up.
>
>
> >  };
> >
> >  static const int max1363_monitor_speeds[] = { 133000, 665000, 33300, 16600,
>
>
> And would be nice to move these values to a new line too to keep the style
> consistent.
>

Thanks Andy and David for the review.

I've addressed the comments and sent a v2 of the patch.

Giorgi
Re: [PATCH] iio: adc: max1363: Fix leading space indentation
Posted by Andy Shevchenko 1 month ago 
On Fri, Mar 06, 2026 at 05:43:36PM +0400, Giorgi Tchankvetadze wrote:
> Fix leading space indentation in the device enum (found by checkpatch).
> 
> No functional change.

...

>  enum { max1361,

Make this to be split

enum {
	max1361,

> -       max1362,
> -       max1363,
> -       max1364,
> -       max1036,
> -       max1037,
> -       max1038,
> -       max1039,
> -       max1136,
> -       max1137,
> -       max1138,
> -       max1139,
> -       max1236,
> -       max1237,
> -       max1238,
> -       max1239,
> -       max11600,
> -       max11601,
> -       max11602,
> -       max11603,
> -       max11604,
> -       max11605,
> -       max11606,
> -       max11607,
> -       max11608,
> -       max11609,
> -       max11610,
> -       max11611,
> -       max11612,
> -       max11613,
> -       max11614,
> -       max11615,
> -       max11616,
> -       max11617,
> -       max11644,
> -       max11645,
> -       max11646,
> -       max11647
> +	max1362,
> +	max1363,
> +	max1364,
> +	max1036,
> +	max1037,
> +	max1038,
> +	max1039,
> +	max1136,
> +	max1137,
> +	max1138,
> +	max1139,
> +	max1236,
> +	max1237,
> +	max1238,
> +	max1239,
> +	max11600,
> +	max11601,
> +	max11602,
> +	max11603,
> +	max11604,
> +	max11605,
> +	max11606,
> +	max11607,
> +	max11608,
> +	max11609,
> +	max11610,
> +	max11611,
> +	max11612,
> +	max11613,
> +	max11614,
> +	max11615,
> +	max11616,
> +	max11617,
> +	max11644,
> +	max11645,
> +	max11646,
> +	max11647

Add trailing comma as this is not a terminator.

>  };

-- 
With Best Regards,
Andy Shevchenko

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.