[PATCH v2] dt-bindings: display: panel: Document the rotation property

Luca Leonardo Scorcia posted 1 patch 1 month ago
There is a newer version of this series
.../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml  | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH v2] dt-bindings: display: panel: Document the rotation property
Posted by Luca Leonardo Scorcia 1 month ago
The Jadard jd9365da-h3 driver already allows DRM to get the panel orientation
via the device tree rotation property (described in panel-common.yaml),
but it's currently not documented.
Describe it in the driver documentation to fix a dtbs_check error in
Xiaomi Mi Smart Clock x04g, where the panel is landscape-oriented.

Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
---
v2: Review feedback: improved commit message to explain how the rotation
    property is used by the driver and why it's needed in the driver
    documentation.

 .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
index b8783eba3ddc..25024f4a63e1 100644
--- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
@@ -33,9 +33,8 @@ properties:
     description: supply regulator for VCCIO, usually 1.8V
 
   reset-gpios: true
-
   backlight: true
-
+  rotation: true
   port: true
 
 required:
-- 
2.43.0
Re: [PATCH v2] dt-bindings: display: panel: Document the rotation property
Posted by Krzysztof Kozlowski 1 month ago
On Fri, Mar 06, 2026 at 12:44:21PM +0000, Luca Leonardo Scorcia wrote:
> The Jadard jd9365da-h3 driver already allows DRM to get the panel orientation

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> via the device tree rotation property (described in panel-common.yaml),
> but it's currently not documented.
> Describe it in the driver documentation to fix a dtbs_check error in
> Xiaomi Mi Smart Clock x04g, where the panel is landscape-oriented.
> 
> Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
> ---
> v2: Review feedback: improved commit message to explain how the rotation
>     property is used by the driver and why it's needed in the driver
>     documentation.
> 
>  .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml  | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

ONLY after these fixed:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof