Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/xfs/xfs_aops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index f279055fcea0..79ec98c8f299 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -792,7 +792,7 @@ xfs_vm_readahead(
 {
 	struct iomap_read_folio_ctx	ctx = { .rac = rac };
 
-	ctx.ops = xfs_get_iomap_read_ops(rac->mapping),
+	ctx.ops = xfs_get_iomap_read_ops(rac->mapping);
 	iomap_readahead(&xfs_read_iomap_ops, &ctx, NULL);
 }
 
-- 
2.25.1

On Fri, Mar 06, 2026 at 09:48:00AM +0800, Chen Ni wrote:
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.

What tree HEAD did you apply this on?

I can't find where this code exists. I'm assuming you sent it against
some tree other than XFS's tree?

> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  fs/xfs/xfs_aops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index f279055fcea0..79ec98c8f299 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -792,7 +792,7 @@ xfs_vm_readahead(
>  {
>  	struct iomap_read_folio_ctx	ctx = { .rac = rac };
>  
> -	ctx.ops = xfs_get_iomap_read_ops(rac->mapping),
> +	ctx.ops = xfs_get_iomap_read_ops(rac->mapping);
>  	iomap_readahead(&xfs_read_iomap_ops, &ctx, NULL);
>  }
>  
> -- 
> 2.25.1
> 
>

On Tue, Mar 10, 2026 at 09:52:15AM +0100, Carlos Maiolino wrote:
> What tree HEAD did you apply this on?
> 
> I can't find where this code exists. I'm assuming you sent it against
> some tree other than XFS's tree?

Hi Carlos,

You are correct. This patch was based on linux-next commit 7407c0fbfa90,
which is not present in the current XFS tree.

Please disregard.

Best regards,
Chen Ni

On Fri, Mar 06, 2026 at 09:48:00AM +0800, Chen Ni wrote:
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  fs/xfs/xfs_aops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index f279055fcea0..79ec98c8f299 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -792,7 +792,7 @@ xfs_vm_readahead(
>  {
>  	struct iomap_read_folio_ctx	ctx = { .rac = rac };
>  
> -	ctx.ops = xfs_get_iomap_read_ops(rac->mapping),
> +	ctx.ops = xfs_get_iomap_read_ops(rac->mapping);
>  	iomap_readahead(&xfs_read_iomap_ops, &ctx, NULL);
>  }

Yup, looks good.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

>  
> -- 
> 2.25.1
> 
>

-----Original Message-----
From: Chen Ni <nichen@iscas.ac.cn> 
Sent: Friday, March 6, 2026 7:18 AM
To: cem@kernel.org
Cc: linux-xfs@vger.kernel.org; linux-kernel@vger.kernel.org; Chen Ni <nichen@iscas.ac.cn>
Subject: [PATCH] xfs: Convert comma to semicolon

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Acked-by: Souptick Joarder <souptick.joarder@hpe.com>
---
 fs/xfs/xfs_aops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index f279055fcea0..79ec98c8f299 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -792,7 +792,7 @@ xfs_vm_readahead(
 {
 	struct iomap_read_folio_ctx	ctx = { .rac = rac };
 
-	ctx.ops = xfs_get_iomap_read_ops(rac->mapping),
+	ctx.ops = xfs_get_iomap_read_ops(rac->mapping);
 	iomap_readahead(&xfs_read_iomap_ops, &ctx, NULL);  }
 
--
2.25.1