[PATCH v3 2/3] remoteproc: qcom_wcnss_iris: Add support for WCN3610

Kerigan Creighton posted 3 patches 1 month ago
[PATCH v3 2/3] remoteproc: qcom_wcnss_iris: Add support for WCN3610
Posted by Kerigan Creighton 1 month ago
WCN3610 has the same regulator requirements as
WCN3620, so in qcom_wcnss_iris, we can use wcn3620_data.

A separate compatible is needed for WCN3610 because the
wcn36xx driver uses it for chip-specific configuration.
Specifically, it sets BTC (Bluetooth Coexistence) CFGs,
disables ENABLE_DYNAMIC_RA_START_RATE, and disables
STA_POWERSAVE for this specific chip for stable
functionality.

Signed-off-by: Kerigan Creighton <kerigancreighton@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Changes in v2:
 - Move remoteproc compatible string addition to the middle of
   the patch set.
 - Add Reviewed-by Dmitry (thanks!)

Changes in v3:
 - Describe why we need a new compatible in the remoteproc
   patch [Krzysztof].
---
 drivers/remoteproc/qcom_wcnss_iris.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c
index 2b89b4db6c..e58b59355f 100644
--- a/drivers/remoteproc/qcom_wcnss_iris.c
+++ b/drivers/remoteproc/qcom_wcnss_iris.c
@@ -95,6 +95,7 @@ void qcom_iris_disable(struct qcom_iris *iris)
 }
 
 static const struct of_device_id iris_of_match[] = {
+	{ .compatible = "qcom,wcn3610", .data = &wcn3620_data },
 	{ .compatible = "qcom,wcn3620", .data = &wcn3620_data },
 	{ .compatible = "qcom,wcn3660", .data = &wcn3660_data },
 	{ .compatible = "qcom,wcn3660b", .data = &wcn3680_data },
-- 
2.53.0
Re: [PATCH v3 2/3] remoteproc: qcom_wcnss_iris: Add support for WCN3610
Posted by Krzysztof Kozlowski 1 month ago
On 06/03/2026 01:43, Kerigan Creighton wrote:
> WCN3610 has the same regulator requirements as
> WCN3620, so in qcom_wcnss_iris, we can use wcn3620_data.
> 
> A separate compatible is needed for WCN3610 because the
> wcn36xx driver uses it for chip-specific configuration.
> Specifically, it sets BTC (Bluetooth Coexistence) CFGs,
> disables ENABLE_DYNAMIC_RA_START_RATE, and disables
> STA_POWERSAVE for this specific chip for stable
> functionality.

This goes to the binding description where you describe the hardware,
how I asked.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597


Best regards,
Krzysztof