[PATCH v3 00/14] reset: major reset core refactoring

Bartosz Golaszewski posted 14 patches 1 month ago
Documentation/driver-api/reset.rst |   1 -
drivers/reset/core.c               | 503 ++++++++++++++++++++++++-------------
drivers/reset/reset-gpio.c         |  27 +-
include/linux/reset-controller.h   |  21 +-
include/linux/reset.h              |  43 ++--
5 files changed, 382 insertions(+), 213 deletions(-)
[PATCH v3 00/14] reset: major reset core refactoring
Posted by Bartosz Golaszewski 1 month ago
Here is the promised refactoring of the reset core. The main goal of the
series is to make the reset subsystem fwnode-agnostic - meaning it can
work with all kinds of firmware nodes instead of being OF-centric - but
there are some other related changes in here as well. I'm sending it all
out for review to give Phillipp a better picture of the end result but
individual pieces can be picked up earlier if accepted.

The series is logically split into several parts:

Patches 1-5: Several reset-gpio improvements. Most are not very
controversial but I included a reworked version of the patch adding a
firmware device link between the auxiliary reset device and its
consumers.

Patches 6-7: Just general improvements.

Patch 8: Before we support all firmware nodes (even software nodes for
which no devlinks are created) we need to make sure reset drivers can
survive a sudden unbinding of the supplier with consumers still holding
references to the controller. This patch addresses it using SRCU.

Patches 9,10: Rework locking in reset core. Make locking fine-grained
instead of using a single global lock for everything.

Patches 11-14: Make reset core use fwnode as primary source of
device properties and references. Convert reset-gpio to becoming the
first fwnode-agnostic driver.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Changes in v3:
- make kerneldocs for new locks more precise
- in patch 10: rework the release path to fix a race between
  reset_control_get() and reset_control_put()
- in patch 13: in case neither of_node nor fwnode is set: try to get the
  fwnode from rcdev->dev and if that too fails: bail out with -EINVAL
- Link to v2: https://patch.msgid.link/20260223-reset-core-refactor-v2-0-5e5a7289190c@oss.qualcomm.com

Changes in v2:
- fix lock guard usage
- tweak commit messages
- fix potential NULL-pointer dereference
- drop unneeded patch (squash it into another one)
- collect tags
- rebase on top of v7.0-rc1
- Link to v1: https://lore.kernel.org/r/20260105-reset-core-refactor-v1-0-ac443103498d@oss.qualcomm.com

---
Bartosz Golaszewski (14):
      reset: gpio: remove unneeded OF-node put
      reset: gpio: add a devlink between reset-gpio and its consumer
      reset: gpio: simplify fallback device matching
      reset: gpio: remove unneeded auxiliary_set_drvdata()
      reset: warn on reset-gpio release
      reset: fold ida_alloc() into reset_create_gpio_aux_device()
      reset: use lock guards in reset core
      reset: handle removing supplier before consumers
      reset: protect struct reset_controller_dev with its own mutex
      reset: protect struct reset_control with its own mutex
      reset: convert of_reset_control_get_count() to using firmware nodes
      reset: convert the core API to using firmware nodes
      reset: convert reset core to using firmware nodes
      reset: gpio: make the driver fwnode-agnostic

 Documentation/driver-api/reset.rst |   1 -
 drivers/reset/core.c               | 503 ++++++++++++++++++++++++-------------
 drivers/reset/reset-gpio.c         |  27 +-
 include/linux/reset-controller.h   |  21 +-
 include/linux/reset.h              |  43 ++--
 5 files changed, 382 insertions(+), 213 deletions(-)
---
base-commit: 18faab1eb02810f006d269e923fe0964beff42d0
change-id: 20251222-reset-core-refactor-5fad7197cbcf

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Re: [PATCH v3 00/14] reset: major reset core refactoring
Posted by Philipp Zabel 1 month ago
On Fr, 2026-03-06 at 18:22 +0100, Bartosz Golaszewski wrote:
> Here is the promised refactoring of the reset core. The main goal of the
> series is to make the reset subsystem fwnode-agnostic - meaning it can
> work with all kinds of firmware nodes instead of being OF-centric - but
> there are some other related changes in here as well. I'm sending it all
> out for review to give Phillipp a better picture of the end result but
> individual pieces can be picked up earlier if accepted.
[...]
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Applied to reset/next, thanks!

[01/14] reset: gpio: remove unneeded OF-node put
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=fe3da77f2f94
[02/14] reset: gpio: add a devlink between reset-gpio and its consumer
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=a9b95ce36de4
[03/14] reset: gpio: simplify fallback device matching
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=ad9d28e68f4f
[04/14] reset: gpio: remove unneeded auxiliary_set_drvdata()
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=1acd46638408
[05/14] reset: warn on reset-gpio release
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=20adbf3b8f5c
[06/14] reset: fold ida_alloc() into reset_create_gpio_aux_device()
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=6703784ab9a8
[07/14] reset: use lock guards in reset core
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=1f10008aff71
[08/14] reset: handle removing supplier before consumers
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=78ebbff6d1a0
[09/14] reset: protect struct reset_controller_dev with its own mutex
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=44a0acb2caca
[10/14] reset: protect struct reset_control with its own mutex
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=8c91302a29bc
[11/14] reset: convert of_reset_control_get_count() to using firmware nodes
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=9d52054a4fc3
[12/14] reset: convert the core API to using firmware nodes
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=ba8dbbb14b7e
[13/14] reset: convert reset core to using firmware nodes
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=9035073d0ef1
[14/14] reset: gpio: make the driver fwnode-agnostic
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=faaad5006e58

regards
Philipp
Re: [PATCH v3 00/14] reset: major reset core refactoring
Posted by Bartosz Golaszewski 1 month ago
On Mon, Mar 9, 2026 at 10:25 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> On Fr, 2026-03-06 at 18:22 +0100, Bartosz Golaszewski wrote:
> > Here is the promised refactoring of the reset core. The main goal of the
> > series is to make the reset subsystem fwnode-agnostic - meaning it can
> > work with all kinds of firmware nodes instead of being OF-centric - but
> > there are some other related changes in here as well. I'm sending it all
> > out for review to give Phillipp a better picture of the end result but
> > individual pieces can be picked up earlier if accepted.
> [...]
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>
> Applied to reset/next, thanks!
>

Thanks for the careful reviews and spotting all the corner-cases!

Bartosz