Document the new compatible "qcom,x1p42100-iris", which is compatible
with SM8550 but adds an additional set of clocks. The BSE clock is
used to drive the Bin Stream Engine, which is a sub-block of the
video codec hardware responsible for bitstream-level processing.

Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
---
 .../bindings/media/qcom,sm8550-iris.yaml           | 23 +++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
index 9c4b760508b50251ac467ad44a366689260bfc0d..0400ca1bff05dcef6b742c3fbf77e38adca9f280 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
@@ -26,6 +26,7 @@ properties:
           - qcom,qcs8300-iris
           - qcom,sm8550-iris
           - qcom,sm8650-iris
+          - qcom,x1p42100-iris
 
   reg:
     maxItems: 1
@@ -41,13 +42,16 @@ properties:
       - const: mmcx
 
   clocks:
-    maxItems: 3
+    minItems: 3
+    maxItems: 4
 
   clock-names:
+    minItems: 3
     items:
       - const: iface
       - const: core
       - const: vcodec0_core
+      - const: vcodec0_bse
 
   firmware-name:
     maxItems: 1
@@ -115,6 +119,23 @@ allOf:
           maxItems: 1
         reset-names:
           maxItems: 1
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,x1p42100-iris
+    then:
+      properties:
+        clocks:
+          minItems: 4
+        clock-names:
+          minItems: 4
+    else:
+      properties:
+        clocks:
+          maxItems: 3
+        clock-names:
+          maxItems: 3
 
 unevaluatedProperties: false
 

-- 
2.43.0

On Fri, Mar 06, 2026 at 04:44:29PM +0800, Wangao Wang wrote:
> Document the new compatible "qcom,x1p42100-iris", which is compatible
> with SM8550 but adds an additional set of clocks. The BSE clock is

Then please express the compatibility. Device is or is not compatible
and you just wrote that it is.

Best regards,
Krzysztof

On 07/03/2026 14:13, Krzysztof Kozlowski wrote:
> On Fri, Mar 06, 2026 at 04:44:29PM +0800, Wangao Wang wrote:
>> Document the new compatible "qcom,x1p42100-iris", which is compatible
>> with SM8550 but adds an additional set of clocks. The BSE clock is
> 
> Then please express the compatibility. Device is or is not compatible
> and you just wrote that it is.
> 

... so maybe you wanted to say they are not compatible?

Best regards,
Krzysztof

On 2026/3/7 21:19, Krzysztof Kozlowski wrote:
> On 07/03/2026 14:13, Krzysztof Kozlowski wrote:
>> On Fri, Mar 06, 2026 at 04:44:29PM +0800, Wangao Wang wrote:
>>> Document the new compatible "qcom,x1p42100-iris", which is compatible
>>> with SM8550 but adds an additional set of clocks. The BSE clock is
>>
>> Then please express the compatibility. Device is or is not compatible
>> and you just wrote that it is.
>>
> 
> ... so maybe you wanted to say they are not compatible?
> 
> Best regards,
> Krzysztof


They are not DT-compatible. They share the same IP and binding, but
x1p42100 is a separate compatible without fallback to sm8550.

I will correct the commit message in the next revision.

-- 
Best Regards,
Wangao

On 10/03/2026 08:08, Wangao Wang wrote:
> 
> 
> On 2026/3/7 21:19, Krzysztof Kozlowski wrote:
>> On 07/03/2026 14:13, Krzysztof Kozlowski wrote:
>>> On Fri, Mar 06, 2026 at 04:44:29PM +0800, Wangao Wang wrote:
>>>> Document the new compatible "qcom,x1p42100-iris", which is compatible
>>>> with SM8550 but adds an additional set of clocks. The BSE clock is
>>>
>>> Then please express the compatibility. Device is or is not compatible
>>> and you just wrote that it is.
>>>
>>
>> ... so maybe you wanted to say they are not compatible?
>>
>> Best regards,
>> Krzysztof
> 
> 
> They are not DT-compatible. They share the same IP and binding, but

There is no such thing.

> x1p42100 is a separate compatible without fallback to sm8550.

This is useless argument. They are not compatible, because I did not
mark them as compatible.


Best regards,
Krzysztof