[PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports

Krzysztof Kozlowski posted 5 patches 1 month ago
[PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports
Posted by Krzysztof Kozlowski 1 month ago
This MIPI-DSI LCD panel must be connected to something.  According to
scarce web data it supports two channels and it is already used like
this in DTS.  Reported by dtbs_check:

  rockchip/rk3399-gru-scarlet-inx.dtb: panel@0 (innolux,p097pfg): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 .../bindings/display/panel/innolux,p097pfg.yaml    | 26 +++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml b/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
index 4164e3f7061d..7c75e01797f6 100644
--- a/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
+++ b/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
@@ -10,7 +10,7 @@ maintainers:
   - Lin Huang <hl@rock-chips.com>
 
 allOf:
-  - $ref: panel-common.yaml#
+  - $ref: panel-common-dual.yaml#
 
 properties:
   compatible:
@@ -28,6 +28,9 @@ properties:
   avee-supply:
     description: The regulator that provides negative voltage
 
+  port: true
+  ports: true
+
 required:
   - compatible
   - reg
@@ -52,6 +55,27 @@ examples:
             avee-supply = <&avee>;
             backlight = <&backlight>;
             enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
+
+            ports {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                port@0 {
+                    reg = <0>;
+
+                    mipi_in_panel: endpoint {
+                        remote-endpoint = <&mipi_out_panel>;
+                    };
+                };
+
+                port@1 {
+                    reg = <1>;
+
+                    mipi1_in_panel: endpoint {
+                        remote-endpoint = <&mipi1_out_panel>;
+                    };
+                };
+            };
         };
     };
 

-- 
2.51.0
Re: [PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports
Posted by Neil Armstrong 1 month ago
On 3/6/26 13:02, Krzysztof Kozlowski wrote:
> This MIPI-DSI LCD panel must be connected to something.  According to
> scarce web data it supports two channels and it is already used like
> this in DTS.  Reported by dtbs_check:
> 
>    rockchip/rk3399-gru-scarlet-inx.dtb: panel@0 (innolux,p097pfg): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>   .../bindings/display/panel/innolux,p097pfg.yaml    | 26 +++++++++++++++++++++-
>   1 file changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml b/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
> index 4164e3f7061d..7c75e01797f6 100644
> --- a/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
> @@ -10,7 +10,7 @@ maintainers:
>     - Lin Huang <hl@rock-chips.com>
>   
>   allOf:
> -  - $ref: panel-common.yaml#
> +  - $ref: panel-common-dual.yaml#
>   
>   properties:
>     compatible:
> @@ -28,6 +28,9 @@ properties:
>     avee-supply:
>       description: The regulator that provides negative voltage
>   
> +  port: true
> +  ports: true
> +
>   required:
>     - compatible
>     - reg
> @@ -52,6 +55,27 @@ examples:
>               avee-supply = <&avee>;
>               backlight = <&backlight>;
>               enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
> +
> +            ports {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +
> +                port@0 {
> +                    reg = <0>;
> +
> +                    mipi_in_panel: endpoint {
> +                        remote-endpoint = <&mipi_out_panel>;
> +                    };
> +                };
> +
> +                port@1 {
> +                    reg = <1>;
> +
> +                    mipi1_in_panel: endpoint {
> +                        remote-endpoint = <&mipi1_out_panel>;
> +                    };
> +                };
> +            };
>           };
>       };
>   
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil